From: "André Roth" <neolynx@gmail.com>
To: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH 4/3] [media] siano: Use the default firmware for Stellar
Date: Fri, 13 Sep 2013 01:33:01 +0200 [thread overview]
Message-ID: <20130913013301.5dc599f1@neutrino.exnihilo> (raw)
In-Reply-To: <1379016247-19744-1-git-send-email-m.chehab@samsung.com>
On Thu, 12 Sep 2013 17:04:07 -0300
Mauro Carvalho Chehab <m.chehab@samsung.com> wrote:
Tested-by: André Roth <neolynx@gmail.com>
> The Stellar firmware load routine is different. Improve it to use
> the default firmware, if no modprobe parameter tells otherwise.
>
> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
> ---
> drivers/media/usb/siano/smsusb.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/usb/siano/smsusb.c b/drivers/media/usb/siano/smsusb.c
> index 33f3575..05bd91a 100644
> --- a/drivers/media/usb/siano/smsusb.c
> +++ b/drivers/media/usb/siano/smsusb.c
> @@ -245,6 +245,9 @@ static int smsusb1_load_firmware(struct usb_device *udev, int id, int board_id)
> int rc, dummy;
> char *fw_filename;
>
> + if (id < 0)
> + id = sms_get_board(board_id)->default_mode;
> +
> if (id < DEVICE_MODE_DVBT || id > DEVICE_MODE_DVBT_BDA) {
> sms_err("invalid firmware id specified %d", id);
> return -EINVAL;
next prev parent reply other threads:[~2013-09-12 23:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 19:59 [PATCH 0/3] Some improvements/fixes for Siano driver Mauro Carvalho Chehab
2013-09-12 19:59 ` [PATCH 1/3] [media] siano: Don't show debug messages as errors Mauro Carvalho Chehab
2013-09-12 23:28 ` André Roth
2013-09-12 19:59 ` [PATCH 2/3] [media] siano: Improve debug/info messages Mauro Carvalho Chehab
2013-09-12 23:28 ` André Roth
2013-09-12 20:00 ` [PATCH 3/3] [media] siano: Fix initialization for Stellar models Mauro Carvalho Chehab
2013-09-12 23:29 ` André Roth
2013-09-12 23:32 ` André Roth
2013-09-12 20:04 ` [PATCH 4/3] [media] siano: Use the default firmware for Stellar Mauro Carvalho Chehab
2013-09-12 23:33 ` André Roth [this message]
2013-09-12 23:35 ` [PATCH 0/3] Some improvements/fixes for Siano driver André Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130913013301.5dc599f1@neutrino.exnihilo \
--to=neolynx@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox