From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout1.w2.samsung.com ([211.189.100.11]:15504 "EHLO usmailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758259Ab3JQRqN (ORCPT ); Thu, 17 Oct 2013 13:46:13 -0400 Date: Thu, 17 Oct 2013 14:46:04 -0300 From: Mauro Carvalho Chehab To: Lars-Peter Clausen Cc: Wolfram Sang , David Airlie , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, alsa-devel@alsa-project.org, Kyungmin Park , Sylwester Nawrocki Subject: Re: [PATCH 2/8] [media] exynos4-is: Don't use i2c_client->driver Message-id: <20131017144604.1d649988@samsung.com> In-reply-to: <1380444666-12019-3-git-send-email-lars@metafoo.de> References: <1380444666-12019-1-git-send-email-lars@metafoo.de> <1380444666-12019-3-git-send-email-lars@metafoo.de> MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Sun, 29 Sep 2013 10:51:00 +0200 Lars-Peter Clausen escreveu: > The 'driver' field of the i2c_client struct is redundant and is going to be > removed. The results of the expressions 'client->driver.driver->field' and > 'client->dev.driver->field' are identical, so replace all occurrences of the > former with the later. > > Signed-off-by: Lars-Peter Clausen > Cc: Kyungmin Park > Cc: Sylwester Nawrocki Acked-by: Mauro Carvalho Chehab > --- > drivers/media/platform/exynos4-is/media-dev.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/exynos4-is/media-dev.c b/drivers/media/platform/exynos4-is/media-dev.c > index a835112..7a4ee4c 100644 > --- a/drivers/media/platform/exynos4-is/media-dev.c > +++ b/drivers/media/platform/exynos4-is/media-dev.c > @@ -411,8 +411,8 @@ static int fimc_md_of_add_sensor(struct fimc_md *fmd, > > device_lock(&client->dev); > > - if (!client->driver || > - !try_module_get(client->driver->driver.owner)) { > + if (!client->dev.driver || > + !try_module_get(client->dev.driver->owner)) { > ret = -EPROBE_DEFER; > v4l2_info(&fmd->v4l2_dev, "No driver found for %s\n", > node->full_name); > @@ -442,7 +442,7 @@ static int fimc_md_of_add_sensor(struct fimc_md *fmd, > fmd->num_sensors++; > > mod_put: > - module_put(client->driver->driver.owner); > + module_put(client->dev.driver->owner); > dev_put: > device_unlock(&client->dev); > put_device(&client->dev); -- Cheers, Mauro