* [PATCH] rtl2830: add parent for I2C adapter
@ 2013-10-21 20:12 Antti Palosaari
2013-10-21 20:20 ` Antti Palosaari
0 siblings, 1 reply; 10+ messages in thread
From: Antti Palosaari @ 2013-10-21 20:12 UTC (permalink / raw)
To: linux-media; +Cc: Antti Palosaari
i2c i2c-6: adapter [RTL2830 tuner I2C adapter] registered
BUG: unable to handle kernel NULL pointer dereference at 0000000000000220
IP: [<ffffffffa0002900>] i2c_register_adapter+0x130/0x390 [i2c_core]
Signed-off-by: Antti Palosaari <crope@iki.fi>
---
drivers/media/dvb-frontends/rtl2830.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/dvb-frontends/rtl2830.c b/drivers/media/dvb-frontends/rtl2830.c
index 362d26d..68ee70b 100644
--- a/drivers/media/dvb-frontends/rtl2830.c
+++ b/drivers/media/dvb-frontends/rtl2830.c
@@ -700,6 +700,7 @@ struct dvb_frontend *rtl2830_attach(const struct rtl2830_config *cfg,
sizeof(priv->tuner_i2c_adapter.name));
priv->tuner_i2c_adapter.algo = &rtl2830_tuner_i2c_algo;
priv->tuner_i2c_adapter.algo_data = NULL;
+ priv->tuner_i2c_adapter.dev.parent = &i2c->dev;
i2c_set_adapdata(&priv->tuner_i2c_adapter, priv);
if (i2c_add_adapter(&priv->tuner_i2c_adapter) < 0) {
dev_err(&i2c->dev,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] rtl2830: add parent for I2C adapter
2013-10-21 20:12 [PATCH] rtl2830: add parent for I2C adapter Antti Palosaari
@ 2013-10-21 20:20 ` Antti Palosaari
2013-10-29 21:17 ` Antti Palosaari
2013-10-30 15:16 ` Wolfram Sang
0 siblings, 2 replies; 10+ messages in thread
From: Antti Palosaari @ 2013-10-21 20:20 UTC (permalink / raw)
To: Phil Carmody, Wolfram Sang; +Cc: linux-media
Hello Phil and Wolfram,
I found one of my drivers was crashing when DTV USB stick was plugged.
Patch in that mail patch fixes the problem.
I quickly looked possible I2C patches causing the problem and saw that
one as most suspicions:
commit 3923172b3d700486c1ca24df9c4c5405a83e2309
i2c: reduce parent checking to a NOOP in non-I2C_MUX case
My config has no CONFIG_I2C_MUX set currently, but I am not sure how it
has been earlier.
Any idea?
regards
Antti
On 21.10.2013 23:12, Antti Palosaari wrote:
> i2c i2c-6: adapter [RTL2830 tuner I2C adapter] registered
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000220
> IP: [<ffffffffa0002900>] i2c_register_adapter+0x130/0x390 [i2c_core]
>
> Signed-off-by: Antti Palosaari <crope@iki.fi>
> ---
> drivers/media/dvb-frontends/rtl2830.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/dvb-frontends/rtl2830.c b/drivers/media/dvb-frontends/rtl2830.c
> index 362d26d..68ee70b 100644
> --- a/drivers/media/dvb-frontends/rtl2830.c
> +++ b/drivers/media/dvb-frontends/rtl2830.c
> @@ -700,6 +700,7 @@ struct dvb_frontend *rtl2830_attach(const struct rtl2830_config *cfg,
> sizeof(priv->tuner_i2c_adapter.name));
> priv->tuner_i2c_adapter.algo = &rtl2830_tuner_i2c_algo;
> priv->tuner_i2c_adapter.algo_data = NULL;
> + priv->tuner_i2c_adapter.dev.parent = &i2c->dev;
> i2c_set_adapdata(&priv->tuner_i2c_adapter, priv);
> if (i2c_add_adapter(&priv->tuner_i2c_adapter) < 0) {
> dev_err(&i2c->dev,
>
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] rtl2830: add parent for I2C adapter
2013-10-21 20:20 ` Antti Palosaari
@ 2013-10-29 21:17 ` Antti Palosaari
2013-10-30 15:16 ` Wolfram Sang
1 sibling, 0 replies; 10+ messages in thread
From: Antti Palosaari @ 2013-10-29 21:17 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-media
Wolfram,
Phil email address was not valid anymore, so could you Wolfram, as a I2C
subsystem maintainer, look and comment that. The fact is that my driver
has a 3.12 regression and I want to know where it is coming from to make
decision what to do!
regards
Antti
On 21.10.2013 23:20, Antti Palosaari wrote:
> Hello Phil and Wolfram,
>
> I found one of my drivers was crashing when DTV USB stick was plugged.
> Patch in that mail patch fixes the problem.
>
> I quickly looked possible I2C patches causing the problem and saw that
> one as most suspicions:
>
> commit 3923172b3d700486c1ca24df9c4c5405a83e2309
> i2c: reduce parent checking to a NOOP in non-I2C_MUX case
>
> My config has no CONFIG_I2C_MUX set currently, but I am not sure how it
> has been earlier.
>
> Any idea?
>
> regards
> Antti
>
>
> On 21.10.2013 23:12, Antti Palosaari wrote:
>> i2c i2c-6: adapter [RTL2830 tuner I2C adapter] registered
>> BUG: unable to handle kernel NULL pointer dereference at 0000000000000220
>> IP: [<ffffffffa0002900>] i2c_register_adapter+0x130/0x390 [i2c_core]
>>
>> Signed-off-by: Antti Palosaari <crope@iki.fi>
>> ---
>> drivers/media/dvb-frontends/rtl2830.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/media/dvb-frontends/rtl2830.c
>> b/drivers/media/dvb-frontends/rtl2830.c
>> index 362d26d..68ee70b 100644
>> --- a/drivers/media/dvb-frontends/rtl2830.c
>> +++ b/drivers/media/dvb-frontends/rtl2830.c
>> @@ -700,6 +700,7 @@ struct dvb_frontend *rtl2830_attach(const struct
>> rtl2830_config *cfg,
>> sizeof(priv->tuner_i2c_adapter.name));
>> priv->tuner_i2c_adapter.algo = &rtl2830_tuner_i2c_algo;
>> priv->tuner_i2c_adapter.algo_data = NULL;
>> + priv->tuner_i2c_adapter.dev.parent = &i2c->dev;
>> i2c_set_adapdata(&priv->tuner_i2c_adapter, priv);
>> if (i2c_add_adapter(&priv->tuner_i2c_adapter) < 0) {
>> dev_err(&i2c->dev,
>>
>
>
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] rtl2830: add parent for I2C adapter
2013-10-21 20:20 ` Antti Palosaari
2013-10-29 21:17 ` Antti Palosaari
@ 2013-10-30 15:16 ` Wolfram Sang
2013-10-30 15:35 ` Antti Palosaari
2013-10-30 15:36 ` Antti Palosaari
1 sibling, 2 replies; 10+ messages in thread
From: Wolfram Sang @ 2013-10-30 15:16 UTC (permalink / raw)
To: Antti Palosaari; +Cc: Phil Carmody, linux-media
[-- Attachment #1: Type: text/plain, Size: 916 bytes --]
Hi,
sorry for the delay. The Kernel Summit made a pretty busy time out of
the last weeks...
> I found one of my drivers was crashing when DTV USB stick was
> plugged. Patch in that mail patch fixes the problem.
Well, if you have a parent, it should be set. This is always a good
idea. Can't really tell why not having it causes the BUG, though.
> I quickly looked possible I2C patches causing the problem and saw
> that one as most suspicions:
>
> commit 3923172b3d700486c1ca24df9c4c5405a83e2309
> i2c: reduce parent checking to a NOOP in non-I2C_MUX case
Did you try reverting it? I am not sure this is the one.
> >i2c i2c-6: adapter [RTL2830 tuner I2C adapter] registered
> >BUG: unable to handle kernel NULL pointer dereference at 0000000000000220
> >IP: [<ffffffffa0002900>] i2c_register_adapter+0x130/0x390 [i2c_core]
Can we have the full BUG output?
Regards,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rtl2830: add parent for I2C adapter
2013-10-30 15:16 ` Wolfram Sang
@ 2013-10-30 15:35 ` Antti Palosaari
2013-10-30 15:36 ` Antti Palosaari
1 sibling, 0 replies; 10+ messages in thread
From: Antti Palosaari @ 2013-10-30 15:35 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-media
On 30.10.2013 17:16, Wolfram Sang wrote:
> Hi,
>
> sorry for the delay. The Kernel Summit made a pretty busy time out of
> the last weeks...
>
>> I found one of my drivers was crashing when DTV USB stick was
>> plugged. Patch in that mail patch fixes the problem.
>
> Well, if you have a parent, it should be set. This is always a good
> idea. Can't really tell why not having it causes the BUG, though.
>
>> I quickly looked possible I2C patches causing the problem and saw
>> that one as most suspicions:
>>
>> commit 3923172b3d700486c1ca24df9c4c5405a83e2309
>> i2c: reduce parent checking to a NOOP in non-I2C_MUX case
>
> Did you try reverting it? I am not sure this is the one.
Nope, not to mentio bisect. I have done bisect few times and I am not
going to waste whole day of compiling and booting new kernels.
Crash disappeared whit that little patch. I did also some DVB USB core
changes for 3.12, but I cannot see it could be root of cause that crash.
>>> i2c i2c-6: adapter [RTL2830 tuner I2C adapter] registered
>>> BUG: unable to handle kernel NULL pointer dereference at 0000000000000220
>>> IP: [<ffffffffa0002900>] i2c_register_adapter+0x130/0x390 [i2c_core]
>
> Can we have the full BUG output?
See attachement.
Anyway, I am going to ask Mauro to merge that I2C parent patch and maybe
try to sent it stable too as it is likely a bit too late for 3.12 RC.
regards
Antti
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rtl2830: add parent for I2C adapter
2013-10-30 15:16 ` Wolfram Sang
2013-10-30 15:35 ` Antti Palosaari
@ 2013-10-30 15:36 ` Antti Palosaari
2013-10-30 15:45 ` Wolfram Sang
1 sibling, 1 reply; 10+ messages in thread
From: Antti Palosaari @ 2013-10-30 15:36 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-media
[-- Attachment #1: Type: text/plain, Size: 1448 bytes --]
(now with an attachement)
On 30.10.2013 17:16, Wolfram Sang wrote:
> Hi,
>
> sorry for the delay. The Kernel Summit made a pretty busy time out of
> the last weeks...
>
>> I found one of my drivers was crashing when DTV USB stick was
>> plugged. Patch in that mail patch fixes the problem.
>
> Well, if you have a parent, it should be set. This is always a good
> idea. Can't really tell why not having it causes the BUG, though.
>
>> I quickly looked possible I2C patches causing the problem and saw
>> that one as most suspicions:
>>
>> commit 3923172b3d700486c1ca24df9c4c5405a83e2309
>> i2c: reduce parent checking to a NOOP in non-I2C_MUX case
>
> Did you try reverting it? I am not sure this is the one.
Nope, not to mentio bisect. I have done bisect few times and I am not
going to waste whole day of compiling and booting new kernels.
Crash disappeared whit that little patch. I did also some DVB USB core
changes for 3.12, but I cannot see it could be root of cause that crash.
>>> i2c i2c-6: adapter [RTL2830 tuner I2C adapter] registered
>>> BUG: unable to handle kernel NULL pointer dereference at 0000000000000220
>>> IP: [<ffffffffa0002900>] i2c_register_adapter+0x130/0x390 [i2c_core]
>
> Can we have the full BUG output?
See attachement.
Anyway, I am going to ask Mauro to merge that I2C parent patch and maybe
try to sent it stable too as it is likely a bit too late for 3.12 RC.
regards
Antti
--
http://palosaari.fi/
[-- Attachment #2: rtl2830_i2c_adapter_crash.txt --]
[-- Type: text/plain, Size: 6910 bytes --]
loka 30 17:28:09 localhost.localdomain kernel: usb 2-2: new high-speed USB device number 2 using ehci-pci
loka 30 17:28:09 localhost.localdomain kernel: usb 2-2: New USB device found, idVendor=14aa, idProduct=0160
loka 30 17:28:09 localhost.localdomain kernel: usb 2-2: New USB device strings: Mfr=1, Product=2, SerialNumber=3
loka 30 17:28:09 localhost.localdomain kernel: [31B blob data]
loka 30 17:28:09 localhost.localdomain kernel: [36B blob data]
loka 30 17:28:09 localhost.localdomain kernel: usb 2-2: SerialNumber: 0000000000065658
loka 30 17:28:09 localhost.localdomain mtp-probe[3060]: checking bus 2, device 2: "/sys/devices/pci0000:00/0000:00:13.2/usb2/2-2"
loka 30 17:28:09 localhost.localdomain mtp-probe[3060]: bus: 2, device: 2 was not an MTP device
loka 30 17:28:09 localhost.localdomain kernel: usb 2-2: dvb_usb_v2: found a 'Freecom USB2.0 DVB-T' in warm state
loka 30 17:28:09 localhost.localdomain kernel: usb 2-2: dvb_usb_v2: will pass the complete MPEG2 transport stream to the software demuxer
loka 30 17:28:09 localhost.localdomain kernel: DVB: registering new adapter (Freecom USB2.0 DVB-T)
loka 30 17:28:09 localhost.localdomain kernel: BUG: unable to handle kernel NULL pointer dereference at 0000000000000220
loka 30 17:28:09 localhost.localdomain kernel: IP: [<ffffffffa0002900>] i2c_register_adapter+0x130/0x390 [i2c_core]
loka 30 17:28:09 localhost.localdomain systemd-udevd[434]: worker [3059] terminated by signal 9 (Killed)
loka 30 17:28:09 localhost.localdomain systemd-udevd[434]: worker [3059] failed while handling '/devices/pci0000:00/0000:00:13.2/usb2/2-2/2-2:1.0'
loka 30 17:28:09 localhost.localdomain kernel: PGD 0
loka 30 17:28:09 localhost.localdomain kernel: Oops: 0000 [#1] SMP
loka 30 17:28:09 localhost.localdomain kernel: Modules linked in: dvb_usb_rtl28xxu(O+) rtl2830(O) dvb_usb_v2(O) fuse nf_conntrack_netbios_ns nf_conntrack_broadcast ipt_MAS...p6table_man
loka 30 17:28:09 localhost.localdomain kernel: btusb snd_pcm bluetooth rc_core(O) microcode nfsd serio_raw edac_core pcspkr k10temp edac_mce_amd r8169 snd_page_alloc rfkill snd_time...
loka 30 17:28:09 localhost.localdomain kernel: CPU: 1 PID: 3059 Comm: systemd-udevd Tainted: G O 3.12.0-rc2+ #69
loka 30 17:28:09 localhost.localdomain kernel: Hardware name: System manufacturer System Product Name/M5A78L-M/USB3, BIOS 1503 11/14/2012
loka 30 17:28:09 localhost.localdomain kernel: task: ffff8800cf87ed60 ti: ffff8800bee5a000 task.ti: ffff8800bee5a000
loka 30 17:28:09 localhost.localdomain kernel: RIP: 0010:[<ffffffffa0002900>] [<ffffffffa0002900>] i2c_register_adapter+0x130/0x390 [i2c_core]
loka 30 17:28:09 localhost.localdomain kernel: RSP: 0018:ffff8800bee5baa8 EFLAGS: 00010246
loka 30 17:28:09 localhost.localdomain kernel: RAX: 0000000000000000 RBX: ffff880237066520 RCX: ffff8800cee94da8
loka 30 17:28:09 localhost.localdomain kernel: RDX: ffff8800cee95e88 RSI: ffff88030971aec8 RDI: ffffffff81c70e60
loka 30 17:28:09 localhost.localdomain kernel: RBP: ffff8800bee5bac8 R08: ffff8800cee95e88 R09: 0000000000000000
loka 30 17:28:09 localhost.localdomain kernel: R10: 0000000000005457 R11: 0000000000000000 R12: 0000000000000000
loka 30 17:28:09 localhost.localdomain kernel: R13: ffff880237066568 R14: 0000000000000000 R15: ffff880237066520
loka 30 17:28:09 localhost.localdomain kernel: FS: 00007fd41e084880(0000) GS:ffff88031fc40000(0000) knlGS:0000000000000000
loka 30 17:28:09 localhost.localdomain kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
loka 30 17:28:09 localhost.localdomain kernel: CR2: 0000000000000220 CR3: 00000000b8724000 CR4: 00000000000007e0
loka 30 17:28:09 localhost.localdomain kernel: Stack:
loka 30 17:28:09 localhost.localdomain kernel: ffff880237066520 ffff880237066520 0000000000000009 ffff880237066008
loka 30 17:28:09 localhost.localdomain kernel: ffff8800bee5bae8 ffffffffa0002bbe ffff880237066000 ffff88030a00a0b0
loka 30 17:28:09 localhost.localdomain kernel: ffff8800bee5bb28 ffffffffa067e3ed 00ff88030a00a000 ffff88030a00a420
loka 30 17:28:09 localhost.localdomain kernel: Call Trace:
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffffa0002bbe>] i2c_add_adapter+0x5e/0x70 [i2c_core]
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffffa067e3ed>] rtl2830_attach+0x11d/0xd30 [rtl2830]
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffffa068f345>] rtl2831u_frontend_attach+0xc5/0x1c0 [dvb_usb_rtl28xxu]
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffffa0686807>] dvb_usbv2_probe+0x607/0x1160 [dvb_usb_v2]
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffff814058a8>] ? __pm_runtime_set_status+0x128/0x1f0
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffff81476a94>] usb_probe_interface+0x1c4/0x2f0
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffff813f9387>] driver_probe_device+0x87/0x390
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffff813f9763>] __driver_attach+0x93/0xa0
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffff813f96d0>] ? __device_attach+0x40/0x40
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffff813f7243>] bus_for_each_dev+0x63/0xa0
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffff813f8dde>] driver_attach+0x1e/0x20
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffff813f8950>] bus_add_driver+0x200/0x2d0
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffff813f9d94>] driver_register+0x64/0xf0
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffff81475281>] usb_register_driver+0x81/0x160
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffffa0698000>] ? 0xffffffffa0697fff
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffffa069801e>] rtl28xxu_usb_driver_init+0x1e/0x1000 [dvb_usb_rtl28xxu]
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffff810020fa>] do_one_initcall+0xfa/0x1b0
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffff81053523>] ? set_memory_nx+0x43/0x50
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffff810d374d>] load_module+0x1b9d/0x2640
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffff810cf9b0>] ? store_uevent+0x40/0x40
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffff810d4366>] SyS_finit_module+0x86/0xb0
loka 30 17:28:09 localhost.localdomain kernel: [<ffffffff816659a9>] system_call_fastpath+0x16/0x1b
loka 30 17:28:09 localhost.localdomain kernel: Code: df 01 00 00 48 81 fa 60 02 00 a0 0f 84 fa 01 00 00 48 83 78 10 00 0f 84 9f 01 00 00 48 83 78 08 00 0f 84 94 01 00 00 4...4 24 00 00
loka 30 17:28:09 localhost.localdomain kernel: RIP [<ffffffffa0002900>] i2c_register_adapter+0x130/0x390 [i2c_core]
loka 30 17:28:09 localhost.localdomain kernel: RSP <ffff8800bee5baa8>
loka 30 17:28:09 localhost.localdomain kernel: CR2: 0000000000000220
loka 30 17:28:09 localhost.localdomain kernel: ---[ end trace fb79592d1bc9e92c ]---
loka 30 17:28:10 localhost.localdomain kernel: usb 2-2: USB disconnect, device number 2
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rtl2830: add parent for I2C adapter
2013-10-30 15:36 ` Antti Palosaari
@ 2013-10-30 15:45 ` Wolfram Sang
2013-10-30 15:51 ` Antti Palosaari
0 siblings, 1 reply; 10+ messages in thread
From: Wolfram Sang @ 2013-10-30 15:45 UTC (permalink / raw)
To: Antti Palosaari; +Cc: linux-media
[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]
> >>commit 3923172b3d700486c1ca24df9c4c5405a83e2309
> >>i2c: reduce parent checking to a NOOP in non-I2C_MUX case
> >
> >Did you try reverting it? I am not sure this is the one.
>
> Nope, not to mentio bisect. I have done bisect few times and I am
> not going to waste whole day of compiling and booting new kernels.
Well, I intentionally asked for revert not bisect. Removing the #ifdef
can easily be done by hand if needed and will just need one recompile to
make sure.
> Crash disappeared whit that little patch.
Yes, still I'd like to understand where the BUG came from. There are
probably other driver in need of a fix, too.
> Anyway, I am going to ask Mauro to merge that I2C parent patch and
> maybe try to sent it stable too as it is likely a bit too late for
> 3.12 RC.
If it fixes a crash, I wouldn't consider it too late. Yet only given we
have understood this is a proper fix.
Was there a change in using CONFIG_I2C_COMPAT? Is it currently used?
Regards,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rtl2830: add parent for I2C adapter
2013-10-30 15:45 ` Wolfram Sang
@ 2013-10-30 15:51 ` Antti Palosaari
2013-10-30 16:02 ` Wolfram Sang
0 siblings, 1 reply; 10+ messages in thread
From: Antti Palosaari @ 2013-10-30 15:51 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-media, Jean Delvare
On 30.10.2013 17:45, Wolfram Sang wrote:
>
>>>> commit 3923172b3d700486c1ca24df9c4c5405a83e2309
>>>> i2c: reduce parent checking to a NOOP in non-I2C_MUX case
>>>
>>> Did you try reverting it? I am not sure this is the one.
>>
>> Nope, not to mentio bisect. I have done bisect few times and I am
>> not going to waste whole day of compiling and booting new kernels.
>
> Well, I intentionally asked for revert not bisect. Removing the #ifdef
> can easily be done by hand if needed and will just need one recompile to
> make sure.
Yes, but compiling whole Kernel is always pain. I dont certainly want to
do that just for testing some patches.
>> Crash disappeared whit that little patch.
>
> Yes, still I'd like to understand where the BUG came from. There are
> probably other driver in need of a fix, too.
>
>> Anyway, I am going to ask Mauro to merge that I2C parent patch and
>> maybe try to sent it stable too as it is likely a bit too late for
>> 3.12 RC.
>
> If it fixes a crash, I wouldn't consider it too late. Yet only given we
> have understood this is a proper fix.
>
> Was there a change in using CONFIG_I2C_COMPAT? Is it currently used?
Jean jsut pointed out on IRC that this patch likely fixes the issue:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=47b6e477ed4ecacddd1f82d04d686026e08dc3db
As that patch is already applied to 3.12 it should be fine. I was
running media master which is based 3.12-rc2.
So I am sending that patch to Kernel 3.13.
regards
Antti
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rtl2830: add parent for I2C adapter
2013-10-30 15:51 ` Antti Palosaari
@ 2013-10-30 16:02 ` Wolfram Sang
2013-10-30 16:29 ` Antti Palosaari
0 siblings, 1 reply; 10+ messages in thread
From: Wolfram Sang @ 2013-10-30 16:02 UTC (permalink / raw)
To: Antti Palosaari; +Cc: linux-media, Jean Delvare
[-- Attachment #1: Type: text/plain, Size: 831 bytes --]
> >Well, I intentionally asked for revert not bisect. Removing the #ifdef
> >can easily be done by hand if needed and will just need one recompile to
> >make sure.
>
> Yes, but compiling whole Kernel is always pain. I dont certainly
> want to do that just for testing some patches.
Well, if you ask for support for debugging, you should be prepared to do
exactly that.
> Jean jsut pointed out on IRC that this patch likely fixes the issue:
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=47b6e477ed4ecacddd1f82d04d686026e08dc3db
Yup, he is right. You have ACPI enabled.
> As that patch is already applied to 3.12 it should be fine. I was
> running media master which is based 3.12-rc2.
Asking you to build the latest kernel might have been another thing I'd
ask you to do.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rtl2830: add parent for I2C adapter
2013-10-30 16:02 ` Wolfram Sang
@ 2013-10-30 16:29 ` Antti Palosaari
0 siblings, 0 replies; 10+ messages in thread
From: Antti Palosaari @ 2013-10-30 16:29 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-media, Jean Delvare
On 30.10.2013 18:02, Wolfram Sang wrote:
>
>>> Well, I intentionally asked for revert not bisect. Removing the #ifdef
>>> can easily be done by hand if needed and will just need one recompile to
>>> make sure.
>>
>> Yes, but compiling whole Kernel is always pain. I dont certainly
>> want to do that just for testing some patches.
>
> Well, if you ask for support for debugging, you should be prepared to do
> exactly that.
>
>> Jean jsut pointed out on IRC that this patch likely fixes the issue:
>> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=47b6e477ed4ecacddd1f82d04d686026e08dc3db
>
> Yup, he is right. You have ACPI enabled.
>
>> As that patch is already applied to 3.12 it should be fine. I was
>> running media master which is based 3.12-rc2.
>
> Asking you to build the latest kernel might have been another thing I'd
> ask you to do.
I installed that single patch top of media master tree and it fixes the
problem. Maybe this is enough If there is still good reason to latest
Linus tree I can do that too.
RTL2830 adapter parent patch will go to the 3.13.
Thanks Jean and Wolfram
regards
Antti
--
http://palosaari.fi/
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-10-30 16:29 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-21 20:12 [PATCH] rtl2830: add parent for I2C adapter Antti Palosaari
2013-10-21 20:20 ` Antti Palosaari
2013-10-29 21:17 ` Antti Palosaari
2013-10-30 15:16 ` Wolfram Sang
2013-10-30 15:35 ` Antti Palosaari
2013-10-30 15:36 ` Antti Palosaari
2013-10-30 15:45 ` Wolfram Sang
2013-10-30 15:51 ` Antti Palosaari
2013-10-30 16:02 ` Wolfram Sang
2013-10-30 16:29 ` Antti Palosaari
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).