Re: cx23885: Add basic analog radio support

[Mauro Carvalho Chehab <m.chehab@samsung.com>]

Em Fri, 04 Oct 2013 15:56:23 -0300
Alfredo Jesús Delaiti  <alfredodelaiti@netscape.net> escreveu:

> Hi all
> 
> 
> El 14/01/12 15:25, Miroslav Slugeň escribió:
> > New version of patch, fixed video modes for DVR3200 tuners and working
> > audio mux.
> 
> I tested this patch (https://linuxtv.org/patch/9498/) with the latest 
> versions of git (September 28, 2013) with my TV card (Mygica X8507) and 
> it works.
> I found some issue, although it may be through a bad implementation of mine.
> 
> Details of them:
> 
> 1) Some warning when compiling
> 
> ...
>    CC [M] 
> /home/alfredo/ISDB/Nuevo_Driver/git/media_build/v4l/cx23885-video.o
> /home/alfredo/ISDB/Nuevo_Driver/git/media_build/v4l/cx23885-video.c:1910:8: 
> : initialization from incompatible pointer type [enabled by default]
> /home/alfredo/ISDB/Nuevo_Driver/git/media_build/v4l/cx23885-video.c:1910:8: 
> warning: (near initialization for 'radio_ioctl_ops.vidioc_s_tuner') 
> [enabled by default]
> /home/alfredo/ISDB/Nuevo_Driver/git/media_build/v4l/cx23885-video.c:1911:8: 
> warning: initialization from incompatible pointer type [enabled by default]
> /home/alfredo/ISDB/Nuevo_Driver/git/media_build/v4l/cx23885-video.c:1911:8: 
> warning: (near initialization for 'radio_ioctl_ops.vidioc_s_audio') 
> [enabled by default]
>    CC [M] /home/alfredo/ISDB/Nuevo_Driver/git/media_build/v4l/cx23885-vbi.o
> ...
> 
> --------------------------------------------------------
> static const struct v4l2_ioctl_ops radio_ioctl_ops = {
> 
>         .vidioc_s_tuner       = radio_s_tuner, /* line 1910 */
>         .vidioc_s_audio       = radio_s_audio, /* line 1911 */
> 
> --------------------------------------------------------
> 
> 2)
> No reports signal strength or stereo signal with KRadio. XC5000 neither 
> reported (modprobe xc5000 debug=1). Maybe a feature XC5000.
> To listen in stereo, sometimes, you have to turn on the Digital TV then 
> Analog TV and then radio.
> 
> 3)
> To listen Analog TV I need changed to NTSC standard and then PAL-Nc (the 
> norm in my country is PAL-Nc). If I leave the tune in NTSC no problem 
> with sound.
> The patch (https://linuxtv.org/patch/9505/) corrects the latter, if used 
> tvtime with xawtv not always.
> If I see-Digital TV (ISDB-T), then so as to listen the radio I have 
> first put the TV-Analog, because I hear very low and a strong white noise.
> The latter is likely to be corrected by resetting the tuner, I have to 
> study it more.
> 
> I put below attached the patch applied to the plate: X8507.
> 
> Have you done any update of this patch?

Hi Alfredo,

My understanding is that the patch you've enclosed is incomplete and
depends on Miroslav's patch.

As he have you his ack to rework on it, could you please prepare a
patch series addressing the above comments for us to review?

Than
-- 

Cheers,
Mauro