From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout2.w2.samsung.com ([211.189.100.12]:36152 "EHLO usmailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751371Ab3KBTky (ORCPT ); Sat, 2 Nov 2013 15:40:54 -0400 Date: Sat, 02 Nov 2013 17:40:47 -0200 From: Mauro Carvalho Chehab To: Paul Bolle Cc: Martin Walch , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Larry Finger , linux-media@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [kconfig] update: results of some syntactical checks Message-id: <20131102174047.70c24ed8@samsung.com> In-reply-to: <1383420054.4378.3.camel@x220.thuisdomein> References: <3513955.N5RNgL3hPx@tacticalops> <1383420054.4378.3.camel@x220.thuisdomein> MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Sat, 02 Nov 2013 20:20:54 +0100 Paul Bolle escreveu: > On Sun, 2013-10-20 at 00:03 +0200, Martin Walch wrote: > > drivers/media/common/siano/Kconfig:21-26 > > > config SMS_SIANO_DEBUGFS > > > bool "Enable debugfs for smsdvb" > > > depends on SMS_SIANO_MDTV > > > depends on DEBUG_FS > > > depends on SMS_USB_DRV > > > depends on CONFIG_SMS_USB_DRV = CONFIG_SMS_SDIO_DRV > > > > The last line adds the dependency CONFIG_SMS_USB_DRV = CONFIG_SMS_SDIO_DRV. > > This expression does not look sound as those two symbols are not declared > > anywhere. So, the two strings CONFIG_SMS_USB_DRV and CONFIG_SMS_SDIO_DRV > > are compared, yielding always 'n'. As a result, SMS_SIANO_DEBUGFS will never > > be enabled. > > Those are obvious typos. Still present in v3.12-rc7. Perhaps you'd like > to send the trivial patch to fix this? Yes, it is a typo... > > > Probably, it was meant to say something like > > > depends on SMS_USB_DRV = SMS_SDIO_DRV But this is not the right thing to do. The Kconfig logic here is that it should depends on !SMS_SDIO_DRV or SMS_USB_DRV = SMS_SDIO_DRV. I remember I made a patch like that while testing some things with this driver, but it seems that I forgot to push. I might have it somewhere on my test machine. -- Cheers, Mauro