public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <m.chehab@samsung.com>
To: CrazyCat <crazycat69@narod.ru>, linux-media@vger.kernel.org
Subject: Re: [PATCH] tda18271-fe: Fix dvb-c standard selection
Date: Sat, 02 Nov 2013 22:19:56 -0200	[thread overview]
Message-ID: <20131102221956.1e241d02@samsung.com> (raw)
In-Reply-To: <52756F4E.3030805@narod.ru>

Em Sat, 02 Nov 2013 23:31:58 +0200
CrazyCat <crazycat69@narod.ru> escreveu:

> Mauro Carvalho Chehab пишет:
> > This is wrong, as it breaks for 6MHz-spaced channels, like what's used
> > in Brazil and Japan.
> >
> > What happens here is that, if the tuner uses a too wide lowpass filter,
> > the interference will be higher at the demod, and it may not be able
> > to decode.
> >
> > As the bandwidth is already estimated by the DVB frontend core, the
> > tuners should be adjusted to get the closest filter for a given
> > bandwidth.
> >
> > So, the driver is correct (and it is tested under 6MHz spaced channels).
> 
> But usual applications only set cable standard (Annex A/C or B) and not set bandwidth. So for annex A/C default selected 6MHz ?

Usual applications set the symbol rate, and symbol rate is easily
converted into bandwidth. The DVB core does that. see 
dtv_set_frontend():

	switch (c->delivery_system) {
	case SYS_ATSC:
	case SYS_DVBC_ANNEX_B:
		c->bandwidth_hz = 6000000;
		break;
	case SYS_DVBC_ANNEX_A:
		rolloff = 115;
		break;
	case SYS_DVBC_ANNEX_C:
		rolloff = 113;
		break;
	default:
		break;
	}
	if (rolloff)
		c->bandwidth_hz = (c->symbol_rate * rolloff) / 100;

-- 

Cheers,
Mauro

  parent reply	other threads:[~2013-11-03  0:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-02 21:05 [PATCH] tda18271-fe: Fix dvb-c standard selection CrazyCat
2013-11-02 21:21 ` Mauro Carvalho Chehab
     [not found]   ` <52756F4E.3030805@narod.ru>
2013-11-03  0:19     ` Mauro Carvalho Chehab [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-11-01 19:31 CrazyCat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131102221956.1e241d02@samsung.com \
    --to=m.chehab@samsung.com \
    --cc=crazycat69@narod.ru \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox