Re: [PATCH 06/12] dvb-core: export dvb_usercopy and new DVB device constants

[Mauro Carvalho Chehab <m.chehab@samsung.com>]

Em Sun, 3 Nov 2013 01:33:54 +0100
Maik Broemme <mbroemme@parallels.com> escreveu:

> Added EXPORT_SYMBOL(dvb_usercopy) to allow new ddbridge driver to
> use it. It is questionable if I should use it in this way or not.
> If not I will fix it.

I don't like the idea of doing that. This likely means that ddbridge
is needing to do something else. The better is to add core support for
that, if pertinent, instead of moving the code to ddbridge.

> 
> Added two new DVB device constants DVB_DEVICE_CI and DVB_DEVICE_MOD
> required by newer ddbridge driver. Again it is questionable to use
> them or modify ddbridge driver.

Why those new types are needed? How those are used?

It could be needed, but then you should document them at DocBook.

It is probably better to open a separate thread to discuss those API
changes in separate (DVB C2 properties and those two new types of
devices).

> 
> Signed-off-by: Maik Broemme <mbroemme@parallels.com>
> ---
>  drivers/media/dvb-core/dvbdev.c | 1 +
>  drivers/media/dvb-core/dvbdev.h | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c
> index 401ef64..e451e9e 100644
> --- a/drivers/media/dvb-core/dvbdev.c
> +++ b/drivers/media/dvb-core/dvbdev.c
> @@ -438,6 +438,7 @@ out:
>  	kfree(mbuf);
>  	return err;
>  }
> +EXPORT_SYMBOL(dvb_usercopy);
>  
>  static int dvb_uevent(struct device *dev, struct kobj_uevent_env *env)
>  {
> diff --git a/drivers/media/dvb-core/dvbdev.h b/drivers/media/dvb-core/dvbdev.h
> index 93a9470..016c46e 100644
> --- a/drivers/media/dvb-core/dvbdev.h
> +++ b/drivers/media/dvb-core/dvbdev.h
> @@ -47,6 +47,8 @@
>  #define DVB_DEVICE_CA         6
>  #define DVB_DEVICE_NET        7
>  #define DVB_DEVICE_OSD        8
> +#define DVB_DEVICE_CI         9
> +#define DVB_DEVICE_MOD       10
>  
>  #define DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr) \
>  	static short adapter_nr[] = \


-- 

Cheers,
Mauro