* [PATCH] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe() [not found] ` <5294255E.7040105@gmail.com> @ 2013-11-27 3:17 ` Chen Gang 2013-11-27 3:21 ` Joe Perches 0 siblings, 1 reply; 8+ messages in thread From: Chen Gang @ 2013-11-27 3:17 UTC (permalink / raw) To: hans.verkuil, m.chehab Cc: rkuo, linux-kernel@vger.kernel.org, Greg KH, linux-media, devel@driverdev.osuosl.org dev_*() assumes 'go' is already initialized, so need use pr_*() instead of before 'go' initialized. Related warning (with allmodconfig under hexagon): CC [M] drivers/staging/media/go7007/go7007-usb.o drivers/staging/media/go7007/go7007-usb.c: In function 'go7007_usb_probe': drivers/staging/media/go7007/go7007-usb.c:1060:2: warning: 'go' may be used uninitialized in this function [-Wuninitialized] Also remove useless code after 'return' statement. Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> --- drivers/staging/media/go7007/go7007-usb.c | 11 ++++------- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/staging/media/go7007/go7007-usb.c b/drivers/staging/media/go7007/go7007-usb.c index 58684da..30310e9 100644 --- a/drivers/staging/media/go7007/go7007-usb.c +++ b/drivers/staging/media/go7007/go7007-usb.c @@ -1057,7 +1057,7 @@ static int go7007_usb_probe(struct usb_interface *intf, char *name; int video_pipe, i, v_urb_len; - dev_dbg(go->dev, "probing new GO7007 USB board\n"); + pr_devel("probing new GO7007 USB board\n"); switch (id->driver_info) { case GO7007_BOARDID_MATRIX_II: @@ -1097,13 +1097,10 @@ static int go7007_usb_probe(struct usb_interface *intf, board = &board_px_tv402u; break; case GO7007_BOARDID_LIFEVIEW_LR192: - dev_err(go->dev, "The Lifeview TV Walker Ultra is not supported. Sorry!\n"); + pr_err("The Lifeview TV Walker Ultra is not supported. Sorry!\n"); return -ENODEV; - name = "Lifeview TV Walker Ultra"; - board = &board_lifeview_lr192; - break; case GO7007_BOARDID_SENSORAY_2250: - dev_info(go->dev, "Sensoray 2250 found\n"); + pr_info("Sensoray 2250 found\n"); name = "Sensoray 2250/2251"; board = &board_sensoray_2250; break; @@ -1112,7 +1109,7 @@ static int go7007_usb_probe(struct usb_interface *intf, board = &board_ads_usbav_709; break; default: - dev_err(go->dev, "unknown board ID %d!\n", + pr_err("unknown board ID %d!\n", (unsigned int)id->driver_info); return -ENODEV; } -- 1.7.7.6 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe() 2013-11-27 3:17 ` [PATCH] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe() Chen Gang @ 2013-11-27 3:21 ` Joe Perches 2013-11-27 3:40 ` Chen Gang 0 siblings, 1 reply; 8+ messages in thread From: Joe Perches @ 2013-11-27 3:21 UTC (permalink / raw) To: Chen Gang Cc: hans.verkuil, m.chehab, rkuo, linux-kernel@vger.kernel.org, Greg KH, linux-media, devel@driverdev.osuosl.org On Wed, 2013-11-27 at 11:17 +0800, Chen Gang wrote: > dev_*() assumes 'go' is already initialized, so need use pr_*() instead > of before 'go' initialized. [] > diff --git a/drivers/staging/media/go7007/go7007-usb.c b/drivers/staging/media/go7007/go7007-usb.c [] > @@ -1057,7 +1057,7 @@ static int go7007_usb_probe(struct usb_interface *intf, > char *name; > int video_pipe, i, v_urb_len; > > - dev_dbg(go->dev, "probing new GO7007 USB board\n"); > + pr_devel("probing new GO7007 USB board\n"); pr_devel is commonly compiled out completely unless DEBUG is #defined. You probably want to use pr_debug here. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe() 2013-11-27 3:21 ` Joe Perches @ 2013-11-27 3:40 ` Chen Gang 2013-11-27 3:48 ` [PATCH v2] " Chen Gang 0 siblings, 1 reply; 8+ messages in thread From: Chen Gang @ 2013-11-27 3:40 UTC (permalink / raw) To: Joe Perches Cc: hans.verkuil, m.chehab, rkuo, linux-kernel@vger.kernel.org, Greg KH, linux-media, devel@driverdev.osuosl.org On 11/27/2013 11:21 AM, Joe Perches wrote: > On Wed, 2013-11-27 at 11:17 +0800, Chen Gang wrote: >> dev_*() assumes 'go' is already initialized, so need use pr_*() instead >> of before 'go' initialized. > [] >> diff --git a/drivers/staging/media/go7007/go7007-usb.c b/drivers/staging/media/go7007/go7007-usb.c > [] >> @@ -1057,7 +1057,7 @@ static int go7007_usb_probe(struct usb_interface *intf, >> char *name; >> int video_pipe, i, v_urb_len; >> >> - dev_dbg(go->dev, "probing new GO7007 USB board\n"); >> + pr_devel("probing new GO7007 USB board\n"); > > pr_devel is commonly compiled out completely unless DEBUG is #defined. > You probably want to use pr_debug here. > > Oh, yes, it is my fault, I will send patch v2. :-) Thanks. -- Chen Gang ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe() 2013-11-27 3:40 ` Chen Gang @ 2013-11-27 3:48 ` Chen Gang 2013-11-27 4:03 ` Greg KH 0 siblings, 1 reply; 8+ messages in thread From: Chen Gang @ 2013-11-27 3:48 UTC (permalink / raw) To: Joe Perches Cc: hans.verkuil, m.chehab, rkuo, linux-kernel@vger.kernel.org, Greg KH, linux-media, devel@driverdev.osuosl.org dev_*() assumes 'go' is already initialized, so need use pr_*() instead of before 'go' initialized. Related warning (with allmodconfig under hexagon): CC [M] drivers/staging/media/go7007/go7007-usb.o drivers/staging/media/go7007/go7007-usb.c: In function 'go7007_usb_probe': drivers/staging/media/go7007/go7007-usb.c:1060:2: warning: 'go' may be used uninitialized in this function [-Wuninitialized] Also remove useless code after 'return' statement. Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> --- drivers/staging/media/go7007/go7007-usb.c | 11 ++++------- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/staging/media/go7007/go7007-usb.c b/drivers/staging/media/go7007/go7007-usb.c index 58684da..2423643 100644 --- a/drivers/staging/media/go7007/go7007-usb.c +++ b/drivers/staging/media/go7007/go7007-usb.c @@ -1057,7 +1057,7 @@ static int go7007_usb_probe(struct usb_interface *intf, char *name; int video_pipe, i, v_urb_len; - dev_dbg(go->dev, "probing new GO7007 USB board\n"); + pr_debug("probing new GO7007 USB board\n"); switch (id->driver_info) { case GO7007_BOARDID_MATRIX_II: @@ -1097,13 +1097,10 @@ static int go7007_usb_probe(struct usb_interface *intf, board = &board_px_tv402u; break; case GO7007_BOARDID_LIFEVIEW_LR192: - dev_err(go->dev, "The Lifeview TV Walker Ultra is not supported. Sorry!\n"); + pr_err("The Lifeview TV Walker Ultra is not supported. Sorry!\n"); return -ENODEV; - name = "Lifeview TV Walker Ultra"; - board = &board_lifeview_lr192; - break; case GO7007_BOARDID_SENSORAY_2250: - dev_info(go->dev, "Sensoray 2250 found\n"); + pr_info("Sensoray 2250 found\n"); name = "Sensoray 2250/2251"; board = &board_sensoray_2250; break; @@ -1112,7 +1109,7 @@ static int go7007_usb_probe(struct usb_interface *intf, board = &board_ads_usbav_709; break; default: - dev_err(go->dev, "unknown board ID %d!\n", + pr_err("unknown board ID %d!\n", (unsigned int)id->driver_info); return -ENODEV; } -- 1.7.7.6 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe() 2013-11-27 3:48 ` [PATCH v2] " Chen Gang @ 2013-11-27 4:03 ` Greg KH 2013-11-27 4:24 ` Chen Gang 0 siblings, 1 reply; 8+ messages in thread From: Greg KH @ 2013-11-27 4:03 UTC (permalink / raw) To: Chen Gang Cc: Joe Perches, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, rkuo, hans.verkuil, m.chehab, linux-media On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote: > dev_*() assumes 'go' is already initialized, so need use pr_*() instead > of before 'go' initialized. Related warning (with allmodconfig under > hexagon): > > CC [M] drivers/staging/media/go7007/go7007-usb.o > drivers/staging/media/go7007/go7007-usb.c: In function 'go7007_usb_probe': > drivers/staging/media/go7007/go7007-usb.c:1060:2: warning: 'go' may be used uninitialized in this function [-Wuninitialized] > > Also remove useless code after 'return' statement. This should all be fixed in my staging-linus branch already, right? No need for this anymore from what I can tell, sorry. greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe() 2013-11-27 4:03 ` Greg KH @ 2013-11-27 4:24 ` Chen Gang 2013-11-27 10:43 ` Dan Carpenter 0 siblings, 1 reply; 8+ messages in thread From: Chen Gang @ 2013-11-27 4:24 UTC (permalink / raw) To: Greg KH Cc: Joe Perches, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, rkuo, hans.verkuil, m.chehab, linux-media On 11/27/2013 12:03 PM, Greg KH wrote: > On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote: >> dev_*() assumes 'go' is already initialized, so need use pr_*() instead >> of before 'go' initialized. Related warning (with allmodconfig under >> hexagon): >> >> CC [M] drivers/staging/media/go7007/go7007-usb.o >> drivers/staging/media/go7007/go7007-usb.c: In function 'go7007_usb_probe': >> drivers/staging/media/go7007/go7007-usb.c:1060:2: warning: 'go' may be used uninitialized in this function [-Wuninitialized] >> >> Also remove useless code after 'return' statement. > > This should all be fixed in my staging-linus branch already, right? No > need for this anymore from what I can tell, sorry. > That's all right (in fact don't need sorry). :-) And excuse me, I am not quite familiar upstream kernel version merging and branches. Is it still better/suitable/possible to sync some bug fix patches from staging brach to next brach? Thanks. -- Chen Gang ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe() 2013-11-27 4:24 ` Chen Gang @ 2013-11-27 10:43 ` Dan Carpenter 2013-11-28 1:47 ` Chen Gang 0 siblings, 1 reply; 8+ messages in thread From: Dan Carpenter @ 2013-11-27 10:43 UTC (permalink / raw) To: Chen Gang Cc: Greg KH, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, rkuo, hans.verkuil, Joe Perches, linux-media, m.chehab On Wed, Nov 27, 2013 at 12:24:22PM +0800, Chen Gang wrote: > On 11/27/2013 12:03 PM, Greg KH wrote: > > On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote: > >> dev_*() assumes 'go' is already initialized, so need use pr_*() instead > >> of before 'go' initialized. Related warning (with allmodconfig under > >> hexagon): > >> > >> CC [M] drivers/staging/media/go7007/go7007-usb.o > >> drivers/staging/media/go7007/go7007-usb.c: In function 'go7007_usb_probe': > >> drivers/staging/media/go7007/go7007-usb.c:1060:2: warning: 'go' may be used uninitialized in this function [-Wuninitialized] > >> > >> Also remove useless code after 'return' statement. > > > > This should all be fixed in my staging-linus branch already, right? No > > need for this anymore from what I can tell, sorry. > > > > That's all right (in fact don't need sorry). :-) > > And excuse me, I am not quite familiar upstream kernel version merging > and branches. Is it still better/suitable/possible to sync some bug fix > patches from staging brach to next brach? next syncs with everyone once a day. regards, dan carpenter ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe() 2013-11-27 10:43 ` Dan Carpenter @ 2013-11-28 1:47 ` Chen Gang 0 siblings, 0 replies; 8+ messages in thread From: Chen Gang @ 2013-11-28 1:47 UTC (permalink / raw) To: Dan Carpenter Cc: Greg KH, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, rkuo, hans.verkuil, Joe Perches, linux-media, m.chehab On 11/27/2013 06:43 PM, Dan Carpenter wrote: > On Wed, Nov 27, 2013 at 12:24:22PM +0800, Chen Gang wrote: >> On 11/27/2013 12:03 PM, Greg KH wrote: >>> On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote: >>>> dev_*() assumes 'go' is already initialized, so need use pr_*() instead >>>> of before 'go' initialized. Related warning (with allmodconfig under >>>> hexagon): >>>> >>>> CC [M] drivers/staging/media/go7007/go7007-usb.o >>>> drivers/staging/media/go7007/go7007-usb.c: In function 'go7007_usb_probe': >>>> drivers/staging/media/go7007/go7007-usb.c:1060:2: warning: 'go' may be used uninitialized in this function [-Wuninitialized] >>>> >>>> Also remove useless code after 'return' statement. >>> >>> This should all be fixed in my staging-linus branch already, right? No >>> need for this anymore from what I can tell, sorry. >>> >> >> That's all right (in fact don't need sorry). :-) >> >> And excuse me, I am not quite familiar upstream kernel version merging >> and branches. Is it still better/suitable/possible to sync some bug fix >> patches from staging brach to next brach? > > next syncs with everyone once a day. > OK, thanks. :-) -- Chen Gang ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-11-28 1:46 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <528AEFB7.4060301@gmail.com>
[not found] ` <20131125011938.GB18921@codeaurora.org>
[not found] ` <5292B845.3010404@gmail.com>
[not found] ` <5292B8A0.7020409@gmail.com>
[not found] ` <5294255E.7040105@gmail.com>
2013-11-27 3:17 ` [PATCH] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe() Chen Gang
2013-11-27 3:21 ` Joe Perches
2013-11-27 3:40 ` Chen Gang
2013-11-27 3:48 ` [PATCH v2] " Chen Gang
2013-11-27 4:03 ` Greg KH
2013-11-27 4:24 ` Chen Gang
2013-11-27 10:43 ` Dan Carpenter
2013-11-28 1:47 ` Chen Gang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox