From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
rkuo <rkuo@codeaurora.org>,
hans.verkuil@cisco.com, Joe Perches <joe@perches.com>,
linux-media@vger.kernel.org, m.chehab@samsung.com
Subject: Re: [PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()
Date: Wed, 27 Nov 2013 13:43:25 +0300 [thread overview]
Message-ID: <20131127104325.GE28413@mwanda> (raw)
In-Reply-To: <529573F6.9080106@gmail.com>
On Wed, Nov 27, 2013 at 12:24:22PM +0800, Chen Gang wrote:
> On 11/27/2013 12:03 PM, Greg KH wrote:
> > On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote:
> >> dev_*() assumes 'go' is already initialized, so need use pr_*() instead
> >> of before 'go' initialized. Related warning (with allmodconfig under
> >> hexagon):
> >>
> >> CC [M] drivers/staging/media/go7007/go7007-usb.o
> >> drivers/staging/media/go7007/go7007-usb.c: In function 'go7007_usb_probe':
> >> drivers/staging/media/go7007/go7007-usb.c:1060:2: warning: 'go' may be used uninitialized in this function [-Wuninitialized]
> >>
> >> Also remove useless code after 'return' statement.
> >
> > This should all be fixed in my staging-linus branch already, right? No
> > need for this anymore from what I can tell, sorry.
> >
>
> That's all right (in fact don't need sorry). :-)
>
> And excuse me, I am not quite familiar upstream kernel version merging
> and branches. Is it still better/suitable/possible to sync some bug fix
> patches from staging brach to next brach?
next syncs with everyone once a day.
regards,
dan carpenter
next prev parent reply other threads:[~2013-11-27 10:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <528AEFB7.4060301@gmail.com>
[not found] ` <20131125011938.GB18921@codeaurora.org>
[not found] ` <5292B845.3010404@gmail.com>
[not found] ` <5292B8A0.7020409@gmail.com>
[not found] ` <5294255E.7040105@gmail.com>
2013-11-27 3:17 ` [PATCH] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe() Chen Gang
2013-11-27 3:21 ` Joe Perches
2013-11-27 3:40 ` Chen Gang
2013-11-27 3:48 ` [PATCH v2] " Chen Gang
2013-11-27 4:03 ` Greg KH
2013-11-27 4:24 ` Chen Gang
2013-11-27 10:43 ` Dan Carpenter [this message]
2013-11-28 1:47 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131127104325.GE28413@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gang.chen.5i5j@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=rkuo@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox