Re: libdvbv5: dvb_table_pat_init is leaking memory

[Mauro Carvalho Chehab <mchehab@infradead.org>]

Hi Gregor,

Em Wed, 27 Nov 2013 22:55:32 +0100
Gregor Jasny <gjasny@googlemail.com> escreveu:

> Hello,
> 
> Coverity noticed that dvb_table_pat_init leaks the reallocated memory
> stored in pat:
> http://git.linuxtv.org/v4l-utils.git/blob/HEAD:/lib/libdvbv5/descriptors/pat.c#l26
> 
> Mauro, could you please check?

On my tests with Valgrind, I'm not noticing any memory leak there, at
least on the very latest version I pushed today[1].

I tested here with DVB-T, DVB-T2, DVB-S, DVB-S2 and DVB-C.

I didn't test the current version yet with ATSC or ISDB-T. Those are
on my todo list. I'll likely do ATSC test today or tomorrow.

ISDB-T test might take some time, as I'm having some troubles to test it
here those days.

That's said, I would love to get rid of that realloc() on PAT, but this
would break the existing userspace interface. So, such change, if done,
would require some care, as at least tvdaemon relies on it.

Regards,
Mauro

[1] Not sure if you noticed, but I added ~80 patches for it today.