Re: libdvbv5: dvb_table_pat_init is leaking memory

[Mauro Carvalho Chehab <m.chehab@samsung.com>]

Hi Gregor,

Em Wed, 27 Nov 2013 20:46:42 -0200
Mauro Carvalho Chehab <m.chehab@samsung.com> escreveu:

> Em Wed, 27 Nov 2013 20:31:21 -0200
> Mauro Carvalho Chehab <mchehab@infradead.org> escreveu:
> 
> > Hi Gregor,
> > 
> > Em Wed, 27 Nov 2013 22:55:32 +0100
> > Gregor Jasny <gjasny@googlemail.com> escreveu:
> > 
> > > Hello,
> > > 
> > > Coverity noticed that dvb_table_pat_init leaks the reallocated memory
> > > stored in pat:
> > > http://git.linuxtv.org/v4l-utils.git/blob/HEAD:/lib/libdvbv5/descriptors/pat.c#l26
> > > 
> > > Mauro, could you please check?
> > 
> > On my tests with Valgrind, I'm not noticing any memory leak there, at
> > least on the very latest version I pushed today[1].

After a good resting night, I reviewed it, and it turns that memory leaks
can occur.

So, I re-worked the logic. I also fixed the other bugs pointed by Coverity
today. Could you please re-run the Coverity tests, to see if everything is
OK with the current version?

Thanks!
Mauro