From: "Pali Rohár" <pali.rohar@gmail.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: "Mauro Carvalho Chehab" <m.chehab@samsung.com>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
"Eero Nurkkala" <ext-eero.nurkkala@nokia.com>,
"Nils Faerber" <nils.faerber@kernelconcepts.de>,
"Joni Lapilainen" <joni.lapilainen@gmail.com>,
"Ивайло Димитров" <freemangordon@abv.bg>,
"Pavel Machek" <pavel@ucw.cz>,
sre@ring0.de, aaro.koskinen@iki.fi
Subject: Re: [PATCH] media: Add BCM2048 radio driver
Date: Thu, 5 Dec 2013 14:20:56 +0100 [thread overview]
Message-ID: <201312051420.56852@pali> (raw)
In-Reply-To: <52A030BE.7040709@xs4all.nl>
[-- Attachment #1: Type: Text/Plain, Size: 1774 bytes --]
On Thursday 05 December 2013 08:52:30 Hans Verkuil wrote:
> On 12/02/2013 09:51 PM, Pali Rohár wrote:
> > On Monday 04 November 2013 12:39:44 Hans Verkuil wrote:
> >> Hi Pali,
> >>
> >> On 10/26/2013 10:45 PM, Pali Rohár wrote:
> >>> On Saturday 26 October 2013 22:22:09 Hans Verkuil wrote:
> >>>>> Hans, so can it be added to drivers/staging/media tree?
> >>>>
> >>>> Yes, that is an option. It's up to you to decide what you
> >>>> want. Note that if no cleanup work is done on the staging
> >>>> driver for a long time, then it can be removed again.
> >>>>
> >>>> Regards,
> >>>>
> >>>> Hans
> >>>
> >>> Ok, so if you can add it to staging tree. When driver will
> >>> be in mainline other developers can look at it too. Now
> >>> when driver is hidden, nobody know where to find it... You
> >>> can see how upstream development for Nokia N900 HW going
> >>> on: http://elinux.org/N900
> >>
> >> Please check my tree:
> >>
> >> http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/ref
> >> s/h eads/bcm
> >>
> >> If you're OK, then I'll queue it for 3.14 (it's too late
> >> for 3.13).
> >>
> >> Regards,
> >>
> >> Hans
> >
> > Hi, sorry for late reply. I looked into your tree and
> > difference is that you only removed "linux/slab.h" include.
> > So it it is not needed, then it is OK.
>
> I *added* slab.h :-)
>
Right, I looked at reverse diff :-)
> Anyway, I've posted the pull request. Please note, if you want
> to avoid having this driver be removed again in the future,
> then you (or someone else) should work on addressing the
> issues in the TODO file I added.
>
> Regards,
>
> Hans
Ok. CCing other people who works with n900 kernel.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-12-05 13:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 14:26 [PATCH] media: Add BCM2048 radio driver Pali Rohár
2013-10-15 15:08 ` Hans Verkuil
2013-10-17 19:31 ` Pali Rohár
2013-10-26 20:04 ` Pali Rohár
2013-10-26 20:22 ` Hans Verkuil
2013-10-26 20:45 ` Pali Rohár
2013-11-04 11:39 ` Hans Verkuil
2013-12-02 20:51 ` Pali Rohár
2013-12-05 7:52 ` Hans Verkuil
2013-12-05 13:20 ` Pali Rohár [this message]
2013-12-05 13:57 ` Sebastian Reichel
2013-12-05 14:03 ` Nils Faerber
2013-12-05 20:03 ` ext-eero.1.nurkkala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312051420.56852@pali \
--to=pali.rohar@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=ext-eero.nurkkala@nokia.com \
--cc=freemangordon@abv.bg \
--cc=hverkuil@xs4all.nl \
--cc=joni.lapilainen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=nils.faerber@kernelconcepts.de \
--cc=pavel@ucw.cz \
--cc=sre@ring0.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).