From: Lisa Nguyen <lisa@xenapiadmin.com>
To: prabhakar.csengg@gmail.com
Cc: davinci-linux-open-source@linux.davincidsp.com,
linux-media@vger.kernel.org, m.chehab@samsung.com,
laurent.pinchart@ideasonboard.com
Subject: [PATCH v2] staging: media: davinci_vpfe: Rewrite return statement in vpfe_video.c
Date: Tue, 10 Dec 2013 08:05:42 -0800 [thread overview]
Message-ID: <20131210160541.GA15282@ubuntu> (raw)
Rewrite the return statement in vpfe_video.c to eliminate the
use of a ternary operator. This will prevent the checkpatch.pl
script from generating a warning saying to remove () from
this particular return statement.
Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
---
Changes since v2:
- Aligned -ETIMEDOUT return statement with if condition
drivers/staging/media/davinci_vpfe/vpfe_video.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c b/drivers/staging/media/davinci_vpfe/vpfe_video.c
index 24d98a6..22e31d2 100644
--- a/drivers/staging/media/davinci_vpfe/vpfe_video.c
+++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c
@@ -346,7 +346,10 @@ static int vpfe_pipeline_disable(struct vpfe_pipeline *pipe)
}
mutex_unlock(&mdev->graph_mutex);
- return (ret == 0) ? ret : -ETIMEDOUT ;
+ if (ret == 0)
+ return ret;
+
+ return -ETIMEDOUT;
}
/*
--
1.7.9.5
next reply other threads:[~2013-12-10 16:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 16:05 Lisa Nguyen [this message]
2013-12-10 16:50 ` [PATCH v2] staging: media: davinci_vpfe: Rewrite return statement in vpfe_video.c Laurent Pinchart
2013-12-10 17:57 ` Lisa Nguyen
2013-12-11 3:04 ` Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210160541.GA15282@ubuntu \
--to=lisa@xenapiadmin.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox