* [patch] [media] v4l: omap4iss: use snprintf() to make smatch happy
@ 2013-12-16 20:19 Dan Carpenter
2013-12-17 17:27 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-12-16 20:19 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Greg Kroah-Hartman, Laurent Pinchart, Andrzej Hajda, Sakari Ailus,
Sylwester Nawrocki, Sergio Aguirre, linux-media, devel,
kernel-janitors
Smatch complains here because name is a 32 character buffer and we
adding the "OMAP4 ISS " prefix as well for a total of 42 characters.
The sd->name buffer can only hold 32 characters. I've changed it to use
snprintf() to silence the overflow warning.
Also I have removed the call to strlcpy() which is a no-op.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/media/omap4iss/iss_csi2.c b/drivers/staging/media/omap4iss/iss_csi2.c
index 0ee8381c738d..7ab05126be5d 100644
--- a/drivers/staging/media/omap4iss/iss_csi2.c
+++ b/drivers/staging/media/omap4iss/iss_csi2.c
@@ -1273,8 +1273,7 @@ static int csi2_init_entities(struct iss_csi2_device *csi2, const char *subname)
v4l2_subdev_init(sd, &csi2_ops);
sd->internal_ops = &csi2_internal_ops;
sprintf(name, "CSI2%s", subname);
- strlcpy(sd->name, "", sizeof(sd->name));
- sprintf(sd->name, "OMAP4 ISS %s", name);
+ snprintf(sd->name, sizeof(sd->name), "OMAP4 ISS %s", name);
sd->grp_id = 1 << 16; /* group ID for iss subdevs */
v4l2_set_subdevdata(sd, csi2);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] [media] v4l: omap4iss: use snprintf() to make smatch happy
2013-12-16 20:19 [patch] [media] v4l: omap4iss: use snprintf() to make smatch happy Dan Carpenter
@ 2013-12-17 17:27 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2013-12-17 17:27 UTC (permalink / raw)
To: Dan Carpenter
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, Andrzej Hajda,
Sakari Ailus, Sylwester Nawrocki, Sergio Aguirre, linux-media,
devel, kernel-janitors
Hi Dan,
Thank you for the patch.
On Monday 16 December 2013 23:19:50 Dan Carpenter wrote:
> Smatch complains here because name is a 32 character buffer and we
> adding the "OMAP4 ISS " prefix as well for a total of 42 characters.
> The sd->name buffer can only hold 32 characters. I've changed it to use
> snprintf() to silence the overflow warning.
>
> Also I have removed the call to strlcpy() which is a no-op.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree.
> diff --git a/drivers/staging/media/omap4iss/iss_csi2.c
> b/drivers/staging/media/omap4iss/iss_csi2.c index
> 0ee8381c738d..7ab05126be5d 100644
> --- a/drivers/staging/media/omap4iss/iss_csi2.c
> +++ b/drivers/staging/media/omap4iss/iss_csi2.c
> @@ -1273,8 +1273,7 @@ static int csi2_init_entities(struct iss_csi2_device
> *csi2, const char *subname) v4l2_subdev_init(sd, &csi2_ops);
> sd->internal_ops = &csi2_internal_ops;
> sprintf(name, "CSI2%s", subname);
> - strlcpy(sd->name, "", sizeof(sd->name));
> - sprintf(sd->name, "OMAP4 ISS %s", name);
> + snprintf(sd->name, sizeof(sd->name), "OMAP4 ISS %s", name);
>
> sd->grp_id = 1 << 16; /* group ID for iss subdevs */
> v4l2_set_subdevdata(sd, csi2);
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-17 17:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-16 20:19 [patch] [media] v4l: omap4iss: use snprintf() to make smatch happy Dan Carpenter
2013-12-17 17:27 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox