From: Mauro Carvalho Chehab <m.chehab@samsung.com>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: linux-media@vger.kernel.org, sw0312.kim@samsung.com,
andrzej.p@samsung.com, s.nawrocki@samsung.com,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH v2 09/16] s5p-jpeg: Split jpeg-hw.h to jpeg-hw-s5p.c and jpeg-hw-s5p.c
Date: Wed, 18 Dec 2013 09:21:58 -0200 [thread overview]
Message-ID: <20131218092158.4102dc89@samsung.com> (raw)
In-Reply-To: <1385373503-1657-10-git-send-email-j.anaszewski@samsung.com>
Em Mon, 25 Nov 2013 10:58:16 +0100
Jacek Anaszewski <j.anaszewski@samsung.com> escreveu:
> Move function definitions from jpeg-hw.h to jpeg-hw-s5p.c
> and put function declarations in the jpeg-hw-s5p.h.
>
> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
...
> +void jpeg_reset(void __iomem *regs);
> +void jpeg_poweron(void __iomem *regs);
> +void jpeg_input_raw_mode(void __iomem *regs, unsigned long mode);
> +void jpeg_input_raw_y16(void __iomem *regs, bool y16);
> +void jpeg_proc_mode(void __iomem *regs, unsigned long mode);
> +void jpeg_subsampling_mode(void __iomem *regs, unsigned int mode);
> +unsigned int jpeg_get_subsampling_mode(void __iomem *regs);
> +void jpeg_dri(void __iomem *regs, unsigned int dri);
> +void jpeg_qtbl(void __iomem *regs, unsigned int t, unsigned int n);
> +void jpeg_htbl_ac(void __iomem *regs, unsigned int t);
> +void jpeg_htbl_dc(void __iomem *regs, unsigned int t);
> +void jpeg_y(void __iomem *regs, unsigned int y);
> +void jpeg_x(void __iomem *regs, unsigned int x);
> +void jpeg_rst_int_enable(void __iomem *regs, bool enable);
> +void jpeg_data_num_int_enable(void __iomem *regs, bool enable);
> +void jpeg_final_mcu_num_int_enable(void __iomem *regs, bool enbl);
> +void jpeg_timer_enable(void __iomem *regs, unsigned long val);
> +void jpeg_timer_disable(void __iomem *regs);
> +int jpeg_timer_stat(void __iomem *regs);
> +void jpeg_clear_timer_stat(void __iomem *regs);
> +void jpeg_enc_stream_int(void __iomem *regs, unsigned long size);
> +int jpeg_enc_stream_stat(void __iomem *regs);
> +void jpeg_clear_enc_stream_stat(void __iomem *regs);
> +void jpeg_outform_raw(void __iomem *regs, unsigned long format);
> +void jpeg_jpgadr(void __iomem *regs, unsigned long addr);
> +void jpeg_imgadr(void __iomem *regs, unsigned long addr);
> +void jpeg_coef(void __iomem *regs, unsigned int i,
> + unsigned int j, unsigned int coef);
> +void jpeg_start(void __iomem *regs);
> +int jpeg_result_stat_ok(void __iomem *regs);
> +int jpeg_stream_stat_ok(void __iomem *regs);
> +void jpeg_clear_int(void __iomem *regs);
> +unsigned int jpeg_compressed_size(void __iomem *regs);
NACK. Please don't pollute Kernel name space.
Those functions are specific to s5p. They should all be prepended by s5p_,
or otherwise it will risk to cause conflicts with other global symbols
that could have the same name, for kernels compiled will allyesconfig.
Regards,
--
Cheers,
Mauro
next prev parent reply other threads:[~2013-12-18 11:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 9:58 [PATCH v2 00/16] Add support for Exynox4x12 to the s5p-jpeg driver Jacek Anaszewski
2013-11-25 9:58 ` [PATCH v2 01/16] s5p-jpeg: Reorder quantization tables Jacek Anaszewski
2013-11-25 9:58 ` [PATCH v2 02/16] s5p-jpeg: Fix output YUV 4:2:0 fourcc for decoder Jacek Anaszewski
2013-11-25 9:58 ` [PATCH v2 03/16] s5p-jpeg: Fix erroneous condition while validating bytesperline value Jacek Anaszewski
2013-11-25 9:58 ` [PATCH v2 04/16] s5p-jpeg: Remove superfluous call to the jpeg_bound_align_image function Jacek Anaszewski
2013-11-25 9:58 ` [PATCH v2 05/16] s5p-jpeg: Rename functions specific to the S5PC210 SoC accordingly Jacek Anaszewski
2013-11-25 9:58 ` [PATCH v2 06/16] s5p-jpeg: Fix clock resource management Jacek Anaszewski
2013-11-25 9:58 ` [PATCH v2 07/16] s5p-jpeg: Fix lack of spin_lock protection Jacek Anaszewski
2013-11-25 9:58 ` [PATCH v2 08/16] s5p-jpeg: Synchronize cached controls with V4L2 core Jacek Anaszewski
2013-11-25 9:58 ` [PATCH v2 09/16] s5p-jpeg: Split jpeg-hw.h to jpeg-hw-s5p.c and jpeg-hw-s5p.c Jacek Anaszewski
2013-12-18 11:21 ` Mauro Carvalho Chehab [this message]
2013-11-25 9:58 ` [PATCH v2 10/16] s5p-jpeg: Add hardware API for the exynos4x12 JPEG codec Jacek Anaszewski
2013-11-25 9:58 ` [PATCH v2 11/16] s5p-jpeg: Retrieve "YCbCr subsampling" field from the jpeg header Jacek Anaszewski
2013-11-25 9:58 ` [PATCH v2 12/16] s5p-jpeg: Ensure correct capture format for Exynos4x12 Jacek Anaszewski
2013-11-25 9:58 ` [PATCH v2 13/16] s5p-jpeg: Allow for wider JPEG subsampling scope for Exynos4x12 encoder Jacek Anaszewski
2013-11-25 9:58 ` [PATCH v2 14/16] s5p-jpeg: Synchronize V4L2_CID_JPEG_CHROMA_SUBSAMPLING control value Jacek Anaszewski
2013-11-25 9:58 ` [PATCH v2 15/16] s5p-jpeg: Ensure setting correct value of the chroma subsampling control Jacek Anaszewski
2013-11-25 9:58 ` [PATCH v2 16/16] s5p-jpeg: Adjust g_volatile_ctrl callback to Exynos4x12 needs Jacek Anaszewski
2013-11-29 8:58 ` [PATCH v2 00/16] Add support for Exynox4x12 to the s5p-jpeg driver Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131218092158.4102dc89@samsung.com \
--to=m.chehab@samsung.com \
--cc=andrzej.p@samsung.com \
--cc=j.anaszewski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox