Re: [linuxtv-media:master 483/499] m88ds3103.c:undefined reference to `i2c_del_mux_adapter'

[Mauro Carvalho Chehab <m.chehab@samsung.com>]

Em Sat, 21 Dec 2013 08:50:48 -0200
Mauro Carvalho Chehab <m.chehab@samsung.com> escreveu:

> From: Mauro Carvalho Chehab <m.chehab@samsung.com>
> Date: Sat, 21 Dec 2013 05:42:11 -0200
> Subject: [PATCH] [media] subdev autoselect only works if I2C and I2C_MUX is selected
> 
> As reported by the kbuild test robot <fengguang.wu@intel.com>:
> 
> > warning: (VIDEO_EM28XX_DVB) selects DVB_M88DS3103 which has unmet direct dependencies (MEDIA_SUPPORT && DVB_CORE && I2C && I2C_MUX)
> >    drivers/built-in.o: In function `m88ds3103_release':  
> > >> m88ds3103.c:(.text+0x1ab1af): undefined reference to `i2c_del_mux_adapter'  
> >    drivers/built-in.o: In function `m88ds3103_attach':  
> > >> (.text+0x1ab342): undefined reference to `i2c_add_mux_adapter'  
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

It is the Christmas week. I don't think we'll have enough reviews for this,
as most are preparing themselves to properly celebrate the birth of our
Lord, or to just rest during Seasons.

Due to that, I'll likely just apply this patch with a better description,
as I intend to merge the pending patches at -next during this weekend,
and I don't want to spread compilation breakages there.

If we latter agree with some other solution, reverting this one while 
applying other changes should be trivial.

Happy Seasons!
Mauro

> 
> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> index 8270388e2a0d..1d0758aeb8e4 100644
> --- a/drivers/media/Kconfig
> +++ b/drivers/media/Kconfig
> @@ -172,6 +172,9 @@ comment "Media ancillary drivers (tuners, sensors, i2c, frontends)"
>  config MEDIA_SUBDRV_AUTOSELECT
>  	bool "Autoselect ancillary drivers (tuners, sensors, i2c, frontends)"
>  	depends on MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT || MEDIA_CAMERA_SUPPORT
> +	depends on HAS_IOMEM
> +	select I2C
> +	select I2C_MUX
>  	default y
>  	help
>  	  By default, a media driver auto-selects all possible ancillary
> --