From: Mauro Carvalho Chehab <m.chehab@samsung.com>
To: Devin Heitmueller <dheitmueller@kernellabs.com>
Cc: Tim Mester <ttmesterr@gmail.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Tim Mester <tmester@ieee.org>
Subject: Re: [PATCH 3/3] au8522, au0828: Added demodulator reset
Date: Tue, 07 Jan 2014 12:58:30 -0200 [thread overview]
Message-ID: <20140107125830.4525c52c@samsung.com> (raw)
In-Reply-To: <CAGoCfizhR=QJaonNzesLSVRZ+rEZCaY+QLVi7ksF1wx4N=Sm7Q@mail.gmail.com>
Hi Devin,
Em Mon, 06 Jan 2014 23:53:15 -0500
Devin Heitmueller <dheitmueller@kernellabs.com> escreveu:
> What is the actual "corruption" that you are seeing? Can you describe
> it in greater detail? The original fix was specifically related to
> the internal FIFO on the au0828 where it can get shifted by one or
> more bits (i.e. the leading byte is no longer 0x47 but 0x47 << X).
> Hence it's an issue unrelated to the actual au8522.
>
> I suspect this is actually a different problem which out of dumb luck
> gets "fixed" by resetting the chip. Without more details on the
> specific behavior you are seeing though I cannot really advise on what
> the correct change is.
>
> This patch should not be accepted upstream without more discussion.
Patches 1 and 2 are ok? If so, could you please reply to them with your
ack?
> http://git.kernellabs.com/?p=dheitmueller/linuxtv.git;a=shortlog;h=refs/heads/950q_improv
>
> I'm not against the hack you've proposed if it's really warranted, but
> a reset is really a last resort and I'm very concerned it's masking
> over the real problem.
Are you planning to submit the above patches upstream soon?
--
Cheers,
Mauro
next prev parent reply other threads:[~2014-01-07 14:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 4:29 [PATCH 1/3] au8028: Fix cleanup on kzalloc fail Tim Mester
2014-01-07 4:29 ` [PATCH 2/3] au0828: Add option to preallocate digital transfer buffers Tim Mester
2014-01-07 15:56 ` Devin Heitmueller
2014-01-07 4:29 ` [PATCH 3/3] au8522, au0828: Added demodulator reset Tim Mester
2014-01-07 4:45 ` Devin Heitmueller
2014-01-07 4:53 ` Devin Heitmueller
2014-01-07 14:58 ` Mauro Carvalho Chehab [this message]
2014-01-07 15:54 ` Devin Heitmueller
2014-01-08 5:12 ` Tim Mester
2014-01-08 20:26 ` Devin Heitmueller
2014-01-11 22:12 ` Tim Mester
2014-01-13 16:32 ` Devin Heitmueller
2014-01-08 5:03 ` Tim Mester
2014-01-07 15:55 ` [PATCH 1/3] au8028: Fix cleanup on kzalloc fail Devin Heitmueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140107125830.4525c52c@samsung.com \
--to=m.chehab@samsung.com \
--cc=dheitmueller@kernellabs.com \
--cc=linux-media@vger.kernel.org \
--cc=tmester@ieee.org \
--cc=ttmesterr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox