linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <m.chehab@samsung.com>
To: "André Roth" <neolynx@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 17/18] libdvbv5: remove header files from SOURCES in Makefile.am
Date: Tue, 07 Jan 2014 15:30:58 -0200	[thread overview]
Message-ID: <20140107153058.4e8de28b@samsung.com> (raw)
In-Reply-To: <1388407731-24369-17-git-send-email-neolynx@gmail.com>

Em Mon, 30 Dec 2013 13:48:50 +0100
André Roth <neolynx@gmail.com> escreveu:

description?

I'm not sure if this is ok. If you remove the headers, wouldn't it remove the
C source dependencies from the .h headers?

> Signed-off-by: André Roth <neolynx@gmail.com>
> ---
>  lib/libdvbv5/Makefile.am | 87 ++++++++++++++++++++++++------------------------
>  1 file changed, 43 insertions(+), 44 deletions(-)
> 
> diff --git a/lib/libdvbv5/Makefile.am b/lib/libdvbv5/Makefile.am
> index ddf9ea1..8f89531 100644
> --- a/lib/libdvbv5/Makefile.am
> +++ b/lib/libdvbv5/Makefile.am
> @@ -52,52 +52,51 @@ noinst_LTLIBRARIES = libdvbv5.la
>  endif
>  
>  libdvbv5_la_SOURCES = \
> -	crc32.c crc32.h \
> -	../include/dvb-frontend.h \
> +	crc32.c \
>  	dvb-legacy-channel-format.c \
>  	dvb-zap-format.c \
> -	dvb-v5.c	dvb-v5.h \
> -	parse_string.c	parse_string.h \
> -	dvb-demux.c	../include/dvb-demux.h \
> -	dvb-fe.c	../include/dvb-fe.h \
> -	dvb-log.c	../include/dvb-log.h \
> -	dvb-file.c	../include/dvb-file.h \
> -	dvb-v5-std.c	../include/dvb-v5-std.h \
> -	dvb-sat.c	../include/dvb-sat.h \
> -	dvb-scan.c	../include/dvb-scan.h \
> -	descriptors.c	../include/descriptors.h \
> -	descriptors/header.c		../include/libdvbv5/header.h \
> -	descriptors/atsc_header.c	../include/libdvbv5/atsc_header.h \
> -	descriptors/pat.c		../include/libdvbv5/pat.h \
> -	descriptors/pmt.c		../include/libdvbv5/pmt.h \
> -	descriptors/nit.c		../include/libdvbv5/nit.h \
> -	descriptors/sdt.c		../include/libdvbv5/sdt.h \
> -	descriptors/vct.c		../include/libdvbv5/vct.h \
> -	descriptors/mgt.c		../include/libdvbv5/mgt.h \
> -	descriptors/eit.c		../include/libdvbv5/eit.h \
> -	descriptors/atsc_eit.c		../include/libdvbv5/atsc_eit.h \
> -	descriptors/desc_language.c		../include/libdvbv5/desc_language.h \
> -	descriptors/desc_network_name.c		../include/libdvbv5/desc_network_name.h \
> -	descriptors/desc_cable_delivery.c	../include/libdvbv5/desc_cable_delivery.h \
> -	descriptors/desc_sat.c			../include/libdvbv5/desc_sat.h \
> -	descriptors/desc_terrestrial_delivery.c  ../include/libdvbv5/desc_terrestrial_delivery.h \
> -	descriptors/desc_t2_delivery.c		../include/libdvbv5/desc_t2_delivery.h \
> -	descriptors/desc_service.c		../include/libdvbv5/desc_service.h \
> -	descriptors/desc_frequency_list.c	../include/libdvbv5/desc_frequency_list.h \
> -	descriptors/desc_service_list.c		../include/libdvbv5/desc_service_list.h \
> -	descriptors/desc_event_short.c		../include/libdvbv5/desc_event_short.h \
> -	descriptors/desc_event_extended.c	../include/libdvbv5/desc_event_extended.h \
> -	descriptors/desc_atsc_service_location.c ../include/libdvbv5/desc_atsc_service_location.h \
> -	descriptors/desc_hierarchy.c		../include/libdvbv5/desc_hierarchy.h \
> -	descriptors/desc_extension.c		../include/libdvbv5/desc_extension.h \
> -	descriptors/desc_isdbt_delivery.c	../include/libdvbv5/desc_isdbt_delivery.h \
> -	descriptors/desc_logical_channel.c	../include/libdvbv5/desc_logical_channel.h \
> -	descriptors/desc_ts_info.c		../include/libdvbv5/desc_ts_info.h \
> -	descriptors/desc_partial_reception.c	../include/libdvbv5/desc_partial_reception.h \
> -	descriptors/desc_service_location.c	../include/libdvbv5/desc_service_location.h \
> -	descriptors/mpeg_ts.c		../include/libdvbv5/mpeg_ts.h \
> -	descriptors/mpeg_pes.c		../include/libdvbv5/mpeg_pes.h \
> -	descriptors/mpeg_es.c		../include/libdvbv5/mpeg_es.h
> +	dvb-v5.c	 \
> +	parse_string.c	 \
> +	dvb-demux.c	 \
> +	dvb-fe.c	 \
> +	dvb-log.c	\
> +	dvb-file.c	\
> +	dvb-v5-std.c	\
> +	dvb-sat.c	\
> +	dvb-scan.c	\
> +	descriptors.c	\
> +	descriptors/header.c		\
> +	descriptors/atsc_header.c	\
> +	descriptors/pat.c		\
> +	descriptors/pmt.c		\
> +	descriptors/nit.c		\
> +	descriptors/sdt.c		\
> +	descriptors/vct.c		\
> +	descriptors/mgt.c		\
> +	descriptors/eit.c		\
> +	descriptors/atsc_eit.c		\
> +	descriptors/desc_language.c		\
> +	descriptors/desc_network_name.c		\
> +	descriptors/desc_cable_delivery.c	\
> +	descriptors/desc_sat.c			\
> +	descriptors/desc_terrestrial_delivery.c  \
> +	descriptors/desc_t2_delivery.c		\
> +	descriptors/desc_service.c		\
> +	descriptors/desc_frequency_list.c	\
> +	descriptors/desc_service_list.c		\
> +	descriptors/desc_event_short.c		\
> +	descriptors/desc_event_extended.c	\
> +	descriptors/desc_atsc_service_location.c \
> +	descriptors/desc_hierarchy.c		\
> +	descriptors/desc_extension.c		\
> +	descriptors/desc_isdbt_delivery.c	\
> +	descriptors/desc_logical_channel.c	\
> +	descriptors/desc_ts_info.c		\
> +	descriptors/desc_partial_reception.c	\
> +	descriptors/desc_service_location.c	\
> +	descriptors/mpeg_ts.c		\
> +	descriptors/mpeg_pes.c		\
> +	descriptors/mpeg_es.c
>  
>  libdvbv5_la_CPPFLAGS = -I../.. $(ENFORCE_LIBDVBV5_STATIC)
>  libdvbv5_la_LDFLAGS = $(LIBDVBV5_VERSION) $(ENFORCE_LIBDVBV5_STATIC) -lm


-- 

Cheers,
Mauro

  reply	other threads:[~2014-01-07 17:31 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-30 12:48 [PATCH 01/18] libdvbv5: fix reading multisection tables André Roth
2013-12-30 12:48 ` [PATCH 02/18] libdvbv5: service location descriptor support André Roth
2014-01-07 16:38   ` Mauro Carvalho Chehab
2013-12-30 12:48 ` [PATCH 03/18] libdvbv5: VCT table cleanup André Roth
2013-12-30 12:48 ` [PATCH 04/18] libdvbv5: mpeg elementary stream parsers André Roth
2014-01-07 16:47   ` Mauro Carvalho Chehab
2013-12-30 12:48 ` [PATCH 05/18] libdvbv5: fix NIT structures André Roth
2013-12-30 12:48 ` [PATCH 06/18] libdvbv5: implement dvb_fe_dummy for logging André Roth
2013-12-30 12:48 ` [PATCH 07/18] libdvbv5: fix EIT parsing André Roth
2014-01-07 17:00   ` Mauro Carvalho Chehab
2013-12-30 12:48 ` [PATCH 08/18] libdvbv5: implement MGT parser André Roth
2014-01-07 17:05   ` Mauro Carvalho Chehab
2013-12-30 12:48 ` [PATCH 09/18] libdvbv5: implement ATSC EIT André Roth
2014-01-07 17:12   ` Mauro Carvalho Chehab
2014-01-08 11:09     ` André Roth
2013-12-30 12:48 ` [PATCH 10/18] libdvbv5: prefix VCT with atsc_ instead of dvb_ André Roth
2013-12-30 12:48 ` [PATCH 11/18] libdvbv5: cleanup coding style André Roth
2014-01-07 17:23   ` Mauro Carvalho Chehab
2013-12-30 12:48 ` [PATCH 12/18] libdvbv5: fix missing includes André Roth
2013-12-30 12:48 ` [PATCH 13/18] libdvbv5: improve TS parsing André Roth
2014-01-07 17:27   ` Mauro Carvalho Chehab
2013-12-30 12:48 ` [PATCH 14/18] libdvbv5: cleanup dvb_nit_transport_foreach macro André Roth
2013-12-30 12:48 ` [PATCH 15/18] libdvbv5: remove c99 comments André Roth
2014-01-07 17:29   ` Mauro Carvalho Chehab
2013-12-30 12:48 ` [PATCH 17/18] libdvbv5: remove header files from SOURCES in Makefile.am André Roth
2014-01-07 17:30   ` Mauro Carvalho Chehab [this message]
2013-12-30 12:48 ` [PATCH 18/18] libdvbv5: README updated for shared libdvbv5 André Roth
2014-01-07 18:12   ` Mauro Carvalho Chehab
2014-01-07 16:32 ` [PATCH 01/18] libdvbv5: fix reading multisection tables Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140107153058.4e8de28b@samsung.com \
    --to=m.chehab@samsung.com \
    --cc=linux-media@vger.kernel.org \
    --cc=neolynx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).