From: Mauro Carvalho Chehab <m.chehab@samsung.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: Hans de Goede <hdegoede@redhat.com>, Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, linux-usb@vger.kernel.org,
LMML <linux-media@vger.kernel.org>
Subject: Re: [alsa-devel] Fw: Isochronous transfer error on USB3
Date: Thu, 09 Jan 2014 09:31:55 -0200 [thread overview]
Message-ID: <20140109093155.35494ce2@samsung.com> (raw)
In-Reply-To: <20140109092957.58092c3f@samsung.com>
Em Thu, 9 Jan 2014 09:29:57 -0200
Mauro Carvalho Chehab <m.chehab@samsung.com> escreveu:
> Em Thu, 09 Jan 2014 09:17:13 +0100
> Clemens Ladisch <clemens@ladisch.de> escreveu:
>
> > Mauro Carvalho Chehab wrote:
> > > I'm getting an weird behavior with em28xx, especially when the device
> > > is connected into an audio port.
> > >
> > > http://git.linuxtv.org/mchehab/experimental.git/blob/refs/heads/em28xx-v4l2-v6:/drivers/media/usb/em28xx/em28xx-audio.c
> > >
> > > What happens is that, when I require xawtv3 to use any latency lower
> > > than 65 ms, the audio doesn't work, as it gets lots of underruns per
> > > second.
> >
> > The driver uses five URBs with 64 frames each, so of course it
> > will not be able to properly handle periods smaller than that.
> >
> > > FYI, em28xx works at a 48000 KHz sampling rate, and its PM capture Hw
> > > is described as:
> > >
> > > static struct snd_pcm_hardware snd_em28xx_hw_capture = {
> > > .info = SNDRV_PCM_INFO_BLOCK_TRANSFER |
> > > SNDRV_PCM_INFO_MMAP |
> > > SNDRV_PCM_INFO_INTERLEAVED |
> > > SNDRV_PCM_INFO_BATCH |
> > > SNDRV_PCM_INFO_MMAP_VALID,
> > >
> > > .formats = SNDRV_PCM_FMTBIT_S16_LE,
> > >
> > > .rates = SNDRV_PCM_RATE_CONTINUOUS | SNDRV_PCM_RATE_KNOT,
> >
> > This should be just SNDRV_PCM_RATE_48000.
>
> Ok.
>
> >
> > > .period_bytes_min = 64, /* 12544/2, */
> >
> > This is wrong (if the driver doesn't install other constraints on the
> > period length, like the USB audio class driver does).
>
> Ok, how should it be estimated? Those values here were simply glued from
> the USB audio class driver a long time ago without a further analysis.
>
> I changed it to 188 (the minimum URB size I experimentally noticed with
> the current settings) and it is now working fine with both xHCI and EHCI.
PS.: using 188 there, the URBs now have a total actual size of 24 bytes.
Regards,
--
Cheers,
Mauro
next prev parent reply other threads:[~2014-01-09 11:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 18:48 Fw: Isochronous transfer error on USB3 Mauro Carvalho Chehab
2014-01-08 20:14 ` Alan Stern
2014-01-09 8:17 ` [alsa-devel] " Clemens Ladisch
2014-01-09 11:29 ` Mauro Carvalho Chehab
2014-01-09 11:31 ` Mauro Carvalho Chehab [this message]
2014-01-09 12:10 ` Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109093155.35494ce2@samsung.com \
--to=m.chehab@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=hdegoede@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox