From: Mauro Carvalho Chehab <m.chehab@samsung.com>
To: Antti Palosaari <crope@iki.fi>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH 0/7] Fix remaining issues with em28xx device removal
Date: Mon, 13 Jan 2014 15:50:37 -0200 [thread overview]
Message-ID: <20140113155037.01e5f9cd@samsung.com> (raw)
In-Reply-To: <52D422B0.2020104@iki.fi>
Em Mon, 13 Jan 2014 19:30:24 +0200
Antti Palosaari <crope@iki.fi> escreveu:
> On 13.01.2014 01:00, Mauro Carvalho Chehab wrote:
> > Even after Frank's series, there are several issues with device module
> > removal.
> >
> > This series fix those issues, by use kref to deallocate the common
> > data (struct em28xx *dev).
> >
> > It also fixes a circular deppendency inside em28xx-audio.
> >
> > Mauro Carvalho Chehab (7):
> > em28xx-audio: fix return code on device disconnect
> > em28xx-audio: simplify error handling
> > em28xx: Only deallocate struct em28xx after finishing all extensions
> > em28xx-audio: disconnect before freeing URBs
> > em28xx-audio: remove a deplock circular dependency
> > em28xx: print a message at disconnect
> > em28xx: Fix usb diconnect logic
> >
> > drivers/media/usb/em28xx/em28xx-audio.c | 47 ++++++++++++++++++++-------------
> > drivers/media/usb/em28xx/em28xx-cards.c | 41 +++++++++++++---------------
> > drivers/media/usb/em28xx/em28xx-dvb.c | 7 ++++-
> > drivers/media/usb/em28xx/em28xx-input.c | 10 ++++++-
> > drivers/media/usb/em28xx/em28xx-video.c | 13 ++++-----
> > drivers/media/usb/em28xx/em28xx.h | 9 +++++--
> > 6 files changed, 76 insertions(+), 51 deletions(-)
> >
>
>
>
> Tested-by: Antti Palosaari <crope@iki.fi>
>
>
> I tested quite many em28xx devices and it seems to work very well.
>
> However, there is that (it looks new) error dump coming after device is
> unplugged.
That's likely because now the lockdep code is able to go one step further
on their tests.
> tammi 13 18:50:56 localhost.localdomain kernel: usb 8-2: USB disconnect,
> device number 2
> tammi 13 18:50:56 localhost.localdomain kernel: em2884 #0: Disconnecting
> em2884 #0
> tammi 13 18:50:56 localhost.localdomain kernel: em2884 #0: Disconnecting
> video extension
> tammi 13 18:50:56 localhost.localdomain kernel: em2884 #0: V4L2 device
> video0 deregistered
> tammi 13 18:50:56 localhost.localdomain kernel: em2884 #0: Disconnecting
> audio extension
> tammi 13 18:50:56 localhost.localdomain kernel: em2884 #0: Disconnecting
> DVB extension
> tammi 13 18:50:56 localhost.localdomain kernel: xc5000 6-0061:
> destroying instance
> tammi 13 18:50:56 localhost.localdomain kernel: em2884 #0: Disconnecting
> input extensionINFO: trying to register non-static key.
> tammi 13 18:50:56 localhost.localdomain kernel: the code is fine but
> needs lockdep annotation.
> tammi 13 18:50:56 localhost.localdomain kernel: turning off the locking
> correctness validator.
I suspect that the reason is because we're not flushing/canceling the
pending work on em28xx-alsa and em28xx-rc.
I can't reproduce it here, but could you please check if this patch fixes
it?
http://git.linuxtv.org/mchehab/experimental.git/commitdiff/144f41066bdab280869e309f76f7a42ad5b2be72
> tammi 13 18:50:56 localhost.localdomain kernel: CPU: 3 PID: 34 Comm:
> khubd Tainted: G O 3.13.0-rc1+ #79
> tammi 13 18:50:56 localhost.localdomain kernel: Hardware name: System
> manufacturer System Product Name/M5A78L-M/USB3, BIOS 1801 11/12/2013
> tammi 13 18:50:56 localhost.localdomain kernel: ffff88030da1a8a0
> ffff88030dbb99a8 ffffffff816b8da9 0000000000000002
> tammi 13 18:50:56 localhost.localdomain kernel: ffff88030dbb99b8
> ffffffff816b285c ffff88030dbb9a28 ffffffff810bb9ae
> tammi 13 18:50:56 localhost.localdomain kernel: ffffffff810b9bc9
> 00000007810b648d ffff88030da1a8a0 ffffffff810cbe27
> tammi 13 18:50:56 localhost.localdomain kernel: Call Trace:
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff816b8da9>]
> dump_stack+0x4d/0x66
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff816b285c>]
> register_lock_class.part.40+0x38/0x3c
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff810bb9ae>]
> __lock_acquire+0x9fe/0xc40
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff810b9bc9>] ?
> mark_held_locks+0xb9/0x140
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff810cbe27>] ?
> vprintk_emit+0x1d7/0x5e0
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff810bbca0>]
> lock_acquire+0xb0/0x150
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff81087f75>] ?
> flush_work+0x5/0x60
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff81087fa6>]
> flush_work+0x36/0x60
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff81087f75>] ?
> flush_work+0x5/0x60
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff8108858a>]
> __cancel_work_timer+0x8a/0x120
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff81088653>]
> cancel_delayed_work_sync+0x13/0x20
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffffa0839ba8>]
> em28xx_ir_fini+0x48/0xc0 [em28xx_rc]
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffffa07a4b8e>]
> em28xx_close_extension+0x3e/0x70 [em28xx]
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffffa07a6600>]
> em28xx_usb_disconnect+0x60/0x80 [em28xx]
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff814b7c87>]
> usb_unbind_interface+0x67/0x1d0
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff814378ff>]
> __device_release_driver+0x7f/0xf0
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff81437995>]
> device_release_driver+0x25/0x40
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff814371fc>]
> bus_remove_device+0x11c/0x1a0
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff81433c26>]
> device_del+0x136/0x1d0
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff814b5660>]
> usb_disable_device+0xb0/0x290
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff814aa5f5>]
> usb_disconnect+0xb5/0x1d0
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff814acfe6>]
> hub_port_connect_change+0xd6/0xad0
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff814b40a4>] ?
> usb_control_msg+0xd4/0x110
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff814adcf3>]
> hub_events+0x313/0x9b0
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff814ae3c5>]
> hub_thread+0x35/0x190
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff810b12d0>] ?
> abort_exclusive_wait+0xb0/0xb0
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff814ae390>] ?
> hub_events+0x9b0/0x9b0
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff8109044f>]
> kthread+0xff/0x120
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff81090350>] ?
> kthread_create_on_node+0x250/0x250
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff816ca67c>]
> ret_from_fork+0x7c/0xb0
> tammi 13 18:50:56 localhost.localdomain kernel: [<ffffffff81090350>] ?
> kthread_create_on_node+0x250/0x250
> tammi 13 18:50:56 localhost.localdomain kernel: em2884 #0: Freeing device
>
> regards
> Antti
>
>
>
--
Cheers,
Mauro
prev parent reply other threads:[~2014-01-13 17:50 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-12 23:00 [PATCH 0/7] Fix remaining issues with em28xx device removal Mauro Carvalho Chehab
2014-01-12 23:00 ` [PATCH 1/7] em28xx-audio: fix return code on device disconnect Mauro Carvalho Chehab
2014-01-13 18:38 ` Frank Schäfer
2014-01-12 23:00 ` [PATCH 2/7] em28xx-audio: simplify error handling Mauro Carvalho Chehab
2014-01-13 18:41 ` Frank Schäfer
2014-01-12 23:00 ` [PATCH 3/7] em28xx: Only deallocate struct em28xx after finishing all extensions Mauro Carvalho Chehab
2014-01-13 19:02 ` Frank Schäfer
2014-01-13 19:23 ` Mauro Carvalho Chehab
2014-01-13 21:55 ` Frank Schäfer
2014-01-14 13:10 ` Mauro Carvalho Chehab
2014-01-14 18:13 ` Frank Schäfer
2014-01-14 18:55 ` Mauro Carvalho Chehab
2014-01-14 19:31 ` Mauro Carvalho Chehab
2014-01-14 20:57 ` Frank Schäfer
2014-01-14 20:48 ` Frank Schäfer
2014-01-14 21:20 ` Mauro Carvalho Chehab
2014-01-15 18:48 ` Frank Schäfer
2014-01-14 17:36 ` [PATCH v2] " Mauro Carvalho Chehab
2014-01-15 21:13 ` Frank Schäfer
2014-02-09 18:41 ` Frank Schäfer
2014-02-09 20:09 ` Mauro Carvalho Chehab
2014-02-12 18:00 ` Frank Schäfer
2014-03-05 14:22 ` [PATCH v3] " Mauro Carvalho Chehab
2014-03-07 17:04 ` Frank Schäfer
2014-03-07 17:38 ` Mauro Carvalho Chehab
2014-03-08 10:51 ` Frank Schäfer
2014-01-12 23:00 ` [PATCH 4/7] em28xx-audio: disconnect before freeing URBs Mauro Carvalho Chehab
2014-01-13 18:47 ` Frank Schäfer
2014-01-12 23:00 ` [PATCH 5/7] em28xx-audio: remove a deplock circular dependency Mauro Carvalho Chehab
2014-01-13 21:51 ` Frank Schäfer
2014-01-14 15:45 ` Mauro Carvalho Chehab
2014-01-14 18:43 ` Frank Schäfer
2014-01-14 19:59 ` Mauro Carvalho Chehab
2014-01-14 20:51 ` Frank Schäfer
2014-01-12 23:00 ` [PATCH 6/7] em28xx: print a message at disconnect Mauro Carvalho Chehab
2014-01-13 18:51 ` Frank Schäfer
2014-01-12 23:00 ` [PATCH 7/7] em28xx: Fix usb diconnect logic Mauro Carvalho Chehab
2014-01-13 18:53 ` Frank Schäfer
2014-01-13 17:30 ` [PATCH 0/7] Fix remaining issues with em28xx device removal Antti Palosaari
2014-01-13 17:50 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140113155037.01e5f9cd@samsung.com \
--to=m.chehab@samsung.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).