From: Jarod Wilson <jarod@redhat.com>
To: "Antti Seppälä" <a.seppala@gmail.com>
Cc: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <m.chehab@samsung.com>
Subject: Re: [PATCH] nuvoton-cir: Don't touch PS/2 interrupts while initializing
Date: Mon, 27 Jan 2014 09:27:43 -0500 [thread overview]
Message-ID: <20140127142743.GC22912@redhat.com> (raw)
In-Reply-To: <1390643866-10350-1-git-send-email-a.seppala@gmail.com>
On Sat, Jan 25, 2014 at 11:57:46AM +0200, Antti Seppälä wrote:
> There are reports[1] that on some motherboards loading the nuvoton-cir
> disables PS/2 keyboard input. This is caused by an erroneous write of
> CIR_INTR_MOUSE_IRQ_BIT to ACPI control register.
>
> According to datasheet the write enables mouse power management event
> interrupts which will probably have ill effects if the motherboard has
> only one PS/2 port with keyboard in it.
>
> The cir hardware does not need mouse interrupts to function and should
> not touch them. This patch removes the illegal writes and registry
> definitions.
Probably a carry-over from the old Nuvoton code, nuking it makes sense to
me, always thought it was a little odd, but it never caused issues on the
system I had (which had no ps2).
Acked-by: Jarod Wilson <jarod@redhat.com>
--
Jarod Wilson
jarod@redhat.com
prev parent reply other threads:[~2014-01-27 14:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-25 9:57 [PATCH] nuvoton-cir: Don't touch PS/2 interrupts while initializing Antti Seppälä
2014-01-27 14:27 ` Jarod Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140127142743.GC22912@redhat.com \
--to=jarod@redhat.com \
--cc=a.seppala@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox