* [patch] [media] stv0900: remove an unneeded check
@ 2014-02-06 9:24 Dan Carpenter
2014-02-20 10:24 ` Hans Verkuil
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-02-06 9:24 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Michael Krufky, Cong Ding, linux-media, kernel-janitors
No need to check "lock" twice here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/dvb-frontends/stv0900_sw.c b/drivers/media/dvb-frontends/stv0900_sw.c
index 0a40edfad739..4ce1d260b3eb 100644
--- a/drivers/media/dvb-frontends/stv0900_sw.c
+++ b/drivers/media/dvb-frontends/stv0900_sw.c
@@ -1081,7 +1081,7 @@ static int stv0900_wait_for_lock(struct stv0900_internal *intp,
lock = stv0900_get_demod_lock(intp, demod, dmd_timeout);
if (lock)
- lock = lock && stv0900_get_fec_lock(intp, demod, fec_timeout);
+ lock = stv0900_get_fec_lock(intp, demod, fec_timeout);
if (lock) {
lock = 0;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] [media] stv0900: remove an unneeded check
2014-02-06 9:24 [patch] [media] stv0900: remove an unneeded check Dan Carpenter
@ 2014-02-20 10:24 ` Hans Verkuil
0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2014-02-20 10:24 UTC (permalink / raw)
To: Dan Carpenter
Cc: Mauro Carvalho Chehab, Michael Krufky, Cong Ding, linux-media,
kernel-janitors
On 02/06/14 10:24, Dan Carpenter wrote:
> No need to check "lock" twice here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Regards,
Hans
>
> diff --git a/drivers/media/dvb-frontends/stv0900_sw.c b/drivers/media/dvb-frontends/stv0900_sw.c
> index 0a40edfad739..4ce1d260b3eb 100644
> --- a/drivers/media/dvb-frontends/stv0900_sw.c
> +++ b/drivers/media/dvb-frontends/stv0900_sw.c
> @@ -1081,7 +1081,7 @@ static int stv0900_wait_for_lock(struct stv0900_internal *intp,
> lock = stv0900_get_demod_lock(intp, demod, dmd_timeout);
>
> if (lock)
> - lock = lock && stv0900_get_fec_lock(intp, demod, fec_timeout);
> + lock = stv0900_get_fec_lock(intp, demod, fec_timeout);
>
> if (lock) {
> lock = 0;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-20 10:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-06 9:24 [patch] [media] stv0900: remove an unneeded check Dan Carpenter
2014-02-20 10:24 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox