From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@01.org, Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>, linux-media@vger.kernel.org
Subject: [linuxtv-media:master 463/499] drivers/media/dvb-frontends/drx39xyj/drxj.c:20803 drx_ctrl_u_code() warn: variable dereferenced before check 'mc_info' (see line 20800)
Date: Wed, 5 Mar 2014 11:46:40 +0300 [thread overview]
Message-ID: <20140305084640.GS27552@mwanda> (raw)
Hi Mauro,
FYI, there are new smatch warnings show up in
tree: git://linuxtv.org/media_tree.git master
head: 59432be1c7fbf2a4f608850855ff649bee0f7b3b
commit: b240eacdd536bac23c9d48dfc3d527ed6870ddad [463/499] [media] drx-j: get rid of drx_driver.c
New smatch warnings:
drivers/media/dvb-frontends/drx39xyj/drxj.c:20803 drx_ctrl_u_code() warn: variable dereferenced before check 'mc_info' (see line 20800)
Old smatch warnings:
drivers/media/dvb-frontends/drx39xyj/drxj.c:1218 mult32() warn: missing break? reassigning '*h'
git remote add linuxtv-media git://linuxtv.org/media_tree.git
git remote update linuxtv-media
git checkout b240eacdd536bac23c9d48dfc3d527ed6870ddad
vim +/mc_info +20803 drivers/media/dvb-frontends/drx39xyj/drxj.c
b240eacd Mauro Carvalho Chehab 2014-01-24 20794 u16 i = 0;
b240eacd Mauro Carvalho Chehab 2014-01-24 20795 u16 mc_nr_of_blks = 0;
b240eacd Mauro Carvalho Chehab 2014-01-24 20796 u16 mc_magic_word = 0;
b240eacd Mauro Carvalho Chehab 2014-01-24 20797 const u8 *mc_data_init = NULL;
b240eacd Mauro Carvalho Chehab 2014-01-24 20798 u8 *mc_data = NULL;
b240eacd Mauro Carvalho Chehab 2014-01-24 20799 unsigned size;
b240eacd Mauro Carvalho Chehab 2014-01-24 @20800 char *mc_file = mc_info->mc_file;
b240eacd Mauro Carvalho Chehab 2014-01-24 20801
b240eacd Mauro Carvalho Chehab 2014-01-24 20802 /* Check arguments */
b240eacd Mauro Carvalho Chehab 2014-01-24 @20803 if (!mc_info || !mc_file)
b240eacd Mauro Carvalho Chehab 2014-01-24 20804 return -EINVAL;
b240eacd Mauro Carvalho Chehab 2014-01-24 20805
b240eacd Mauro Carvalho Chehab 2014-01-24 20806 if (!demod->firmware) {
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
reply other threads:[~2014-03-05 8:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305084640.GS27552@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kbuild@01.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox