From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Frank Schäfer" <fschaefer.oss@googlemail.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] [patch] [media] em28xx-cards: remove a wrong indent level
Date: Fri, 7 Mar 2014 20:01:10 +0300 [thread overview]
Message-ID: <20140307170110.GP4774@mwanda> (raw)
In-Reply-To: <5319F7E4.1000303@googlemail.com>
On Fri, Mar 07, 2014 at 05:46:28PM +0100, Frank Schäfer wrote:
>
> Am 05.03.2014 12:09, schrieb Dan Carpenter:
> > This code is correct but the indenting is wrong and triggers a static
> > checker warning "add curly braces?".
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > v2: in v1 I added curly braces.
> >
> > diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c
> > index 4d97a76cc3b0..33f06ffec4b2 100644
> > --- a/drivers/media/usb/em28xx/em28xx-cards.c
> > +++ b/drivers/media/usb/em28xx/em28xx-cards.c
> > @@ -3331,8 +3331,8 @@ static int em28xx_usb_probe(struct usb_interface *interface,
> > if (has_video) {
> > if (!dev->analog_ep_isoc || (try_bulk && dev->analog_ep_bulk))
> > dev->analog_xfer_bulk = 1;
> > - em28xx_info("analog set to %s mode.\n",
> > - dev->analog_xfer_bulk ? "bulk" : "isoc");
> > + em28xx_info("analog set to %s mode.\n",
> > + dev->analog_xfer_bulk ? "bulk" : "isoc");
>
> Instead of moving em28xx_info(...) to the left the if section needs to
> be moved to the right:
>
> - if (!dev->analog_ep_isoc || (try_bulk && dev->analog_ep_bulk))
> - dev->analog_xfer_bulk = 1;
> + if (!dev->analog_ep_isoc || (try_bulk && dev->analog_ep_bulk))
> + dev->analog_xfer_bulk = 1;
Yes. I'd happy to.
>
> While you are at it, could you also do fix the indention in the next
> paragraph ?
The next paragraph is almost identical but my static checker was
ignoring the curly braces because of the blank line. I'll modify to
complain about that as well.
I'll resend. Thanks for the review.
regards,
dan carpenter
next prev parent reply other threads:[~2014-03-07 17:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 20:04 [patch] [media] em28xx-cards: don't print a misleading message Dan Carpenter
2014-02-24 18:04 ` Frank Schäfer
2014-02-24 18:13 ` Dan Carpenter
2014-03-05 11:09 ` [patch v2] [patch] [media] em28xx-cards: remove a wrong indent level Dan Carpenter
2014-03-07 16:46 ` Frank Schäfer
2014-03-07 17:01 ` Dan Carpenter [this message]
2014-04-30 9:36 ` [patch v3] [media] em28xx-cards: fix indenting in probe() Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307170110.GP4774@mwanda \
--to=dan.carpenter@oracle.com \
--cc=fschaefer.oss@googlemail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox