From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout3.w2.samsung.com ([211.189.100.13]:22579 "EHLO usmailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753224AbaCLLCi (ORCPT ); Wed, 12 Mar 2014 07:02:38 -0400 Received: from uscpsbgm1.samsung.com (u114.gpu85.samsung.co.kr [203.254.195.114]) by usmailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N2B00FD3LCD2N90@usmailout3.samsung.com> for linux-media@vger.kernel.org; Wed, 12 Mar 2014 07:02:37 -0400 (EDT) Date: Wed, 12 Mar 2014 08:02:33 -0300 From: Mauro Carvalho Chehab To: Antti Palosaari Cc: LMML Subject: Re: [REVIEW PATCH 11/13] DocBook: document RF tuner bandwidth controls Message-id: <20140312080233.3823dd80@samsung.com> In-reply-to: <531D8D78.800@iki.fi> References: <1393460528-11684-1-git-send-email-crope@iki.fi> <1393460528-11684-12-git-send-email-crope@iki.fi> <20140305154922.508c48d7@samsung.com> <531D8D78.800@iki.fi> MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Mon, 10 Mar 2014 12:01:28 +0200 Antti Palosaari escreveu: > On 05.03.2014 20:49, Mauro Carvalho Chehab wrote: > > Em Thu, 27 Feb 2014 02:22:06 +0200 > > Antti Palosaari escreveu: > > > >> Add documentation for RF tuner bandwidth controls. These controls are > >> used to set filters on tuner signal path. > >> > >> Cc: Hans Verkuil > >> Signed-off-by: Antti Palosaari > >> --- > >> Documentation/DocBook/media/v4l/controls.xml | 19 +++++++++++++++++++ > >> 1 file changed, 19 insertions(+) > >> > >> diff --git a/Documentation/DocBook/media/v4l/controls.xml b/Documentation/DocBook/media/v4l/controls.xml > >> index 6c9dbf6..5550fea 100644 > >> --- a/Documentation/DocBook/media/v4l/controls.xml > >> +++ b/Documentation/DocBook/media/v4l/controls.xml > >> @@ -5007,6 +5007,25 @@ descriptor. Calling &VIDIOC-QUERYCTRL; for this control will return a > >> description of this control class. > >> > >> > >> + V4L2_CID_RF_TUNER_BANDWIDTH_AUTO  > >> + boolean > >> + > >> + > >> + Enables/disables tuner radio channel > >> +bandwidth configuration. In automatic mode bandwidth configuration is performed > >> +by the driver. > >> + > >> + > >> + V4L2_CID_RF_TUNER_BANDWIDTH  > >> + integer > >> + > >> + > >> + Filter(s) on tuner signal path are used to > >> +filter signal according to receiving party needs. Driver configures filters to > >> +fulfill desired bandwidth requirement. Used when V4L2_CID_RF_TUNER_BANDWIDTH_AUTO is not > >> +set. The range and step are driver-specific. > > > > Huh? If this is enable/disable, why "the range and step are driver-specific"? > > Because there is two controls grouped. That is situation of having > AUTO/MANUAL. > V4L2_CID_RF_TUNER_BANDWIDTH_AUTO > V4L2_CID_RF_TUNER_BANDWIDTH > > V4L2_CID_RF_TUNER_BANDWIDTH is valid only when > V4L2_CID_RF_TUNER_BANDWIDTH_AUTO == false. > Sorry, but I'm not understanding what you're arguing. Yeah, it is clear at the patch that there are two controls, and that V4L2_CID_RF_TUNER_BANDWIDTH is valid only when AUTO is disabled, but this doesn't answer my question: Why V4L2_CID_RF_TUNER_BANDWIDTH's range and step are driver-specific? -- Regards, Mauro