From: Mauro Carvalho Chehab <m.chehab@samsung.com>
To: Antti Palosaari <crope@iki.fi>
Cc: Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org
Subject: Re: [linuxtv-media:master 471/499] e4000.c:undefined reference to `v4l2_ctrl_handler_free'
Date: Sat, 15 Mar 2014 21:26:03 -0300 [thread overview]
Message-ID: <20140315212603.369388f1@samsung.com> (raw)
In-Reply-To: <53248108.4040601@iki.fi>
Em Sat, 15 Mar 2014 18:34:16 +0200
Antti Palosaari <crope@iki.fi> escreveu:
> Mauro,
> I am not sure how this should be resolved. E4000 has already depends to
> VIDEO_V4L2. Should VIDEO_V4L2 selected in config MEDIA_SUBDRV_AUTOSELECT ?
The problem is likely with the Kconfig at the dvb driver. You should
remember that select doesn't recursively select the dependencies.
So, you should either make the v4l2 control framework optional at
e4000 or to make VB_USB_RTL28XXU to either depend or select
V4L2 core.
There's also a third option: add stubs for the v4l2_ctrl_* functions
at the *.h file. This way, if V4L2 is not compiled, the functions
won't do anything. Perhaps this is the most elegant solution.
Hans,
any comments?
Regards,
Mauro
>
> regards
> Antti
>
>
> On 15.03.2014 14:18, kbuild test robot wrote:
> > tree: git://linuxtv.org/media_tree.git master
> > head: ed97a6fe5308e5982d118a25f0697b791af5ec50
> > commit: adaa616ffb697f00db9b4ccb638c5e9e719dbb7f [471/499] [media] e4000: implement controls via v4l2 control framework
> > config: i386-randconfig-j4-03151459 (attached as .config)
> >
> > All error/warnings:
> >
> > warning: (DVB_USB_RTL28XXU) selects MEDIA_TUNER_E4000 which has unmet direct dependencies ((MEDIA_ANALOG_TV_SUPPORT || MEDIA_DIGITAL_TV_SUPPORT || MEDIA_RADIO_SUPPORT) && MEDIA_SUPPORT && I2C && VIDEO_V4L2)
> > drivers/built-in.o: In function `e4000_remove':
> >>> e4000.c:(.text+0x541015): undefined reference to `v4l2_ctrl_handler_free'
> > drivers/built-in.o: In function `e4000_probe':
> >>> e4000.c:(.text+0x54219e): undefined reference to `v4l2_ctrl_handler_init_class'
> >>> e4000.c:(.text+0x5421ce): undefined reference to `v4l2_ctrl_new_std'
> >>> e4000.c:(.text+0x542204): undefined reference to `v4l2_ctrl_new_std'
> >>> e4000.c:(.text+0x542223): undefined reference to `v4l2_ctrl_auto_cluster'
> >>> e4000.c:(.text+0x542253): undefined reference to `v4l2_ctrl_new_std'
> >>> e4000.c:(.text+0x542289): undefined reference to `v4l2_ctrl_new_std'
> >>> e4000.c:(.text+0x5422a8): undefined reference to `v4l2_ctrl_auto_cluster'
> >>> e4000.c:(.text+0x5422d8): undefined reference to `v4l2_ctrl_new_std'
> >>> e4000.c:(.text+0x54230e): undefined reference to `v4l2_ctrl_new_std'
> >>> e4000.c:(.text+0x54232d): undefined reference to `v4l2_ctrl_auto_cluster'
> >>> e4000.c:(.text+0x54235d): undefined reference to `v4l2_ctrl_new_std'
> >>> e4000.c:(.text+0x542393): undefined reference to `v4l2_ctrl_new_std'
> >>> e4000.c:(.text+0x5423b2): undefined reference to `v4l2_ctrl_auto_cluster'
> >>> e4000.c:(.text+0x5423d8): undefined reference to `v4l2_ctrl_handler_free'
> >
> > ---
> > 0-DAY kernel build testing backend Open Source Technology Center
> > http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
> >
>
>
--
Regards,
Mauro
next prev parent reply other threads:[~2014-03-16 0:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-15 12:18 [linuxtv-media:master 471/499] e4000.c:undefined reference to `v4l2_ctrl_handler_free' kbuild test robot
2014-03-15 16:34 ` Antti Palosaari
2014-03-16 0:26 ` Mauro Carvalho Chehab [this message]
2014-03-16 12:10 ` Hans Verkuil
2014-03-16 13:03 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140315212603.369388f1@samsung.com \
--to=m.chehab@samsung.com \
--cc=crope@iki.fi \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox