From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-media-owner@vger.kernel.org>
Received: from mail-we0-f178.google.com ([74.125.82.178]:65126 "EHLO
	mail-we0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932279AbaCTPet (ORCPT
	<rfc822;linux-media@vger.kernel.org>);
	Thu, 20 Mar 2014 11:34:49 -0400
Received: by mail-we0-f178.google.com with SMTP id u56so717542wes.37
        for <linux-media@vger.kernel.org>; Thu, 20 Mar 2014 08:34:48 -0700 (PDT)
Date: Thu, 20 Mar 2014 15:34:43 +0000
From: Lee Jones <lee.jones@linaro.org>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: linux-media@vger.kernel.org, linux-leds@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	s.nawrocki@samsung.com, a.hajda@samsung.com,
	kyungmin.park@samsung.com, Bryan Wu <cooloney@gmail.com>,
	Richard Purdie <rpurdie@rpsys.net>,
	SangYoung Son <hello.son@smasung.com>,
	Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH/RFC 6/8] leds: Add support for max77693 mfd flash cell
Message-ID: <20140320153443.GD8207@lee--X1>
References: <1395327070-20215-1-git-send-email-j.anaszewski@samsung.com>
 <1395327070-20215-7-git-send-email-j.anaszewski@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1395327070-20215-7-git-send-email-j.anaszewski@samsung.com>
Sender: linux-media-owner@vger.kernel.org
List-ID: <linux-media.vger.kernel.org>

On Thu, 20 Mar 2014, Jacek Anaszewski wrote:

> This patch adds led-flash support to Maxim max77693 chipset.
> Device can be exposed to user space through LED subsystem
> sysfs interface or through V4L2 subdevice when the support
> for Multimedia Framework is enabled. Device supports up to
> two leds which can work in flash and torch mode. Leds can
> be triggered externally or by software.
> 
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Bryan Wu <cooloney@gmail.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> Cc: SangYoung Son <hello.son@smasung.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/leds/Kconfig         |    9 +
>  drivers/leds/Makefile        |    1 +
>  drivers/leds/leds-max77693.c |  768 ++++++++++++++++++++++++++++++++++++++++++
>  drivers/mfd/max77693.c       |   21 +-
>  include/linux/mfd/max77693.h |   32 ++
>  5 files changed, 825 insertions(+), 6 deletions(-)
>  create mode 100644 drivers/leds/leds-max77693.c

[...]

> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index c5535f0..6fa92d3 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -41,12 +41,21 @@
>  #define I2C_ADDR_MUIC	(0x4A >> 1)
>  #define I2C_ADDR_HAPTIC	(0x90 >> 1)
>  
> -static const struct mfd_cell max77693_devs[] = {
> -	{ .name = "max77693-pmic", },
> -	{ .name = "max77693-charger", },
> -	{ .name = "max77693-flash", },
> -	{ .name = "max77693-muic", },
> -	{ .name = "max77693-haptic", },
> +enum mfd_devs_idx {
> +	IDX_PMIC,
> +	IDX_CHARGER,
> +	IDX_LED,
> +	IDX_MUIC,
> +	IDX_HAPTIC,
> +};
> +
> +static struct mfd_cell max77693_devs[] = {
> +	[IDX_PMIC]      = { .name = "max77693-pmic", },
> +	[IDX_CHARGER]   = { .name = "max77693-charger", },
> +	[IDX_LED]       = { .name = "max77693-led",
> +			    .of_compatible = "maxim,max77693-led"},
> +	[IDX_MUIC]      = { .name = "max77693-muic", },
> +	[IDX_HAPTIC]    = { .name = "max77693-haptic", },
>  };

What is the purpose of this change?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog