From: "David Härdeman" <david@hardeman.nu>
To: pboettcher@kernellabs.com
Cc: linux-media@vger.kernel.org
Subject: Re: dib0700 NEC scancode question
Date: Thu, 27 Mar 2014 22:40:41 +0100 [thread overview]
Message-ID: <20140327214041.GA21302@hardeman.nu> (raw)
In-Reply-To: <20140327120728.GA13748@hardeman.nu>
On Thu, Mar 27, 2014 at 01:07:28PM +0100, David Härdeman wrote:
>Hi Patrick,
>
>a quick question regarding the dib0700 driver:
>
>in ./media/usb/dvb-usb/dib0700_core.c the RC RX packet is defined as:
...
>The NEC protocol transmits in the order:
...
>Does the dib0700 fw really reorder the bytes, or could the order of
>not_system and system in struct dib0700_rc_response have been
>accidentally reversed?
...
>Which, if the order *is* reversed, would mean that the scancode that
>gets defined is in reality:
>
> keycode = poll_reply->system << 16 |
> poll_reply->not_system << 8 |
> poll_reply->data;
>
>Which is the same as the order used in drivers/media/rc/ir-nec-decoder.c.
>
>(An order which I'm considering trying to correct, which is why I'm
s/correct/make sure it's consistent/
--
David Härdeman
next prev parent reply other threads:[~2014-03-27 21:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 12:07 dib0700 NEC scancode question David Härdeman
2014-03-27 21:40 ` David Härdeman [this message]
2014-03-27 22:13 ` Patrick Boettcher
2014-03-27 23:43 ` David Härdeman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140327214041.GA21302@hardeman.nu \
--to=david@hardeman.nu \
--cc=linux-media@vger.kernel.org \
--cc=pboettcher@kernellabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).