From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [media] V4L: Add driver for S3C24XX/S3C64XX SoC series camera interface
Date: Fri, 4 Apr 2014 14:27:17 +0300 [thread overview]
Message-ID: <20140404112717.GR18506@mwanda> (raw)
In-Reply-To: <521CB6FF.70401@samsung.com>
Whatever happened with this btw? Also are you sure we don't need a
second check after line 457?
regards,
dan carpenter
On Tue, Aug 27, 2013 at 04:26:07PM +0200, Sylwester Nawrocki wrote:
> On 08/27/2013 04:19 PM, Dan Carpenter wrote:
> > On Sun, Aug 25, 2013 at 02:23:18PM +0200, Sylwester Nawrocki wrote:
> >> On 08/23/2013 11:46 AM, Dan Carpenter wrote:
> >>> [ Going through some old warnings... ]
> >>>
> >>> Hello Sylwester Nawrocki,
> >>>
> >>> This is a semi-automatic email about new static checker warnings.
> >>>
> >>> The patch babde1c243b2: "[media] V4L: Add driver for S3C24XX/S3C64XX
> >>> SoC series camera interface" from Aug 22, 2012, leads to the
> >>> following Smatch complaint:
> >>>
> >>> drivers/media/platform/s3c-camif/camif-capture.c:463 queue_setup()
> >>> warn: variable dereferenced before check 'fmt' (see line 460)
> >>>
> >>> drivers/media/platform/s3c-camif/camif-capture.c
> >>> 455 if (pfmt) {
> >>> 456 pix =&pfmt->fmt.pix;
> >>> 457 fmt = s3c_camif_find_format(vp,&pix->pixelformat, -1);
> >>> 458 size = (pix->width * pix->height * fmt->depth) / 8;
> >>> ^^^^^^^^^^
> >>> Dereference.
> >>>
> >>> 459 } else {
> >>> 460 size = (frame->f_width * frame->f_height * fmt->depth) / 8;
> >>> ^^^^^^^^^^
> >>> Dereference.
> >>>
> >>> 461 }
> >>> 462
> >>> 463 if (fmt == NULL)
> >>> ^^^^^^^^^^^
> >>> Check.
> >>
> >> Thanks for the bug report. This check of course should be before line 455.
> >> Would you like to sent a patch for this or should I handle that ?
> >
> > Could you handle it and give me the Reported-by tag?
>
> Sure, will do.
>
> --
> Regards,
> Sylwester
prev parent reply other threads:[~2014-04-04 11:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 9:46 [media] V4L: Add driver for S3C24XX/S3C64XX SoC series camera interface Dan Carpenter
2013-08-25 12:23 ` Sylwester Nawrocki
2013-08-27 14:19 ` Dan Carpenter
2013-08-27 14:26 ` Sylwester Nawrocki
2014-04-04 11:27 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140404112717.GR18506@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sylvester.nawrocki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox