From: Dan Carpenter <dan.carpenter@oracle.com>
To: Vitaly Osipov <vitaly.osipov@gmail.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 2/2] staging: media: omap24xx: fix up a checkpatch.pl warning
Date: Thu, 10 Apr 2014 12:48:50 +0300 [thread overview]
Message-ID: <20140410094850.GF26890@mwanda> (raw)
In-Reply-To: <20140410090234.GA8654@witts-MacBook-Pro.local>
The two subjects are really close to being the same. You should choose
better subjects. Like:
[PATCH 2/2] staging: media: omap24xx: use pr_info() instead of KERN_INFO
(All the checkpatch.pl people use the exact same subject for everything
though, so you're not alone in this).
regards,
dan carpenter
next prev parent reply other threads:[~2014-04-10 9:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 9:02 [PATCH 2/2] staging: media: omap24xx: fix up a checkpatch.pl warning Vitaly Osipov
2014-04-10 9:48 ` Dan Carpenter [this message]
2014-04-10 11:57 ` Vitaly Osipov
2014-04-10 12:30 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140410094850.GF26890@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=vitaly.osipov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox