From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Sander Eikelenboom <linux@eikelenboom.it>
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
Dan Williams <dan.j.williams@intel.com>,
linux-media@vger.kernel.org,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
linux-usb@vger.kernel.org
Subject: Re: stk1160 / ehci-pci 0000:00:0a.0: DMA-API: device driver maps memory fromstack [addr=ffff88003d0b56bf]
Date: Mon, 14 Apr 2014 09:12:31 -0300 [thread overview]
Message-ID: <20140414121231.GA6393@arch.cereza> (raw)
In-Reply-To: <438386739.20140413224553@eikelenboom.it>
On Apr 13, Sander Eikelenboom wrote:
>
> I'm hitting this warning on boot with a syntek usb video grabber, it's not clear
> to me if it's a driver issue of the stk1160 or a generic ehci issue.
>
Can't reproduce the same warning easily here. Could you test the following patch?
diff --git a/drivers/media/usb/stk1160/stk1160-core.c b/drivers/media/usb/stk1160/stk1160-core.c
index 34a26e0..304fdb3 100644
--- a/drivers/media/usb/stk1160/stk1160-core.c
+++ b/drivers/media/usb/stk1160/stk1160-core.c
@@ -71,13 +71,14 @@ int stk1160_read_reg(struct stk1160 *dev, u16 reg, u8 *value)
*value = 0;
ret = usb_control_msg(dev->udev, pipe, 0x00,
USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
- 0x00, reg, value, sizeof(u8), HZ);
+ 0x00, reg, dev->urb_buf, sizeof(u8), HZ);
if (ret < 0) {
stk1160_err("read failed on reg 0x%x (%d)\n",
reg, ret);
return ret;
}
+ *value = dev->urb_buf[0];
return 0;
}
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-14 12:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-13 20:45 stk1160 / ehci-pci 0000:00:0a.0: DMA-API: device driver maps memory fromstack [addr=ffff88003d0b56bf] Sander Eikelenboom
2014-04-14 2:21 ` Alan Stern
2014-04-14 9:33 ` Ezequiel Garcia
2014-04-14 12:12 ` Ezequiel Garcia [this message]
2014-04-14 16:06 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414121231.GA6393@arch.cereza \
--to=ezequiel.garcia@free-electrons.com \
--cc=dan.j.williams@intel.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@eikelenboom.it \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox