Re: [PATCH v2] radio-bcm2048.c: fix wrong overflow check

Hans Verkuil
2014-05-09T17:13:35Z

On 05/09/2014 06:10 PM, Pali Rohár wrote:
> On Monday 05 May 2014 15:34:29 Jiri Kosina wrote:
>> On Tue, 22 Apr 2014, Dan Carpenter wrote:
>>> From: Pali Rohár <pali.rohar@gmail.com>
>>>
>>> This patch fixes an off by one check in
>>> bcm2048_set_region().
>>>
>>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>>> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
>>> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>> ---
>>> v2: Send it to the correct list. Re-work the changelog.
>>>
>>> This patch has been floating around for four months but
>>> Pavel and Pali are knuckle-heads and don't know how to use
>>> get_maintainer.pl so they never send it to linux-media.
>>>
>>> Also Pali doesn't give reporter credit and Pavel steals
>>> authorship credit.
>>>
>>> Also when you try explain to them about how to send patches
>>> correctly they complain that they have been trying but it
>>> is too much work so now I have to do it. During the past
>>> four months thousands of other people have been able to
>>> send patches in the correct format to the correct list but
>>> it is too difficult for Pavel and Pali... *sigh*.
>>
>> Seems like it's not in linux-next as of today, so I am taking
>> it now. Thanks,
>
> I still do not see this patch in torvalds branch... So what is
> needed to include this security buffer overflow patch into
> mainline & stable kernels?
>

Today I collected a pile of pending patches including this one and
posted a pull request on the linux-media mailinglist. Once Mauro picks
it up it will appear in our tree and then linux-next. He's been
travelling for the past two weeks, so he'll have a sizable backlog.

Just be patient, it's not forgotten.

Regards,

Hans