Re: [PATCH] Kernel 3.15-rc2 : Peak DVB-T USB tuner device ids for rtl28xxu driver

Re: [PATCH] Kernel 3.15-rc2 : Peak DVB-T USB tuner device ids for rtl28xxu driver

[Linus Torvalds]

Brian, please use

 ./scripts/get_maintainer -f drivers/media/usb/dvb-usb-v2/rtl28xxu.c

to get the proper people to send this to, so that it doesn't get lost
in the flood in lkml.

The indentation of that new entry also seems to be suspect, in that it
doesn't match the ones around it.

Quoting full email for context for people added.

             Linus

On Sat, Apr 26, 2014 at 9:36 AM, Brian Healy <healybrian@gmail.com> wrote:
> [PATCH] Kernel 3.15-rc2 : Peak DVB-T USB tuner device ids for rtl28xxu driver
>
> Signed-off-by: Brian Healy <healybrian<at>gmail.com>
>
>
> --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c.orig    2014-04-26
> 17:02:36.068691000 +0100
> +++ drivers/media/usb/dvb-usb-v2/rtl28xxu.c    2014-04-26
> 17:03:11.944691000 +0100
> @@ -1499,6 +1499,8 @@ static const struct usb_device_id rtl28x
>          &rtl2832u_props, "Crypto ReDi PC 50 A", NULL) },
>      { DVB_USB_DEVICE(USB_VID_KYE, 0x707f,
>          &rtl2832u_props, "Genius TVGo DVB-T03", NULL) },
> +        { DVB_USB_DEVICE(USB_VID_KWORLD_2, 0xd395,
> +                &rtl2832u_props, "Peak DVB-T USB", NULL) },
>
>      /* RTL2832P devices: */
>      { DVB_USB_DEVICE(USB_VID_HANFTEK, 0x0131,

Re: [PATCH] Kernel 3.15-rc2 : Peak DVB-T USB tuner device ids for rtl28xxu driver

[Brian Healy]

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

On Sun, Apr 27, 2014 at 03:19:12PM -0700, Linus Torvalds wrote:

Hi Linus,

apologies, i've changed email clients in order to preserve the
formatting this time around. The patch is now included inline as an
attachment. I ran the script but noticed you've already cc'd the
appropriate people. 

Brian.


Resubmitting modified patch. It's purpose is to add the appropriate
device/usb ids for the "Peak DVT-B usb dongle" to the rtl28xxu.c driver.

Signed-off-by: Brian Healy <healybrian <at> gmail.com>


> Brian, please use
> 
>  ./scripts/get_maintainer -f drivers/media/usb/dvb-usb-v2/rtl28xxu.c
> 
> to get the proper people to send this to, so that it doesn't get lost
> in the flood in lkml.
> 
> The indentation of that new entry also seems to be suspect, in that it
> doesn't match the ones around it.
> 
> Quoting full email for context for people added.
> 
>              Linus
> 

[-- Attachment #2: rtl28xxu.patch --]
[-- Type: text/x-diff, Size: 626 bytes --]

diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
index 61d196e..b6e20cc 100644
--- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
+++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
@@ -1499,6 +1499,8 @@ static const struct usb_device_id rtl28xxu_id_table[] = {
 		&rtl2832u_props, "Crypto ReDi PC 50 A", NULL) },
 	{ DVB_USB_DEVICE(USB_VID_KYE, 0x707f,
 		&rtl2832u_props, "Genius TVGo DVB-T03", NULL) },
+        { DVB_USB_DEVICE(USB_VID_KWORLD_2, 0xd395,
+                &rtl2832u_props, "Peak DVB-T USB", NULL) },
 
 	/* RTL2832P devices: */
 	{ DVB_USB_DEVICE(USB_VID_HANFTEK, 0x0131,

Re: [PATCH] Kernel 3.15-rc2 : Peak DVB-T USB tuner device ids for rtl28xxu driver

[Mauro Carvalho Chehab]

Em Mon, 28 Apr 2014 22:40:00 +0100
Brian Healy <healybrian@gmail.com> escreveu:

> From: Brian Healy <healybrian@gmail.com>
> To: Antti Palosaari <crope@iki.fi>, Mauro Carvalho Chehab <m.chehab@samsung.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Media Mailing List <linux-media@vger.kernel.org>
> Subject: Re: [PATCH] Kernel 3.15-rc2 : Peak DVB-T USB tuner device ids for rtl28xxu driver
> Date: Mon, 28 Apr 2014 22:40:00 +0100
> Sender: linux-media-owner@vger.kernel.org
> User-Agent: Mutt/1.5.21 (2010-09-15)
> 
> On Sun, Apr 27, 2014 at 03:19:12PM -0700, Linus Torvalds wrote:
> 
> Hi Linus,
> 
> apologies, i've changed email clients in order to preserve the
> formatting this time around. The patch is now included inline as an
> attachment. I ran the script but noticed you've already cc'd the
> appropriate people. 
> 
> Brian.
> 
> 
> Resubmitting modified patch. It's purpose is to add the appropriate
> device/usb ids for the "Peak DVT-B usb dongle" to the rtl28xxu.c driver.
> 
> Signed-off-by: Brian Healy <healybrian <at> gmail.com>
> 
> 
> > Brian, please use
> > 
> >  ./scripts/get_maintainer -f drivers/media/usb/dvb-usb-v2/rtl28xxu.c
> > 
> > to get the proper people to send this to, so that it doesn't get lost
> > in the flood in lkml.
> > 
> > The indentation of that new entry also seems to be suspect, in that it
> > doesn't match the ones around it.
> > 
> > Quoting full email for context for people added.
> > 
> >              Linus
> >   
> 
> diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
> index 61d196e..b6e20cc 100644
> --- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
> +++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
> @@ -1499,6 +1499,8 @@ static const struct usb_device_id rtl28xxu_id_table[] = {
>  		&rtl2832u_props, "Crypto ReDi PC 50 A", NULL) },
>  	{ DVB_USB_DEVICE(USB_VID_KYE, 0x707f,
>  		&rtl2832u_props, "Genius TVGo DVB-T03", NULL) },
> +        { DVB_USB_DEVICE(USB_VID_KWORLD_2, 0xd395,
> +                &rtl2832u_props, "Peak DVB-T USB", NULL) },

Patch is still a little odd, as you're using spaces for indenting, instead of
tabs, but I can fix it with my scripts. Next time, please use tabs.

Also, specifically in the case of patches for linux-media, you don't need 
to c/c me. Just send the patch to linux-media and to the driver maintainer
(Antti, in this case).

My workflow is to pick the patches from patchwork:
	https://patchwork.linuxtv.org/patch/23792/
after receiving Antti's ack.

Alternatively, Antti may opt to put it on his git tree, sending it to me
latter together of other patches he may have for the devices he maintains.

>  
>  	/* RTL2832P devices: */
>  	{ DVB_USB_DEVICE(USB_VID_HANFTEK, 0x0131,

Thanks,
Mauro

Re: [PATCH] Kernel 3.15-rc2 : Peak DVB-T USB tuner device ids for rtl28xxu driver

[Brian Healy]

Thanks Mauro,

I'll know for next time. It's my first patch submission so wasn't
aware of the formatting rules.

Brian

On 29 April 2014 15:16, Mauro Carvalho Chehab <m.chehab@samsung.com> wrote:
> Em Mon, 28 Apr 2014 22:40:00 +0100
> Brian Healy <healybrian@gmail.com> escreveu:
>
>> From: Brian Healy <healybrian@gmail.com>
>> To: Antti Palosaari <crope@iki.fi>, Mauro Carvalho Chehab <m.chehab@samsung.com>
>> Cc: Linus Torvalds <torvalds@linux-foundation.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Media Mailing List <linux-media@vger.kernel.org>
>> Subject: Re: [PATCH] Kernel 3.15-rc2 : Peak DVB-T USB tuner device ids for rtl28xxu driver
>> Date: Mon, 28 Apr 2014 22:40:00 +0100
>> Sender: linux-media-owner@vger.kernel.org
>> User-Agent: Mutt/1.5.21 (2010-09-15)
>>
>> On Sun, Apr 27, 2014 at 03:19:12PM -0700, Linus Torvalds wrote:
>>
>> Hi Linus,
>>
>> apologies, i've changed email clients in order to preserve the
>> formatting this time around. The patch is now included inline as an
>> attachment. I ran the script but noticed you've already cc'd the
>> appropriate people.
>>
>> Brian.
>>
>>
>> Resubmitting modified patch. It's purpose is to add the appropriate
>> device/usb ids for the "Peak DVT-B usb dongle" to the rtl28xxu.c driver.
>>
>> Signed-off-by: Brian Healy <healybrian <at> gmail.com>
>>
>>
>> > Brian, please use
>> >
>> >  ./scripts/get_maintainer -f drivers/media/usb/dvb-usb-v2/rtl28xxu.c
>> >
>> > to get the proper people to send this to, so that it doesn't get lost
>> > in the flood in lkml.
>> >
>> > The indentation of that new entry also seems to be suspect, in that it
>> > doesn't match the ones around it.
>> >
>> > Quoting full email for context for people added.
>> >
>> >              Linus
>> >
>>
>> diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
>> index 61d196e..b6e20cc 100644
>> --- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
>> +++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
>> @@ -1499,6 +1499,8 @@ static const struct usb_device_id rtl28xxu_id_table[] = {
>>               &rtl2832u_props, "Crypto ReDi PC 50 A", NULL) },
>>       { DVB_USB_DEVICE(USB_VID_KYE, 0x707f,
>>               &rtl2832u_props, "Genius TVGo DVB-T03", NULL) },
>> +        { DVB_USB_DEVICE(USB_VID_KWORLD_2, 0xd395,
>> +                &rtl2832u_props, "Peak DVB-T USB", NULL) },
>
> Patch is still a little odd, as you're using spaces for indenting, instead of
> tabs, but I can fix it with my scripts. Next time, please use tabs.
>
> Also, specifically in the case of patches for linux-media, you don't need
> to c/c me. Just send the patch to linux-media and to the driver maintainer
> (Antti, in this case).
>
> My workflow is to pick the patches from patchwork:
>         https://patchwork.linuxtv.org/patch/23792/
> after receiving Antti's ack.
>
> Alternatively, Antti may opt to put it on his git tree, sending it to me
> latter together of other patches he may have for the devices he maintains.
>
>>
>>       /* RTL2832P devices: */
>>       { DVB_USB_DEVICE(USB_VID_HANFTEK, 0x0131,
>
> Thanks,
> Mauro