From: Bjorn Helgaas <bhelgaas@google.com>
To: Gioh Kim <gioh.kim@lge.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
gunho.lee@lge.com
Subject: Re: [PATCH] Documentation/dma-buf-sharing.txt: update API descriptions
Date: Tue, 20 May 2014 17:20:16 -0600 [thread overview]
Message-ID: <20140520232016.GB24638@google.com> (raw)
In-Reply-To: <1400024983-21891-1-git-send-email-gioh.kim@lge.com>
On Wed, May 14, 2014 at 08:49:43AM +0900, Gioh Kim wrote:
> Update some descriptions for API arguments and descriptions.
>
> Signed-off-by: Gioh Kim <gioh.kim@lge.com>
I applied this to my "dma-api" branch for v3.16, thanks!
> ---
> Documentation/dma-buf-sharing.txt | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/dma-buf-sharing.txt b/Documentation/dma-buf-sharing.txt
> index 505e711..aadd901 100644
> --- a/Documentation/dma-buf-sharing.txt
> +++ b/Documentation/dma-buf-sharing.txt
> @@ -56,10 +56,10 @@ The dma_buf buffer sharing API usage contains the following steps:
> size_t size, int flags,
> const char *exp_name)
>
> - If this succeeds, dma_buf_export allocates a dma_buf structure, and returns a
> - pointer to the same. It also associates an anonymous file with this buffer,
> - so it can be exported. On failure to allocate the dma_buf object, it returns
> - NULL.
> + If this succeeds, dma_buf_export_named allocates a dma_buf structure, and
> + returns a pointer to the same. It also associates an anonymous file with this
> + buffer, so it can be exported. On failure to allocate the dma_buf object,
> + it returns NULL.
>
> 'exp_name' is the name of exporter - to facilitate information while
> debugging.
> @@ -76,7 +76,7 @@ The dma_buf buffer sharing API usage contains the following steps:
> drivers and/or processes.
>
> Interface:
> - int dma_buf_fd(struct dma_buf *dmabuf)
> + int dma_buf_fd(struct dma_buf *dmabuf, int flags)
>
> This API installs an fd for the anonymous file associated with this buffer;
> returns either 'fd', or error.
> @@ -157,7 +157,9 @@ to request use of buffer for allocation.
> "dma_buf->ops->" indirection from the users of this interface.
>
> In struct dma_buf_ops, unmap_dma_buf is defined as
> - void (*unmap_dma_buf)(struct dma_buf_attachment *, struct sg_table *);
> + void (*unmap_dma_buf)(struct dma_buf_attachment *,
> + struct sg_table *,
> + enum dma_data_direction);
>
> unmap_dma_buf signifies the end-of-DMA for the attachment provided. Like
> map_dma_buf, this API also must be implemented by the exporter.
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2014-05-20 23:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 23:49 [PATCH] Documentation/dma-buf-sharing.txt: update API descriptions Gioh Kim
2014-05-20 23:20 ` Bjorn Helgaas [this message]
2014-05-21 3:43 ` Sumit Semwal
2014-05-21 4:39 ` Bjorn Helgaas
-- strict thread matches above, loose matches on Subject: below --
2014-05-12 11:48 gioh.kim
2014-05-13 8:44 ` Thierry Reding
2014-05-13 23:53 ` Gioh Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520232016.GB24638@google.com \
--to=bhelgaas@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gioh.kim@lge.com \
--cc=gunho.lee@lge.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox