public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ovidiu Toader <ovi@phas.ubc.ca>
Cc: Antti Palosaari <crope@iki.fi>,
	Mauro Carvalho Chehab <m.chehab@samsung.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-media@vger.kernel.org
Subject: Re: [PATCH] staging/media/rtl2832u_sdr: fix coding style problems
Date: Mon, 2 Jun 2014 13:21:59 +0300	[thread overview]
Message-ID: <20140602102158.GX15585@mwanda> (raw)
In-Reply-To: <538B8651.6020801@phas.ubc.ca>

On Sun, Jun 01, 2014 at 01:00:17PM -0700, Ovidiu Toader wrote:
> motivation: eudyptula challenge
> 
> This minor patch fixes all WARNING:SPACING style warnings in rtl2832_sdr.c
> 
> The new version of the file pleases checkpatch.pl when run with
> "--ignore LONG_LINE".
> 

> Signed-off-by: Ovidiu Toader <ovi@phas.ubc.ca>

Send the patch inline, not as an attachment.

Read the first paragraph.
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/email-clients.txt

The subject should say something about adding blank lines.

regards,
dan carpenter


  reply	other threads:[~2014-06-02 10:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-01 20:00 [PATCH] staging/media/rtl2832u_sdr: fix coding style problems Ovidiu Toader
2014-06-02 10:21 ` Dan Carpenter [this message]
2014-06-02 19:50   ` [PATCH] staging/media/rtl2832u_sdr: fix coding style problems by adding blank lines Ovidiu Toader
2014-06-02 21:33     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140602102158.GX15585@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=crope@iki.fi \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=ovi@phas.ubc.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox