From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ovidiu Toader <ovi@phas.ubc.ca>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Antti Palosaari <crope@iki.fi>,
linux-media@vger.kernel.org,
Mauro Carvalho Chehab <m.chehab@samsung.com>
Subject: Re: [PATCH] staging/media/rtl2832u_sdr: fix coding style problems by adding blank lines
Date: Tue, 3 Jun 2014 00:33:01 +0300 [thread overview]
Message-ID: <20140602200316.GB15585@mwanda> (raw)
In-Reply-To: <538CD58B.4030603@phas.ubc.ca>
On Mon, Jun 02, 2014 at 12:50:35PM -0700, Ovidiu Toader wrote:
> On 06/02/14 03:21, Dan Carpenter wrote:
> > Send the patch inline, not as an attachment.
> >
> > Read the first paragraph.
> > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/email-clients.txt
> >
> > The subject should say something about adding blank lines.
> Thanks for the feedback and sorry for the inconvenience.
> Take 2:
>
> This minor patch fixes all WARNING:SPACING style warnings in rtl2832_sdr.c
>
> The new version of the file pleases checkpatch.pl when run with "--ignore LONG_LINE".
>
Better but not quite right. You understand that the email *is* the
changelog? So now it has our conversation saved in the changelog for
all time.
https://www.google.com/search?q=how+to+send+a+v2+patch
regards,
dan carpenter
prev parent reply other threads:[~2014-06-02 21:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 20:00 [PATCH] staging/media/rtl2832u_sdr: fix coding style problems Ovidiu Toader
2014-06-02 10:21 ` Dan Carpenter
2014-06-02 19:50 ` [PATCH] staging/media/rtl2832u_sdr: fix coding style problems by adding blank lines Ovidiu Toader
2014-06-02 21:33 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602200316.GB15585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=crope@iki.fi \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=ovi@phas.ubc.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).