From: "David Härdeman" <david@hardeman.nu>
To: Niels Laukens <niels@dest-unreach.be>
Cc: "Mauro Carvalho Chehab" <m.chehab@samsung.com>,
linux-media@vger.kernel.org,
"James Hogan" <james.hogan@imgtec.com>,
"Antti Seppälä" <a.seppala@gmail.com>
Subject: Re: [PATCH 1/2] drivers/media/rc/ir-nec-decode : add toggle feature
Date: Thu, 19 Jun 2014 11:05:40 +0200 [thread overview]
Message-ID: <20140619090540.GC13952@hardeman.nu> (raw)
In-Reply-To: <53A29E79.2000304@dest-unreach.be>
On Thu, Jun 19, 2014 at 10:25:29AM +0200, Niels Laukens wrote:
>Made the distinction between repeated key presses, and a single long
>press. The NEC-protocol does not have a toggle-bit (cfr RC5/RC6), but
>has specific repeat-codes.
Not all NEC remotes use repeat codes. Some just transmit the full code
at fixed intervals...IIRC, Pioneer remotes is (was?) one example...
>This patch identifies a repeat code, and skips the scancode calculations
>and the rc_keydown() in that case. In the case of a full code, it makes
>sure that the rc_keydown() is regarded as a new event by using the
>toggle feature.
next prev parent reply other threads:[~2014-06-19 9:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 8:24 [PATCH 0/2] drivers/media/rc/ir-nec-decode : add toggle feature Niels Laukens
2014-06-19 8:25 ` [PATCH 1/2] " Niels Laukens
2014-06-19 9:05 ` David Härdeman [this message]
2014-06-19 11:59 ` Niels Laukens
2014-07-26 15:47 ` Mauro Carvalho Chehab
2014-07-26 16:58 ` Niels Laukens
2014-06-19 8:25 ` [PATCH 2/2] drivers/media/rc/ir-nec-decode : add toggle feature (2/2) Niels Laukens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619090540.GC13952@hardeman.nu \
--to=david@hardeman.nu \
--cc=a.seppala@gmail.com \
--cc=james.hogan@imgtec.com \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=niels@dest-unreach.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox