linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Morgan Phillips <winter2718@gmail.com>
Cc: brijohn@gmail.com, hdegoede@redhat.com, m.chehab@samsung.com,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	wolfram@the-dreams.de
Subject: Re: [PATCH] [media]: sn9c20x.c: fix checkpatch error: that open brace { should be on the previous line
Date: Mon, 8 Sep 2014 19:18:28 +0530	[thread overview]
Message-ID: <20140908134828.GA7617@sudip-PC> (raw)
In-Reply-To: <1410179542-3272-1-git-send-email-winter2718@gmail.com>

On Mon, Sep 08, 2014 at 07:32:22AM -0500, Morgan Phillips wrote:
> Signed-off-by: Morgan Phillips <winter2718@gmail.com>

no commit message ?

thanks
sudip

> ---
>  drivers/media/usb/gspca/sn9c20x.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/usb/gspca/sn9c20x.c b/drivers/media/usb/gspca/sn9c20x.c
> index 41a9a89..95467f0 100644
> --- a/drivers/media/usb/gspca/sn9c20x.c
> +++ b/drivers/media/usb/gspca/sn9c20x.c
> @@ -1787,8 +1787,9 @@ static int sd_init(struct gspca_dev *gspca_dev)
>  	struct sd *sd = (struct sd *) gspca_dev;
>  	int i;
>  	u8 value;
> -	u8 i2c_init[9] =
> -		{0x80, sd->i2c_addr, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x03};
> +	u8 i2c_init[9] = {
> +		0x80, sd->i2c_addr, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x03
> +	};
>  
>  	for (i = 0; i < ARRAY_SIZE(bridge_init); i++) {
>  		value = bridge_init[i][1];
> @@ -2242,8 +2243,9 @@ static void sd_pkt_scan(struct gspca_dev *gspca_dev,
>  {
>  	struct sd *sd = (struct sd *) gspca_dev;
>  	int avg_lum, is_jpeg;
> -	static const u8 frame_header[] =
> -		{0xff, 0xff, 0x00, 0xc4, 0xc4, 0x96};
> +	static const u8 frame_header[] = {
> +		0xff, 0xff, 0x00, 0xc4, 0xc4, 0x96
> +	};
>  
>  	is_jpeg = (sd->fmt & 0x03) == 0;
>  	if (len >= 64 && memcmp(data, frame_header, 6) == 0) {
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

  reply	other threads:[~2014-09-08 13:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-08 12:32 [PATCH] [media]: sn9c20x.c: fix checkpatch error: that open brace { should be on the previous line Morgan Phillips
2014-09-08 13:48 ` Sudip Mukherjee [this message]
     [not found]   ` <CAGztXF1YXAMJhCrO_AmH115DX7NFfNmXzVefUBnVH2H9vkxNYg@mail.gmail.com>
2014-09-08 14:22     ` Sudip Mukherjee
2014-09-08 14:55 ` [PATCH v2] " Morgan Phillips
2014-09-08 15:18   ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140908134828.GA7617@sudip-PC \
    --to=sudipm.mukherjee@gmail.com \
    --cc=brijohn@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=winter2718@gmail.com \
    --cc=wolfram@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).