From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 0/4] vb2/saa7134 regression/documentation fixes
Date: Thu, 18 Sep 2014 09:55:22 -0300 [thread overview]
Message-ID: <20140918095522.17ac0dc7@recife.lan> (raw)
In-Reply-To: <1410945272-48149-1-git-send-email-hverkuil@xs4all.nl>
Em Wed, 17 Sep 2014 11:14:28 +0200
Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> This fixes the VBI regression seen in saa7134 when it was converted
> to vb2. Tested with my saa7134 board.
>
> It also updates the poll documentation and fixes a saa7134 bug where
> the WSS signal was never captured.
>
> The first patch should go to 3.17. It won't apply to older kernels,
> so I guess once this is merged we should post a patch to stable for
> those older kernels, certainly 3.16.
>
> I would expect this to be an issue for em28xx as well, but I will
> need to test that. If that driver is affected as well, then this
> fix needs to go into 3.9 and up.
For now:
Nacked-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Changing the V4L2 API is *not* the right way to fix a regression.
Also, this changes a behavior that it is there since 2.6.24.
We can't do that, except if you're sure that no userspace applications
rely on the old behavior, with seems unlikely.
>
> Regards,
>
> Hans
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-09-18 12:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 9:14 [PATCH 0/4] vb2/saa7134 regression/documentation fixes Hans Verkuil
2014-09-17 9:14 ` [PATCH 1/4] vb2: fix VBI regression Hans Verkuil
2014-09-17 9:14 ` [PATCH 2/4] DocBook media: fix poll specification Hans Verkuil
2014-09-17 9:14 ` [PATCH 3/4] DocBook media: update poll() documentation Hans Verkuil
2014-09-17 9:14 ` [PATCH 4/4] saa7134: also capture the WSS signal for 50 Hz VBI capture Hans Verkuil
2014-09-17 16:06 ` [PATCH 0/4] vb2/saa7134 regression/documentation fixes Hans Verkuil
2014-09-18 16:21 ` Mauro Carvalho Chehab
2014-09-18 16:26 ` Hans Verkuil
2014-09-18 12:55 ` Mauro Carvalho Chehab [this message]
2014-09-18 13:28 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140918095522.17ac0dc7@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).