From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH 0/3] vb2: fix VBI/poll regression
Date: Sat, 20 Sep 2014 06:51:44 -0300 [thread overview]
Message-ID: <20140920065144.0c69e575@recife.lan> (raw)
In-Reply-To: <1411203375-15310-1-git-send-email-hverkuil@xs4all.nl>
Em Sat, 20 Sep 2014 10:56:12 +0200
Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> OK, this is the final (?) patch series to resolve the vb2 VBI poll regression
> where alevt and mtt fail on drivers using vb2.
>
> These applications call REQBUFS, queue the buffers and then poll() without
> calling STREAMON first. They rely on poll() to return POLLERR in that case
> and they do the STREAMON at that time. This is correct according to the spec,
> but this was never implemented in vb2.
>
> This is fixed together with an other vb2 regression: calling REQBUFS, then
> STREAMON, then poll() without doing a QBUF first should return POLLERR as
> well according to the spec. This has been fixed as well and the spec has
> been clarified that this is only done for capture queues. Output queues in
> the same situation will return as well, but with POLLOUT|POLLWRNORM set
> instead of POLLERR.
>
> The final patch adds missing documentation to poll() regarding event handling
> and improves the documentation regarding stream I/O and output queues.
Didn't test yet, but the patch series look ok on my eyes.
I'll do some tests today.
Regards,
Mauro
prev parent reply other threads:[~2014-09-20 9:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 8:56 [PATCH 0/3] vb2: fix VBI/poll regression Hans Verkuil
2014-09-20 8:56 ` [PATCH 1/3] " Hans Verkuil
2014-09-20 9:08 ` James Harper
2014-09-20 9:14 ` Hans Verkuil
2014-09-20 10:04 ` Mauro Carvalho Chehab
2014-09-20 10:08 ` Mauro Carvalho Chehab
2014-09-20 10:14 ` Mauro Carvalho Chehab
2014-09-20 18:32 ` Laurent Pinchart
2014-09-20 19:12 ` Hans Verkuil
2014-09-20 8:56 ` [PATCH 2/3] DocBook media: fix the poll() 'no QBUF' documentation Hans Verkuil
2014-09-20 18:35 ` Laurent Pinchart
2014-09-20 8:56 ` [PATCH 3/3] DocBook media: improve the poll() documentation Hans Verkuil
2014-09-20 9:51 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140920065144.0c69e575@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).