From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Maxime Coquelin <maxime.coquelin@st.com>,
Patrice Chotard <patrice.chotard@st.com>,
linux-arm-kernel@lists.infradead.org, kernel@stlinux.com,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] media:st-rc: Misc fixes.
Date: Mon, 22 Sep 2014 19:39:56 -0300 [thread overview]
Message-ID: <20140922193956.6e445cd9@recife.lan> (raw)
In-Reply-To: <1411424501-12673-1-git-send-email-srinivas.kandagatla@linaro.org>
Em Mon, 22 Sep 2014 23:21:41 +0100
Srinivas Kandagatla <srinivas.kandagatla@linaro.org> escreveu:
> Hi Mauro,
>
> Thankyou for the "[media] enable COMPILE_TEST for media drivers" patch
> which picked up few things in st-rc driver in linux-next testing.
Anytime. Yeah, the idea is to let more people to test and check for
hidden issues there.
>
> Here is a few minor fixes to the driver, could you consider them for
> the next merge window.
Applied, thanks!
Btw, there are still lots of warnings there produced with smatch:
$ make ARCH=i386 C=1 CF=-D__CHECK_ENDIAN__ CONFIG_DEBUG_SECTION_MISMATCH=y W=1 CF=-D__CHECK_ENDIAN__ M=drivers/media
drivers/media/rc/st_rc.c:107:38: warning: incorrect type in argument 1 (different address spaces)
drivers/media/rc/st_rc.c:107:38: expected void const volatile [noderef] <asn:2>*addr
drivers/media/rc/st_rc.c:107:38: got void *
drivers/media/rc/st_rc.c:110:53: warning: incorrect type in argument 1 (different address spaces)
drivers/media/rc/st_rc.c:110:53: expected void const volatile [noderef] <asn:2>*addr
drivers/media/rc/st_rc.c:110:53: got void *
drivers/media/rc/st_rc.c:116:54: warning: incorrect type in argument 2 (different address spaces)
drivers/media/rc/st_rc.c:116:54: expected void volatile [noderef] <asn:2>*addr
drivers/media/rc/st_rc.c:116:54: got void *
drivers/media/rc/st_rc.c:120:45: warning: incorrect type in argument 1 (different address spaces)
drivers/media/rc/st_rc.c:120:45: expected void const volatile [noderef] <asn:2>*addr
drivers/media/rc/st_rc.c:120:45: got void *
drivers/media/rc/st_rc.c:121:43: warning: incorrect type in argument 1 (different address spaces)
drivers/media/rc/st_rc.c:121:43: expected void const volatile [noderef] <asn:2>*addr
drivers/media/rc/st_rc.c:121:43: got void *
drivers/media/rc/st_rc.c:150:46: warning: incorrect type in argument 1 (different address spaces)
drivers/media/rc/st_rc.c:150:46: expected void const volatile [noderef] <asn:2>*addr
drivers/media/rc/st_rc.c:150:46: got void *
drivers/media/rc/st_rc.c:153:42: warning: incorrect type in argument 2 (different address spaces)
drivers/media/rc/st_rc.c:153:42: expected void volatile [noderef] <asn:2>*addr
drivers/media/rc/st_rc.c:153:42: got void *
drivers/media/rc/st_rc.c:174:32: warning: incorrect type in argument 2 (different address spaces)
drivers/media/rc/st_rc.c:174:32: expected void volatile [noderef] <asn:2>*addr
drivers/media/rc/st_rc.c:174:32: got void *
drivers/media/rc/st_rc.c:177:48: warning: incorrect type in argument 2 (different address spaces)
drivers/media/rc/st_rc.c:177:48: expected void volatile [noderef] <asn:2>*addr
drivers/media/rc/st_rc.c:177:48: got void *
drivers/media/rc/st_rc.c:187:48: warning: incorrect type in argument 2 (different address spaces)
drivers/media/rc/st_rc.c:187:48: expected void volatile [noderef] <asn:2>*addr
drivers/media/rc/st_rc.c:187:48: got void *
drivers/media/rc/st_rc.c:204:42: warning: incorrect type in argument 2 (different address spaces)
drivers/media/rc/st_rc.c:204:42: expected void volatile [noderef] <asn:2>*addr
drivers/media/rc/st_rc.c:204:42: got void *
drivers/media/rc/st_rc.c:205:35: warning: incorrect type in argument 2 (different address spaces)
drivers/media/rc/st_rc.c:205:35: expected void volatile [noderef] <asn:2>*addr
drivers/media/rc/st_rc.c:205:35: got void *
drivers/media/rc/st_rc.c:215:35: warning: incorrect type in argument 2 (different address spaces)
drivers/media/rc/st_rc.c:215:35: expected void volatile [noderef] <asn:2>*addr
drivers/media/rc/st_rc.c:215:35: got void *
drivers/media/rc/st_rc.c:216:35: warning: incorrect type in argument 2 (different address spaces)
drivers/media/rc/st_rc.c:216:35: expected void volatile [noderef] <asn:2>*addr
drivers/media/rc/st_rc.c:216:35: got void *
drivers/media/rc/st_rc.c:269:22: warning: incorrect type in assignment (different address spaces)
drivers/media/rc/st_rc.c:269:22: expected void *base
drivers/media/rc/st_rc.c:269:22: got void [noderef] <asn:2>*
drivers/media/rc/st_rc.c:349:46: warning: incorrect type in argument 2 (different address spaces)
drivers/media/rc/st_rc.c:349:46: expected void volatile [noderef] <asn:2>*addr
drivers/media/rc/st_rc.c:349:46: got void *
drivers/media/rc/st_rc.c:350:46: warning: incorrect type in argument 2 (different address spaces)
drivers/media/rc/st_rc.c:350:46: expected void volatile [noderef] <asn:2>*addr
drivers/media/rc/st_rc.c:350:46: got void *
drivers/media/rc/st_rc.c:371:61: warning: incorrect type in argument 2 (different address spaces)
drivers/media/rc/st_rc.c:371:61: expected void volatile [noderef] <asn:2>*addr
drivers/media/rc/st_rc.c:371:61: got void *
drivers/media/rc/st_rc.c:372:54: warning: incorrect type in argument 2 (different address spaces)
drivers/media/rc/st_rc.c:372:54: expected void volatile [noderef] <asn:2>*addr
drivers/media/rc/st_rc.c:372:54: got void *
Regards,
Mauro
next prev parent reply other threads:[~2014-09-22 22:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 22:21 [PATCH 0/3] media:st-rc: Misc fixes Srinivas Kandagatla
2014-09-22 22:22 ` [PATCH 1/3] media: st-rc: move to using reset_control_get_optional Srinivas Kandagatla
2014-09-23 18:02 ` [STLinux Kernel] " Peter Griffin
2014-09-24 8:12 ` Srinivas Kandagatla
2014-09-24 8:37 ` Maxime Coquelin
2014-10-24 8:11 ` Peter Griffin
2014-09-22 22:22 ` [PATCH 2/3] media: st-rc: move pm ops setup out of conditional compilation Srinivas Kandagatla
2014-09-22 22:22 ` [PATCH 3/3] media: st-rc: Remove .owner field for driver Srinivas Kandagatla
2014-09-23 18:05 ` [STLinux Kernel] " Peter Griffin
2014-09-22 22:39 ` Mauro Carvalho Chehab [this message]
2014-09-23 7:27 ` [PATCH 0/3] media:st-rc: Misc fixes Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922193956.6e445cd9@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=kernel@stlinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maxime.coquelin@st.com \
--cc=patrice.chotard@st.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).