From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Matthias Schwarzott <zzam@gentoo.org>
Cc: linux-media@vger.kernel.org, crope@iki.fi
Subject: Re: [PATCH 7/7] si2165: do load firmware without extra header
Date: Mon, 22 Sep 2014 19:58:13 -0300 [thread overview]
Message-ID: <20140922195813.4cec3704@recife.lan> (raw)
In-Reply-To: <1409484912-19300-8-git-send-email-zzam@gentoo.org>
Em Sun, 31 Aug 2014 13:35:12 +0200
Matthias Schwarzott <zzam@gentoo.org> escreveu:
> The new file has a different name: dvb-demod-si2165-D.fw
>
> Count blocks instead of reading count from extra header.
> Calculate CRC during upload and compare result to what chip calcuated.
> Use 0x01 instead of real patch version, because this is only used to
> check if something was uploaded but not to check the version of it.
>
> Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
> ---
...
> diff --git a/drivers/media/dvb-frontends/si2165_priv.h b/drivers/media/dvb-frontends/si2165_priv.h
> index 2b70cf1..fd778dc 100644
> --- a/drivers/media/dvb-frontends/si2165_priv.h
> +++ b/drivers/media/dvb-frontends/si2165_priv.h
> @@ -18,6 +18,6 @@
> #ifndef _DVB_SI2165_PRIV
> #define _DVB_SI2165_PRIV
>
> -#define SI2165_FIRMWARE_REV_D "dvb-demod-si2165.fw"
> +#define SI2165_FIRMWARE_REV_D "dvb-demod-si2165-D.fw"
Please, don't do that. Changing the name of the firmware and breaking
the format is a bad idea, specially since you're not supporting anymore
the legacy one.
I would be ok if you were not breaking support for the old firmware
file.
Also, better to use lowercase for the firmware name.
PS.: I'm not applying patch 6/7 as this got rejected.
Regards,
Mauro
next prev parent reply other threads:[~2014-09-22 22:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-31 11:35 [PATCH 0/7] Add support for Si2161 demod and improve firmware handling Matthias Schwarzott
2014-08-31 11:35 ` [PATCH 1/7] si2165: Load driver for all hardware revisions Matthias Schwarzott
2014-08-31 11:35 ` [PATCH 2/7] si2165: enable Si2161 support Matthias Schwarzott
2014-08-31 11:35 ` [PATCH 3/7] [media] cx231xx: Add support for Hauppauge WinTV-HVR-900H (111xxx) Matthias Schwarzott
2014-08-31 11:35 ` [PATCH 4/7] [media] cx231xx: Add support for Hauppauge WinTV-HVR-901H (1114xx) Matthias Schwarzott
2014-08-31 11:35 ` [PATCH 5/7] [media] mceusb: add support for more cx231xx devices Matthias Schwarzott
2014-08-31 11:35 ` [PATCH 6/7] get_dvb_firmware: si2165: drop the extra header from the firmware Matthias Schwarzott
2014-08-31 11:35 ` [PATCH 7/7] si2165: do load firmware without extra header Matthias Schwarzott
2014-09-22 22:58 ` Mauro Carvalho Chehab [this message]
2014-09-23 4:54 ` Matthias Schwarzott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922195813.4cec3704@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=zzam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).