Re: linux-next: Tree for Sep 26 (media/pci/pt3)

Re: linux-next: Tree for Sep 26 (media/pci/pt3)

[Randy Dunlap]

On 09/26/14 04:10, Stephen Rothwell wrote:
> Hi all,
> 
> There will be no linux-next release on Monday.
> 
> This has not been a good day :-(
> 
> Changes since 20140925:


on x86_64:
when CONFIG_MODULES is not enabled:

../drivers/media/pci/pt3/pt3.c: In function 'pt3_attach_fe':
../drivers/media/pci/pt3/pt3.c:433:6: error: implicit declaration of function 'module_is_live' [-Werror=implicit-function-declaration]



-- 
~Randy

Re: linux-next: Tree for Sep 26 (media/pci/pt3)

[Mauro Carvalho Chehab]

Em Fri, 26 Sep 2014 10:01:47 -0700
Randy Dunlap <rdunlap@infradead.org> escreveu:

> On 09/26/14 04:10, Stephen Rothwell wrote:
> > Hi all,
> > 
> > There will be no linux-next release on Monday.
> > 
> > This has not been a good day :-(
> > 
> > Changes since 20140925:
> 
> 
> on x86_64:
> when CONFIG_MODULES is not enabled:
> 
> ../drivers/media/pci/pt3/pt3.c: In function 'pt3_attach_fe':
> ../drivers/media/pci/pt3/pt3.c:433:6: error: implicit declaration of function 'module_is_live' [-Werror=implicit-function-declaration]


:(

I didn't notice that weird I2C attach code on this driver.

Akihiro, could you please fix it? The entire I2C attach code at
pt3_attach looks weird. We should soon add support for the I2C
tuner attach code for all DVB drivers on a common place, just like
what we do for V4L drivers. That's why I didn't spend much time on
that piece of the code.

Yet, while we don't have it, please take a look at 
drivers/media/v4l2-core/v4l2-device.c and do (almost) the same on
your driver, if possible, putting the I2C load module on a function.
That will make easier for us to replace such function when we'll add 
core support for it. The function at v4l2-device for you to take
a look is: v4l2_device_register_subdev().

Thank you,
Mauro