[PATCH 1/3] xc5000: tuner firmware update

[PATCH 1/3] xc5000: tuner firmware update

[Michael Krufky]

From: Richard Vollkommer <linux@hauppauge.com>

- Update the xc5000 tuner firmware to version 1.6.821

- Update the xc5000c tuner firmware to version 4.1.33

Firmware files can be downloaded from:

- http://hauppauge.lightpath.net/software/hvr950q/xc5000c-4.1.33.zip
- http://hauppauge.lightpath.net/software/hvr950q/xc5000-1.6.821.zip

Signed-off-by: Richard Vollkommer <linux@hauppauge.com>
Cc: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Michael Ira Krufky <mkrufky@linuxtv.org>
---
 drivers/media/tuners/xc5000.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/media/tuners/xc5000.c b/drivers/media/tuners/xc5000.c
index e44c8ab..fafff4c 100644
--- a/drivers/media/tuners/xc5000.c
+++ b/drivers/media/tuners/xc5000.c
@@ -222,15 +222,15 @@ struct xc5000_fw_cfg {
 	u8 fw_checksum_supported;
 };
 
-#define XC5000A_FIRMWARE "dvb-fe-xc5000-1.6.114.fw"
-static const struct xc5000_fw_cfg xc5000a_1_6_114 = {
+#define XC5000A_FIRMWARE "dvb-fe-xc5000-1.6.821.fw"
+static const struct xc5000_fw_cfg xc5000a_fw_cfg = {
 	.name = XC5000A_FIRMWARE,
 	.size = 12401,
-	.pll_reg = 0x806c,
+	.pll_reg = 0x8067,
 };
 
-#define XC5000C_FIRMWARE "dvb-fe-xc5000c-4.1.30.7.fw"
-static const struct xc5000_fw_cfg xc5000c_41_024_5 = {
+#define XC5000C_FIRMWARE "dvb-fe-xc5000c-4.1.33.fw"
+static const struct xc5000_fw_cfg xc5000c_fw_cfg = {
 	.name = XC5000C_FIRMWARE,
 	.size = 16497,
 	.pll_reg = 0x13,
@@ -243,9 +243,9 @@ static inline const struct xc5000_fw_cfg *xc5000_assign_firmware(int chip_id)
 	switch (chip_id) {
 	default:
 	case XC5000A:
-		return &xc5000a_1_6_114;
+		return &xc5000a_fw_cfg;
 	case XC5000C:
-		return &xc5000c_41_024_5;
+		return &xc5000c_fw_cfg;
 	}
 }
 
-- 
1.9.1

Re: [PATCH 1/3] xc5000: tuner firmware update

[Mauro Carvalho Chehab]

Em Sat, 25 Oct 2014 16:17:21 -0400
Michael Krufky <mkrufky@hotmail.com> escreveu:

> From: Richard Vollkommer <linux@hauppauge.com>
> 
> - Update the xc5000 tuner firmware to version 1.6.821
> 
> - Update the xc5000c tuner firmware to version 4.1.33
> 
> Firmware files can be downloaded from:
> 
> - http://hauppauge.lightpath.net/software/hvr950q/xc5000c-4.1.33.zip
> - http://hauppauge.lightpath.net/software/hvr950q/xc5000-1.6.821.zip
> 
> Signed-off-by: Richard Vollkommer <linux@hauppauge.com>
> Cc: Devin Heitmueller <dheitmueller@kernellabs.com>
> Signed-off-by: Michael Ira Krufky <mkrufky@linuxtv.org>

Hi Michael,

Please use a logic that would allow the old firmware files to allow
falling back to the previous firmware version if the new one is not
available.

Regards,
Mauro

> ---
>  drivers/media/tuners/xc5000.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/media/tuners/xc5000.c b/drivers/media/tuners/xc5000.c
> index e44c8ab..fafff4c 100644
> --- a/drivers/media/tuners/xc5000.c
> +++ b/drivers/media/tuners/xc5000.c
> @@ -222,15 +222,15 @@ struct xc5000_fw_cfg {
>  	u8 fw_checksum_supported;
>  };
>  
> -#define XC5000A_FIRMWARE "dvb-fe-xc5000-1.6.114.fw"
> -static const struct xc5000_fw_cfg xc5000a_1_6_114 = {
> +#define XC5000A_FIRMWARE "dvb-fe-xc5000-1.6.821.fw"
> +static const struct xc5000_fw_cfg xc5000a_fw_cfg = {
>  	.name = XC5000A_FIRMWARE,
>  	.size = 12401,
> -	.pll_reg = 0x806c,
> +	.pll_reg = 0x8067,
>  };
>  
> -#define XC5000C_FIRMWARE "dvb-fe-xc5000c-4.1.30.7.fw"
> -static const struct xc5000_fw_cfg xc5000c_41_024_5 = {
> +#define XC5000C_FIRMWARE "dvb-fe-xc5000c-4.1.33.fw"
> +static const struct xc5000_fw_cfg xc5000c_fw_cfg = {
>  	.name = XC5000C_FIRMWARE,
>  	.size = 16497,
>  	.pll_reg = 0x13,
> @@ -243,9 +243,9 @@ static inline const struct xc5000_fw_cfg *xc5000_assign_firmware(int chip_id)
>  	switch (chip_id) {
>  	default:
>  	case XC5000A:
> -		return &xc5000a_1_6_114;
> +		return &xc5000a_fw_cfg;
>  	case XC5000C:
> -		return &xc5000c_41_024_5;
> +		return &xc5000c_fw_cfg;
>  	}
>  }
>  

Re: [PATCH 1/3] xc5000: tuner firmware update

[Michael Ira Krufky]

On Mon, Oct 27, 2014 at 7:46 AM, Mauro Carvalho Chehab
<m.chehab@samsung.com> wrote:
> Em Sat, 25 Oct 2014 16:17:21 -0400
> Michael Krufky <mkrufky@hotmail.com> escreveu:
>
>> From: Richard Vollkommer <linux@hauppauge.com>
>>
>> - Update the xc5000 tuner firmware to version 1.6.821
>>
>> - Update the xc5000c tuner firmware to version 4.1.33
>>
>> Firmware files can be downloaded from:
>>
>> - http://hauppauge.lightpath.net/software/hvr950q/xc5000c-4.1.33.zip
>> - http://hauppauge.lightpath.net/software/hvr950q/xc5000-1.6.821.zip
>>
>> Signed-off-by: Richard Vollkommer <linux@hauppauge.com>
>> Cc: Devin Heitmueller <dheitmueller@kernellabs.com>
>> Signed-off-by: Michael Ira Krufky <mkrufky@linuxtv.org>
>
> Hi Michael,
>
> Please use a logic that would allow the old firmware files to allow
> falling back to the previous firmware version if the new one is not
> available.
>
> Regards,
> Mauro
>
>> ---
>>  drivers/media/tuners/xc5000.c | 14 +++++++-------
>>  1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/media/tuners/xc5000.c b/drivers/media/tuners/xc5000.c
>> index e44c8ab..fafff4c 100644
>> --- a/drivers/media/tuners/xc5000.c
>> +++ b/drivers/media/tuners/xc5000.c
>> @@ -222,15 +222,15 @@ struct xc5000_fw_cfg {
>>       u8 fw_checksum_supported;
>>  };
>>
>> -#define XC5000A_FIRMWARE "dvb-fe-xc5000-1.6.114.fw"
>> -static const struct xc5000_fw_cfg xc5000a_1_6_114 = {
>> +#define XC5000A_FIRMWARE "dvb-fe-xc5000-1.6.821.fw"
>> +static const struct xc5000_fw_cfg xc5000a_fw_cfg = {
>>       .name = XC5000A_FIRMWARE,
>>       .size = 12401,
>> -     .pll_reg = 0x806c,
>> +     .pll_reg = 0x8067,
>>  };
>>
>> -#define XC5000C_FIRMWARE "dvb-fe-xc5000c-4.1.30.7.fw"
>> -static const struct xc5000_fw_cfg xc5000c_41_024_5 = {
>> +#define XC5000C_FIRMWARE "dvb-fe-xc5000c-4.1.33.fw"
>> +static const struct xc5000_fw_cfg xc5000c_fw_cfg = {
>>       .name = XC5000C_FIRMWARE,
>>       .size = 16497,
>>       .pll_reg = 0x13,
>> @@ -243,9 +243,9 @@ static inline const struct xc5000_fw_cfg *xc5000_assign_firmware(int chip_id)
>>       switch (chip_id) {
>>       default:
>>       case XC5000A:
>> -             return &xc5000a_1_6_114;
>> +             return &xc5000a_fw_cfg;
>>       case XC5000C:
>> -             return &xc5000c_41_024_5;
>> +             return &xc5000c_fw_cfg;
>>       }
>>  }
>>


Mauro,

I like the idea of supporting older firmware revisions if the new one
is not present, but, the established president for this sort of thing
has always been to replace older firmware with newer firmware without
backward compatibility support for older binaries.

Although the current driver can work with both old and new firmware
versions, this hasn't been the case in the past, and won't always be
the case with future firmware revisions.

Hauppauge has provided links to the new firmware for both the XC5000
and XC5000C chips along with licensing.  Maybe instead, we can just
upstream those into the linux-firmware packages for distribution.

I don't think supporting two different firmware versions is a good
idea for the case of the xc5000 driver.

-Mike Krufky

Re: [PATCH 1/3] xc5000: tuner firmware update

[Mauro Carvalho Chehab]

Em Mon, 27 Oct 2014 10:25:48 -0400
Michael Ira Krufky <mkrufky@linuxtv.org> escreveu:

> On Mon, Oct 27, 2014 at 7:46 AM, Mauro Carvalho Chehab
> <m.chehab@samsung.com> wrote:
> > Em Sat, 25 Oct 2014 16:17:21 -0400
> > Michael Krufky <mkrufky@hotmail.com> escreveu:
> >
> >> From: Richard Vollkommer <linux@hauppauge.com>
> >>
> >> - Update the xc5000 tuner firmware to version 1.6.821
> >>
> >> - Update the xc5000c tuner firmware to version 4.1.33
> >>
> >> Firmware files can be downloaded from:
> >>
> >> - http://hauppauge.lightpath.net/software/hvr950q/xc5000c-4.1.33.zip
> >> - http://hauppauge.lightpath.net/software/hvr950q/xc5000-1.6.821.zip
> >>
> >> Signed-off-by: Richard Vollkommer <linux@hauppauge.com>
> >> Cc: Devin Heitmueller <dheitmueller@kernellabs.com>
> >> Signed-off-by: Michael Ira Krufky <mkrufky@linuxtv.org>
> >
> > Hi Michael,
> >
> > Please use a logic that would allow the old firmware files to allow
> > falling back to the previous firmware version if the new one is not
> > available.
> >
> > Regards,
> > Mauro
> >
> >> ---
> >>  drivers/media/tuners/xc5000.c | 14 +++++++-------
> >>  1 file changed, 7 insertions(+), 7 deletions(-)
> >>
> >> diff --git a/drivers/media/tuners/xc5000.c b/drivers/media/tuners/xc5000.c
> >> index e44c8ab..fafff4c 100644
> >> --- a/drivers/media/tuners/xc5000.c
> >> +++ b/drivers/media/tuners/xc5000.c
> >> @@ -222,15 +222,15 @@ struct xc5000_fw_cfg {
> >>       u8 fw_checksum_supported;
> >>  };
> >>
> >> -#define XC5000A_FIRMWARE "dvb-fe-xc5000-1.6.114.fw"
> >> -static const struct xc5000_fw_cfg xc5000a_1_6_114 = {
> >> +#define XC5000A_FIRMWARE "dvb-fe-xc5000-1.6.821.fw"
> >> +static const struct xc5000_fw_cfg xc5000a_fw_cfg = {
> >>       .name = XC5000A_FIRMWARE,
> >>       .size = 12401,
> >> -     .pll_reg = 0x806c,
> >> +     .pll_reg = 0x8067,
> >>  };
> >>
> >> -#define XC5000C_FIRMWARE "dvb-fe-xc5000c-4.1.30.7.fw"
> >> -static const struct xc5000_fw_cfg xc5000c_41_024_5 = {
> >> +#define XC5000C_FIRMWARE "dvb-fe-xc5000c-4.1.33.fw"
> >> +static const struct xc5000_fw_cfg xc5000c_fw_cfg = {
> >>       .name = XC5000C_FIRMWARE,
> >>       .size = 16497,
> >>       .pll_reg = 0x13,
> >> @@ -243,9 +243,9 @@ static inline const struct xc5000_fw_cfg *xc5000_assign_firmware(int chip_id)
> >>       switch (chip_id) {
> >>       default:
> >>       case XC5000A:
> >> -             return &xc5000a_1_6_114;
> >> +             return &xc5000a_fw_cfg;
> >>       case XC5000C:
> >> -             return &xc5000c_41_024_5;
> >> +             return &xc5000c_fw_cfg;
> >>       }
> >>  }
> >>
> 
> 
> Mauro,
> 
> I like the idea of supporting older firmware revisions if the new one
> is not present, but, the established president for this sort of thing
> has always been to replace older firmware with newer firmware without
> backward compatibility support for older binaries.

No, we're actually adding backward support. There are some drivers
already with it. See for example xc4000 (changeset da7bfa2c5df).

> Although the current driver can work with both old and new firmware
> versions, this hasn't been the case in the past, and won't always be
> the case with future firmware revisions.

Yeah, we did a very crap job breaking backward firmware compat in
the past. We're not doing it anymore ;)

> Hauppauge has provided links to the new firmware for both the XC5000
> and XC5000C chips along with licensing.  Maybe instead, we can just
> upstream those into the linux-firmware packages for distribution.

Upstreaming to linux-firmware was done already for the previous firmwares.
The firmwares at linux-firmware for xc5000 and xc5000c were merged back 
there for 3.17 a few weeks ago.

Feel free to submit them a new version.

> I don't think supporting two different firmware versions is a good
> idea for the case of the xc5000 driver.

Why not? It should work as-is with either version. We can always add
some backward compat code if needed.

> 
> -Mike Krufky

Re: [PATCH 1/3] xc5000: tuner firmware update

[Johannes Stezenbach]

On Mon, Oct 27, 2014 at 01:57:27PM -0200, Mauro Carvalho Chehab wrote:
> Em Mon, 27 Oct 2014 10:25:48 -0400
> Michael Ira Krufky <mkrufky@linuxtv.org> escreveu:
> 
> > I like the idea of supporting older firmware revisions if the new one
> > is not present, but, the established president for this sort of thing
> > has always been to replace older firmware with newer firmware without
> > backward compatibility support for older binaries.
> 
> No, we're actually adding backward support. There are some drivers
> already with it. See for example xc4000 (changeset da7bfa2c5df).
> 
> > Although the current driver can work with both old and new firmware
> > versions, this hasn't been the case in the past, and won't always be
> > the case with future firmware revisions.
> 
> Yeah, we did a very crap job breaking backward firmware compat in
> the past. We're not doing it anymore ;)
> 
> > Hauppauge has provided links to the new firmware for both the XC5000
> > and XC5000C chips along with licensing.  Maybe instead, we can just
> > upstream those into the linux-firmware packages for distribution.
> 
> Upstreaming to linux-firmware was done already for the previous firmwares.
> The firmwares at linux-firmware for xc5000 and xc5000c were merged back 
> there for 3.17 a few weeks ago.
> 
> Feel free to submit them a new version.
> 
> > I don't think supporting two different firmware versions is a good
> > idea for the case of the xc5000 driver.
> 
> Why not? It should work as-is with either version. We can always add
> some backward compat code if needed.

FWIW, Linus recently addressed the topic wrt wireless firmware:
http://article.gmane.org/gmane.linux.kernel.wireless.general/126794


HTH,
Johannes

Re: [PATCH 1/3] xc5000: tuner firmware update

[Michael Ira Krufky]

On Mon, Oct 27, 2014 at 12:22 PM, Johannes Stezenbach <js@linuxtv.org> wrote:
> On Mon, Oct 27, 2014 at 01:57:27PM -0200, Mauro Carvalho Chehab wrote:
>> Em Mon, 27 Oct 2014 10:25:48 -0400
>> Michael Ira Krufky <mkrufky@linuxtv.org> escreveu:
>>
>> > I like the idea of supporting older firmware revisions if the new one
>> > is not present, but, the established president for this sort of thing
>> > has always been to replace older firmware with newer firmware without
>> > backward compatibility support for older binaries.
>>
>> No, we're actually adding backward support. There are some drivers
>> already with it. See for example xc4000 (changeset da7bfa2c5df).
>>
>> > Although the current driver can work with both old and new firmware
>> > versions, this hasn't been the case in the past, and won't always be
>> > the case with future firmware revisions.
>>
>> Yeah, we did a very crap job breaking backward firmware compat in
>> the past. We're not doing it anymore ;)
>>
>> > Hauppauge has provided links to the new firmware for both the XC5000
>> > and XC5000C chips along with licensing.  Maybe instead, we can just
>> > upstream those into the linux-firmware packages for distribution.
>>
>> Upstreaming to linux-firmware was done already for the previous firmwares.
>> The firmwares at linux-firmware for xc5000 and xc5000c were merged back
>> there for 3.17 a few weeks ago.
>>
>> Feel free to submit them a new version.
>>
>> > I don't think supporting two different firmware versions is a good
>> > idea for the case of the xc5000 driver.
>>
>> Why not? It should work as-is with either version. We can always add
>> some backward compat code if needed.
>
> FWIW, Linus recently addressed the topic wrt wireless firmware:
> http://article.gmane.org/gmane.linux.kernel.wireless.general/126794
>
>
> HTH,
> Johannes

OK, I read Linus' email.  I am willing to add an additional patch that
will look for the new firmware image and fall back to the older one if
the new one is not present, but I strongly believe that we should only
support both firmware revisions for a finite period of time -- this
can give people (and distros) time to update to the newer firmware,
and will help to eliminate future bug reports and quality issues that
would otherwise have been resolved by moving to the new firmware.

The new firmware image itself is a bug-fix and improves tuning
performance.  If users complain of quality issues using the old
firmware, it will not be very likely to gain developer interest, as
only the new firmware is considered to be truly "supported" now.

Is this acceptable?

-Mike Krufky

Re: [PATCH 1/3] xc5000: tuner firmware update

[Mauro Carvalho Chehab]

Em Mon, 27 Oct 2014 13:38:38 -0400
Michael Ira Krufky <mkrufky@linuxtv.org> escreveu:

> On Mon, Oct 27, 2014 at 12:22 PM, Johannes Stezenbach <js@linuxtv.org> wrote:
> > On Mon, Oct 27, 2014 at 01:57:27PM -0200, Mauro Carvalho Chehab wrote:
> >> Em Mon, 27 Oct 2014 10:25:48 -0400
> >> Michael Ira Krufky <mkrufky@linuxtv.org> escreveu:
> >>
> >> > I like the idea of supporting older firmware revisions if the new one
> >> > is not present, but, the established president for this sort of thing
> >> > has always been to replace older firmware with newer firmware without
> >> > backward compatibility support for older binaries.
> >>
> >> No, we're actually adding backward support. There are some drivers
> >> already with it. See for example xc4000 (changeset da7bfa2c5df).
> >>
> >> > Although the current driver can work with both old and new firmware
> >> > versions, this hasn't been the case in the past, and won't always be
> >> > the case with future firmware revisions.
> >>
> >> Yeah, we did a very crap job breaking backward firmware compat in
> >> the past. We're not doing it anymore ;)
> >>
> >> > Hauppauge has provided links to the new firmware for both the XC5000
> >> > and XC5000C chips along with licensing.  Maybe instead, we can just
> >> > upstream those into the linux-firmware packages for distribution.
> >>
> >> Upstreaming to linux-firmware was done already for the previous firmwares.
> >> The firmwares at linux-firmware for xc5000 and xc5000c were merged back
> >> there for 3.17 a few weeks ago.
> >>
> >> Feel free to submit them a new version.
> >>
> >> > I don't think supporting two different firmware versions is a good
> >> > idea for the case of the xc5000 driver.
> >>
> >> Why not? It should work as-is with either version. We can always add
> >> some backward compat code if needed.
> >
> > FWIW, Linus recently addressed the topic wrt wireless firmware:
> > http://article.gmane.org/gmane.linux.kernel.wireless.general/126794
> >
> >
> > HTH,
> > Johannes
> 
> OK, I read Linus' email.  I am willing to add an additional patch that
> will look for the new firmware image and fall back to the older one if
> the new one is not present, but I strongly believe that we should only
> support both firmware revisions for a finite period of time -- this
> can give people (and distros) time to update to the newer firmware,
> and will help to eliminate future bug reports and quality issues that
> would otherwise have been resolved by moving to the new firmware.
> The new firmware image itself is a bug-fix and improves tuning
> performance.  If users complain of quality issues using the old
> firmware, it will not be very likely to gain developer interest, as
> only the new firmware is considered to be truly "supported" now.


Well, perhaps you could add a printk message warning the user that
the driver is not using the latest firmware and performance/quality
could be badly affected.

> 
> Is this acceptable?
> 
> -Mike Krufky

Regards,
Mauro

Re: [PATCH 1/3] xc5000: tuner firmware update

[Devin Heitmueller]

> Well, perhaps you could add a printk message warning the user that
> the driver is not using the latest firmware and performance/quality
> could be badly affected.

I wouldn't use the term "badly affected".  There are tens of thousands
of units out there for which users are quite happy with the current
firmware.  The firmware fixes an edge case that affected a very small
subset of users when receiving signals from a specific QAM modulator
product.  The vast majority of users would be perfectly fine using the
old firmware indefinitely.

That said, I certainly have no objection to a message stating that
there is newer firmware available than what they are currently
running.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com