From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Matthias Schwarzott <zzam@gentoo.org>
Cc: crope@iki.fi, linux-media@vger.kernel.org
Subject: Re: [PATCH v4 00/14] cx231xx: Use muxed i2c adapters instead of custom switching
Date: Thu, 30 Oct 2014 18:27:06 -0200 [thread overview]
Message-ID: <20141030182706.09265d37@recife.lan> (raw)
In-Reply-To: <1414699955-5760-1-git-send-email-zzam@gentoo.org>
Em Thu, 30 Oct 2014 21:12:21 +0100
Matthias Schwarzott <zzam@gentoo.org> escreveu:
> Hi!
>
> This time the series got only small updates from Antti's review.
Oh, no! I just merged the v3 patch series. I manually fixed the
points that Antti has made.
I'm also testing it already.
Could you, instead, rebase it on the top of my merge?
I added it at:
ssh://linuxtv.org/git/mchehab/experimental.git cx231xx
While I'm still at the test phases.
>
> Additionally I added a patch to no longer directly modify
> the content of the port3 switch bit in PWR_CTL_EN (from function cx231xx_set_power_mode).
>
> Now there are two places where I wonder what happens:
> 1. cx231xx_set_Colibri_For_LowIF writes a fixed number into all 8bit parts of PWR_CTL_EN
> What is this for?
> 2. I guess, cx231xx_demod_reset should reset the digital demod. For this it should toggle the bits 0 and 1 of PWR_CTL_EN.
> But instead it touches but 8 and 9.
> Does someone know what this is?
>
> 3. Is remembering the last status of the port3 bit working good enough?
> Currently it is only used for the is_tuner hack function.
>
> Regards
> Matthias
>
next prev parent reply other threads:[~2014-10-30 20:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 20:12 [PATCH v4 00/14] cx231xx: Use muxed i2c adapters instead of custom switching Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 01/14] cx231xx: let i2c bus scanning use its own i2c_client Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 02/14] cx231xx: use own i2c_client for eeprom access Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 03/14] cx231xx: delete i2c_client per bus Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 04/14] cx231xx: give each master i2c bus a seperate name Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 05/14] cx231xx: Modifiy the symbolic constants for i2c ports and describe Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 06/14] cx231xx: Use symbolic constants for i2c ports instead of numbers Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 07/14] cx231xx: add wrapper to get the i2c_adapter pointer Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 08/14] cx231xx: remember status of i2c port_3 switch Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 09/14] cx231xx: let is_tuner check the real i2c port and not the i2c master number Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 10/14] cx231xx: change usage of I2C_1 to the real i2c port Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 11/14] cx231xx: register i2c mux adapters for master1 and use as I2C_1_MUX_1 and I2C_1_MUX_3 Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 12/14] cx231xx: remove direct register PWR_CTL_EN modification that switches port3 Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 13/14] cx231xx: drop unconditional port3 switching Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 14/14] cx231xx: scan all four existing i2c busses instead of the 3 masters Matthias Schwarzott
2014-10-30 20:27 ` Mauro Carvalho Chehab [this message]
2014-10-30 22:43 ` [PATCH] cx231xx: remove direct register PWR_CTL_EN modification that switches port3 Matthias Schwarzott
2014-10-30 22:45 ` Matthias Schwarzott
2014-10-31 10:32 ` Mauro Carvalho Chehab
2014-10-31 13:09 ` Matthias Schwarzott
2014-10-31 16:37 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030182706.09265d37@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=zzam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).