From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Matthias Schwarzott <zzam@gentoo.org>
Cc: crope@iki.fi, linux-media@vger.kernel.org
Subject: Re: [PATCH] cx231xx: remove direct register PWR_CTL_EN modification that switches port3
Date: Fri, 31 Oct 2014 08:32:58 -0200 [thread overview]
Message-ID: <20141031083258.4cfd463a@recife.lan> (raw)
In-Reply-To: <1414709035-7729-1-git-send-email-zzam@gentoo.org>
Em Thu, 30 Oct 2014 23:43:55 +0100
Matthias Schwarzott <zzam@gentoo.org> escreveu:
> The only remaining place that modifies the relevant bit is in function
> cx231xx_set_Colibri_For_LowIF
>
> Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
> ---
> drivers/media/usb/cx231xx/cx231xx-avcore.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/cx231xx/cx231xx-avcore.c b/drivers/media/usb/cx231xx/cx231xx-avcore.c
> index b56bc87..781908b 100644
> --- a/drivers/media/usb/cx231xx/cx231xx-avcore.c
> +++ b/drivers/media/usb/cx231xx/cx231xx-avcore.c
> @@ -2270,7 +2270,6 @@ int cx231xx_set_power_mode(struct cx231xx *dev, enum AV_MODE mode)
> case POLARIS_AVMODE_ANALOGT_TV:
>
> tmp |= PWR_DEMOD_EN;
> - tmp |= (I2C_DEMOD_EN);
> value[0] = (u8) tmp;
> value[1] = (u8) (tmp >> 8);
> value[2] = (u8) (tmp >> 16);
> @@ -2366,7 +2365,7 @@ int cx231xx_set_power_mode(struct cx231xx *dev, enum AV_MODE mode)
> }
>
> tmp &= (~PWR_AV_MODE);
> - tmp |= POLARIS_AVMODE_DIGITAL | I2C_DEMOD_EN;
> + tmp |= POLARIS_AVMODE_DIGITAL;
> value[0] = (u8) tmp;
> value[1] = (u8) (tmp >> 8);
> value[2] = (u8) (tmp >> 16);
Hmm... Not sure if this patch is right. There is one I2C bus internally
at cx231xx. Some configurations need to go through this I2C bus.
Did you test if changing from/to analog/digital mode is working?
Regards,
Mauro
next prev parent reply other threads:[~2014-10-31 10:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 20:12 [PATCH v4 00/14] cx231xx: Use muxed i2c adapters instead of custom switching Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 01/14] cx231xx: let i2c bus scanning use its own i2c_client Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 02/14] cx231xx: use own i2c_client for eeprom access Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 03/14] cx231xx: delete i2c_client per bus Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 04/14] cx231xx: give each master i2c bus a seperate name Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 05/14] cx231xx: Modifiy the symbolic constants for i2c ports and describe Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 06/14] cx231xx: Use symbolic constants for i2c ports instead of numbers Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 07/14] cx231xx: add wrapper to get the i2c_adapter pointer Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 08/14] cx231xx: remember status of i2c port_3 switch Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 09/14] cx231xx: let is_tuner check the real i2c port and not the i2c master number Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 10/14] cx231xx: change usage of I2C_1 to the real i2c port Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 11/14] cx231xx: register i2c mux adapters for master1 and use as I2C_1_MUX_1 and I2C_1_MUX_3 Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 12/14] cx231xx: remove direct register PWR_CTL_EN modification that switches port3 Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 13/14] cx231xx: drop unconditional port3 switching Matthias Schwarzott
2014-10-30 20:12 ` [PATCH v4 14/14] cx231xx: scan all four existing i2c busses instead of the 3 masters Matthias Schwarzott
2014-10-30 20:27 ` [PATCH v4 00/14] cx231xx: Use muxed i2c adapters instead of custom switching Mauro Carvalho Chehab
2014-10-30 22:43 ` [PATCH] cx231xx: remove direct register PWR_CTL_EN modification that switches port3 Matthias Schwarzott
2014-10-30 22:45 ` Matthias Schwarzott
2014-10-31 10:32 ` Mauro Carvalho Chehab [this message]
2014-10-31 13:09 ` Matthias Schwarzott
2014-10-31 16:37 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141031083258.4cfd463a@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=zzam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).