From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Pavel Machek <pavel@ucw.cz>,
Konrad Zapalowicz <bergo.torino@gmail.com>,
Christian Resell <christian.resell@gmail.com>,
devel@driverdev.osuosl.org, askb23@gmail.com,
linux-kernel@vger.kernel.org, yongjun_wei@trendmicro.com.cn,
hans.verkuil@cisco.com, pali.rohar@gmail.com,
fengguang.wu@intel.com, linux-media@vger.kernel.org
Subject: Re: [PATCH] staging: media: bcm2048: fix coding style error
Date: Sun, 16 Nov 2014 08:20:23 -0200 [thread overview]
Message-ID: <20141116082023.73460409@recife.lan> (raw)
In-Reply-To: <20141115212503.GA21773@kroah.com>
Em Sat, 15 Nov 2014 13:25:03 -0800
Greg KH <gregkh@linuxfoundation.org> escreveu:
> On Sat, Nov 15, 2014 at 09:59:34PM +0100, Pavel Machek wrote:
> > On Sat 2014-11-15 21:12:18, Konrad Zapalowicz wrote:
> > > On 11/15, Christian Resell wrote:
> > > > Simple style fix (checkpatch.pl: "space prohibited before that ','").
> > > > For the eudyptula challenge (http://eudyptula-challenge.org/).
> > >
> > > Nice, however we do not need the information about the 'eudyptula
> > > challenge' in the commit message.
> > >
> > > If you want to include extra information please do it after the '---'
> > > line (just below the signed-off). You will find more details in the
> > > SubmittingPatches (chapter 15) of the kernel documentation.
> >
> > Greg is staging tree maintainer... And if single extra space is all
> > you can fix in the driver, perhaps it is not worth the patch?
>
> I am not the maintainer of drivers/staging/media/ please look at
> MAINTAINERS before you make statements like that.
>
> And yes, one space fixes is just fine, that's why the code is in
> staging.
Yes, space fixes is OK for staging.
I'll apply this patch, removing the line that comments about the challenge,
as we don't need to keep this information forever at the Kernel history.
Regards,
Mauro
next prev parent reply other threads:[~2014-11-16 10:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-15 19:43 [PATCH] staging: media: bcm2048: fix coding style error Christian Resell
2014-11-15 20:12 ` Konrad Zapalowicz
2014-11-15 20:59 ` Pavel Machek
2014-11-15 21:25 ` Greg KH
2014-11-16 10:20 ` Mauro Carvalho Chehab [this message]
2014-11-15 21:32 ` Konrad Zapalowicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141116082023.73460409@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=askb23@gmail.com \
--cc=bergo.torino@gmail.com \
--cc=christian.resell@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).