From: Jonathan Corbet <corbet@lwn.net>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
LMML <linux-media@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/12] media: marvell-ccic: use vb2_ops_wait_prepare/finish helper
Date: Tue, 18 Nov 2014 08:03:17 -0500 [thread overview]
Message-ID: <20141118080317.73b6b29e@lwn.net> (raw)
In-Reply-To: <1416309821-5426-7-git-send-email-prabhakar.csengg@gmail.com>
On Tue, 18 Nov 2014 11:23:35 +0000
"Lad, Prabhakar" <prabhakar.csengg@gmail.com> wrote:
> drivers/media/platform/marvell-ccic/mcam-core.c | 29 +++++--------------------
> 1 file changed, 5 insertions(+), 24 deletions(-)
So I'm not convinced that this patch improves things; it moves a tiny bit
of code into another file where anybody reading the driver will have to
go look to see what's going on. But I guess it doesn't really make
things worse either; I won't try to stand in its way. It would be nice
to see a real changelog on the patch, though.
jon
next prev parent reply other threads:[~2014-11-18 13:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 11:23 [PATCH 00/12] media: use vb2_ops_wait_prepare/finish helper Lad, Prabhakar
2014-11-18 11:23 ` [PATCH 01/12] media: s3c-camif: " Lad, Prabhakar
2014-11-18 11:23 ` [PATCH 02/12] media: ti-vpe: " Lad, Prabhakar
2014-11-18 11:23 ` [PATCH 03/12] media: exynos-gsc: " Lad, Prabhakar
2014-11-18 11:23 ` [PATCH 04/12] media: soc_camera: " Lad, Prabhakar
2014-11-18 11:23 ` [PATCH 05/12] media: sh_veu: " Lad, Prabhakar
2014-11-18 11:23 ` [PATCH 06/12] media: marvell-ccic: " Lad, Prabhakar
2014-11-18 13:03 ` Jonathan Corbet [this message]
2014-11-18 13:23 ` Prabhakar Lad
2014-11-18 14:31 ` Jonathan Corbet
2014-11-18 11:23 ` [PATCH 07/12] media: s5p-tv: " Lad, Prabhakar
2014-11-18 11:23 ` [PATCH 08/12] media: blackfin: " Lad, Prabhakar
2014-11-18 11:23 ` [PATCH 09/12] media: s5p-mfc: " Lad, Prabhakar
2014-11-25 11:24 ` Kamil Debski
2014-11-18 11:23 ` [PATCH 10/12] media: vivid: " Lad, Prabhakar
2014-11-18 11:23 ` [PATCH 11/12] media: davinci: vpif_capture: " Lad, Prabhakar
2014-11-18 11:23 ` [PATCH 12/12] media: usb: uvc: " Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118080317.73b6b29e@lwn.net \
--to=corbet@lwn.net \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox