* [PATCH] Staging: media: lirc: lirc_serial: replaced printk with pr_debug
@ 2014-11-21 13:21 Abel Moyo
2014-11-25 11:50 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 2+ messages in thread
From: Abel Moyo @ 2014-11-21 13:21 UTC (permalink / raw)
To: jarod; +Cc: m.chehab, devel, linux-media
Replaced printk with pr_debug in dprintk
Signed-off-by: Abel Moyo <abelmoyo.ab@gmail.com>
---
drivers/staging/media/lirc/lirc_serial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/lirc/lirc_serial.c b/drivers/staging/media/lirc/lirc_serial.c
index 181b92b..86c5274 100644
--- a/drivers/staging/media/lirc/lirc_serial.c
+++ b/drivers/staging/media/lirc/lirc_serial.c
@@ -116,7 +116,7 @@ static bool txsense; /* 0 = active high, 1 = active low */
#define dprintk(fmt, args...) \
do { \
if (debug) \
- printk(KERN_DEBUG LIRC_DRIVER_NAME ": " \
+ pr_debug(LIRC_DRIVER_NAME ": " \
fmt, ## args); \
} while (0)
--
1.8.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: media: lirc: lirc_serial: replaced printk with pr_debug
2014-11-21 13:21 [PATCH] Staging: media: lirc: lirc_serial: replaced printk with pr_debug Abel Moyo
@ 2014-11-25 11:50 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2014-11-25 11:50 UTC (permalink / raw)
To: Abel Moyo; +Cc: jarod, devel, linux-media
Em Fri, 21 Nov 2014 14:21:40 +0100
Abel Moyo <abelmoyo.ab@gmail.com> escreveu:
> Replaced printk with pr_debug in dprintk
>
> Signed-off-by: Abel Moyo <abelmoyo.ab@gmail.com>
> ---
> drivers/staging/media/lirc/lirc_serial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/lirc/lirc_serial.c b/drivers/staging/media/lirc/lirc_serial.c
> index 181b92b..86c5274 100644
> --- a/drivers/staging/media/lirc/lirc_serial.c
> +++ b/drivers/staging/media/lirc/lirc_serial.c
> @@ -116,7 +116,7 @@ static bool txsense; /* 0 = active high, 1 = active low */
> #define dprintk(fmt, args...) \
> do { \
> if (debug) \
> - printk(KERN_DEBUG LIRC_DRIVER_NAME ": " \
> + pr_debug(LIRC_DRIVER_NAME ": " \
> fmt, ## args); \
> } while (0)
>
No, this is a bad idea. If dynamic_printk is enabled, in order to
activate the debug messages, it would be required to enable debug
modprobe parameter _and_ to enable each debug msg individually.
We should either use one or the other approach.
Regards,
Mauro
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-25 11:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-21 13:21 [PATCH] Staging: media: lirc: lirc_serial: replaced printk with pr_debug Abel Moyo
2014-11-25 11:50 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).