From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Michael Ira Krufky <mkrufky@linuxtv.org>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH] [media] tda18271: Fix identation
Date: Thu, 27 Nov 2014 16:59:25 -0200 [thread overview]
Message-ID: <20141127165925.05723c7b@recife.lan> (raw)
In-Reply-To: <CAOcJUbwiDEvp3-c+j7B1L9MxFjnrw9mT0116C+Dy9p4hOQNEhg@mail.gmail.com>
Em Thu, 27 Nov 2014 13:47:09 -0500
Michael Ira Krufky <mkrufky@linuxtv.org> escreveu:
> On Wed, Nov 26, 2014 at 10:26 AM, Mauro Carvalho Chehab
> <mchehab@osg.samsung.com> wrote:
> > As reported by smatch:
> > drivers/media/tuners/tda18271-common.c:176 tda18271_read_extended() warn: if statement not indented
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> >
> > diff --git a/drivers/media/tuners/tda18271-common.c b/drivers/media/tuners/tda18271-common.c
> > index 86e5e3110118..6118203543ea 100644
> > --- a/drivers/media/tuners/tda18271-common.c
> > +++ b/drivers/media/tuners/tda18271-common.c
> > @@ -173,12 +173,9 @@ int tda18271_read_extended(struct dvb_frontend *fe)
> >
> > for (i = 0; i < TDA18271_NUM_REGS; i++) {
> > /* don't update write-only registers */
> > - if ((i != R_EB9) &&
> > - (i != R_EB16) &&
> > - (i != R_EB17) &&
> > - (i != R_EB19) &&
> > - (i != R_EB20))
> > - regs[i] = regdump[i];
> > + if ((i != R_EB9) && (i != R_EB16) && (i != R_EB17) &&
> > + (i != R_EB19) && (i != R_EB20))
> > + regs[i] = regdump[i];
> > }
> >
> > if (tda18271_debug & DBG_REG)
> > --
> > 1.9.3
> >
>
> Mauro,
>
> I would actually rather NOT merge this patch. This hurts the
> readability of the code. If applied already, please revert it.
What hurts readability is to not indent regs[i] = regdump[i];
>
> Cheers,
>
> Mike
next prev parent reply other threads:[~2014-11-27 18:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 15:26 [PATCH] [media] tda18271: Fix identation Mauro Carvalho Chehab
2014-11-27 18:47 ` Michael Ira Krufky
2014-11-27 18:59 ` Mauro Carvalho Chehab [this message]
2014-11-27 19:04 ` Michael Ira Krufky
2014-11-27 21:45 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141127165925.05723c7b@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mkrufky@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).